{"thread":{"id":"11170","subject":"Re: git-am: catch missing author date early.","startedAt":"2007-12-07T02:34:47Z","lastAt":"2007-12-07T06:06:13Z","messageCount":2,"participants":["Len Brown","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"62228","messageId":"200712062134.47330.lenb@kernel.org","threadId":"11170","inReplyTo":null,"subject":"Re: git-am: catch missing author date early.","fromName":"Len Brown","fromEmail":"lenb@kernel.org","sentAt":"2007-12-07T02:34:47Z","receivedAt":"2007-12-07T02:34:47Z","isPatch":false,"sender":{"key":"lenb@kernel.org","avatar":null},"body":"This change made git-am more difficult to use.\n\nI tend to check-in a fair number of patches that didn't come from an e-mail message.\nIn the past, I slap a Subject: and a From: on the top of the commit message\nand off I go.\n\nWith this change git-am fails b/c I haven't also conjured up the time,\nwhen in the past it figured out what time it was for me.\n\nthanks,\n-Len\n\ncommit 6e9e0327b7d7f384d8a223b4bc40330ef3e7fb61\nAuthor: Junio C Hamano <gitster@pobox.com>\nDate:   Sun Dec 2 14:38:40 2007 -0800\n\n    git-am: catch missing author date early.\n    \n    Even though commit-tree would default to the current time if the incoming\n    e-mail message somehow did not record the timestamp, it is safer to catch\n    the breakage sooner.\n    \n    Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\ndiff --git a/git-am.sh b/git-am.sh\nindex 76c1c84..2e40708 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -307,9 +307,9 @@ do\n \tGIT_AUTHOR_EMAIL=\"$(sed -n '/^Email/ s/Email: //p' \"$dotest/info\")\"\n \tGIT_AUTHOR_DATE=\"$(sed -n '/^Date/ s/Date: //p' \"$dotest/info\")\"\n \n-\tif test -z \"$GIT_AUTHOR_EMAIL\"\n+\tif test -z \"$GIT_AUTHOR_EMAIL\" || test -z \"$GIT_AUTHOR_DATE\"\n \tthen\n-\t\techo \"Patch does not have a valid e-mail address.\"\n+\t\techo \"Patch does not have valid authorship information.\"\n \t\tstop_here $this\n \tfi\n \n"},{"id":"62243","messageId":"7vk5nr82ei.fsf@gitster.siamese.dyndns.org","threadId":"11170","inReplyTo":"200712062134.47330.lenb@kernel.org","subject":"Re: git-am: catch missing author date early.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-07T06:06:13Z","receivedAt":"2007-12-07T06:06:13Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sorry, and thanks for the report.\n\nJens complained the same yesterday and the change was reverted.\n"}]}