{"thread":{"id":"11165","subject":"XML parsing error from gitweb at freedesktop.org","startedAt":"2007-12-06T21:34:55Z","lastAt":"2007-12-08T10:49:44Z","messageCount":3,"participants":["Adam Mercer","Lars Hjemli","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"62200","messageId":"799406d60712061334q33d2dba5r5496ba21069a4547@mail.gmail.com","threadId":"11165","inReplyTo":null,"subject":"XML parsing error from gitweb at freedesktop.org","fromName":"Adam Mercer","fromEmail":"ramercer@gmail.com","sentAt":"2007-12-06T21:34:55Z","receivedAt":"2007-12-06T21:34:55Z","isPatch":false,"sender":{"key":"ramercer@gmail.com","avatar":"https://gravatar.com/avatar/16dc719817f62b75075d529ce4ea992ee82bb1a08e45a3029797f39223d6ee64?d=mp&s=160"},"body":"Hi\n\nIn looking through some commits on the freedesktop.org gitweb I\nencountered an error trying to view the following commit\n\n\n\nIn viewing the page under Safari on Mac OS X Leopard the following\nerror is displayed:\n\nThis page contains the following errors:\nerror on line 7998 at column 129634: internal error\n\nCamino & Firefox both display:\n\nXML Parsing Error: not well-formed\nLocation: http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commitdiff;h=48e6a75fbdd0fee86e364f02ace83f20b312a2b2\nLine Number 7998, Column 24:\n\n
-
\n-----------------------^\n\nas cgit displays the commit OK\n\n\n\nleads me to think that the problem lies in gitweb. Could this be a\nproblem with gitweb?\n\nCheers\n\nAdam\n"},{"id":"62206","messageId":"8c5c35580712061411k7a40a08el35f31c43add25cb3@mail.gmail.com","threadId":"11165","inReplyTo":"799406d60712061334q33d2dba5r5496ba21069a4547@mail.gmail.com","subject":"Re: XML parsing error from gitweb at freedesktop.org","fromName":"Lars Hjemli","fromEmail":"hjemli@gmail.com","sentAt":"2007-12-06T22:11:32Z","receivedAt":"2007-12-06T22:11:32Z","isPatch":false,"sender":{"key":"hjemli@gmail.com","avatar":null},"body":"On Dec 6, 2007 10:34 PM, Adam Mercer wrote:\n> as cgit displays the commit OK\n>\n> \n>\n> leads me to think that the problem lies in gitweb. Could this be a\n> problem with gitweb?\n>\n\nActually, it's a problem in both cgit and gitweb, but you need to look\na bit harder to find the error in cgit. It seems that gitweb on\nfreedesktop.org doesn't detect a file rename (due to diff.renamelimit\nmaybe?), so it shows the full source of the offending files, while in\ncgit you'll need to go from the diff to either the old or the new\nsourcefile to get the same error:\n\nhttp://cgit.freedesktop.org/xorg/xserver/tree/hw/darwin/quartz/applewmExt.h?h=xorg-server-1.2-apple&id=141f69dc3d8d6e7d8ff65607f43700ac11243041\nhttp://cgit.freedesktop.org/xorg/xserver/diff/hw/xquartz/applewm.c?h=xorg-server-1.2-apple&id=48e6a75fbdd0fee86e364f02ace83f20b312a2b2\n\nThe problem is a number of unencoded ascii char 12.\n\n--\nlarsh\n"},{"id":"62398","messageId":"m3d4thtqaq.fsf@roke.D-201","threadId":"11165","inReplyTo":"8c5c35580712061411k7a40a08el35f31c43add25cb3@mail.gmail.com","subject":"Re: XML parsing error from gitweb at freedesktop.org","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-08T10:49:44Z","receivedAt":"2007-12-08T10:49:44Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"\"Lars Hjemli\" writes:\n\n> On Dec 6, 2007 10:34 PM, Adam Mercer wrote:\n>>\n>> as cgit displays the commit OK\n>>\n>> \n>>\n>> leads me to think that the problem lies in gitweb. Could this be a\n>> problem with gitweb?\n>>\n> \n> Actually, it's a problem in both cgit and gitweb, but you need to look\n> a bit harder to find the error in cgit. It seems that gitweb on\n> freedesktop.org doesn't detect a file rename (due to diff.renamelimit\n> maybe?), so it shows the full source of the offending files, while in\n> cgit you'll need to go from the diff to either the old or the new\n> sourcefile to get the same error:\n> \n> http://cgit.freedesktop.org/xorg/xserver/tree/hw/darwin/quartz/applewmExt.h?h=xorg-server-1.2-apple&id=141f69dc3d8d6e7d8ff65607f43700ac11243041\n> http://cgit.freedesktop.org/xorg/xserver/diff/hw/xquartz/applewm.c?h=xorg-server-1.2-apple&id=48e6a75fbdd0fee86e364f02ace83f20b312a2b2\n> \n> The problem is a number of unencoded ascii char 12.\n\nStrange... I have checked gitweb code, and esc_html used in HTML\nversion of diff output escapes _all_ control characters ([:cntrl:]).\nSo ASCII char 12 should be shown as \\014 in \"cntrl\" style.\n\nAhhh... I see, Freedesktop.org uses some ANCIENT version of gitweb,\nfrom before it was included in git repository.\n\nTry to ask Freedesktop.org admins to upgrade gitweb. Some nice\nfeatures include:\n * mod_perl compatibility\n * ability to display binary files correctly\n * gitweb do not use /usr/bin/diff, and do not use temporary files\n (and supports renames, typechanges and combined diff format)\n * better support for strange characters in contents and in pathnames\n * very basic support for submodules\n * snapshot support (optional)\n * forks support (optional)\n * 'next' links in 'commit' and 'commitdiff' view\n * optional features: commit search, pickaxe search, snapshots\n support,...\n\n-- \nJakub Narebski\nShadeHawk on #git\n"}]}