{"thread":{"id":"11105","subject":"[PATCH] Reorder msgfmt command-line arguments.","startedAt":"2007-12-03T01:26:33Z","lastAt":"2007-12-04T02:07:48Z","messageCount":5,"participants":["brian m. carlson","Johannes Schindelin","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"61703","messageId":"20071203012631.GA22450@crustytoothpaste.ath.cx","threadId":"11105","inReplyTo":null,"subject":"[PATCH] Reorder msgfmt command-line arguments.","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.ath.cx","sentAt":"2007-12-03T01:26:33Z","receivedAt":"2007-12-03T01:26:33Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"Any program using getopt or getopt_long will stop processing options\nonce a non-option argument has been encountered, if POSIXLY_CORRECT is\nset.  Therefore, reorder the command-line arguments to put options\nfirst, so that the msgfmt call works in this scenario.\n\nSigned-off-by: brian m. carlson <sandals@crustytoothpaste.ath.cx>\n---\n\nNote that this patch is against the next branch, since that's what I \nuse.  It may or may not apply (or be needed) on the mainline.\n\n  git-gui/Makefile |    2 +-\n  1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex e860319..4ce4663 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -212,7 +212,7 @@ $(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES)\n  update-po:: $(PO_TEMPLATE)\n  \t$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )\n  $(ALL_MSGFILES): %.msg : %.po\n-\t$(QUIET_MSGFMT0)$(MSGFMT) --statistics --tcl $< -l $(basename $(notdir $<)) -d $(dir $@) $(QUIET_MSGFMT1)\n+\t$(QUIET_MSGFMT0)$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< $(QUIET_MSGFMT1)\n  \n  lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n  \t$(QUIET_INDEX)if echo \\\n-- \n1.5.3.6.1797.g67f5d\n"},{"id":"61764","messageId":"Pine.LNX.4.64.0712031034200.27959@racer.site","threadId":"11105","inReplyTo":"20071203012631.GA22450@crustytoothpaste.ath.cx","subject":"Re: [PATCH] Reorder msgfmt command-line arguments.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-12-03T10:35:33Z","receivedAt":"2007-12-03T10:35:33Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 3 Dec 2007, brian m. carlson wrote:\n\n> Any program using getopt or getopt_long will stop processing options \n> once a non-option argument has been encountered, if POSIXLY_CORRECT is \n> set.\n\nSo have you tested that msgfmt indeed does not work with the present \ncommand line?\n\nBesides, you probably want to send this as a git-gui patch: based on \ngit-gui.git, not git.git, and Cc'ed to Shawn Pearce.\n\nCiao,\nDscho\n"},{"id":"61787","messageId":"20071203170402.GA13712@crustytoothpaste.ath.cx","threadId":"11105","inReplyTo":"Pine.LNX.4.64.0712031034200.27959@racer.site","subject":"Re: [PATCH] Reorder msgfmt command-line arguments.","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.ath.cx","sentAt":"2007-12-03T17:04:02Z","receivedAt":"2007-12-03T17:04:02Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Dec 03, 2007 at 10:35:33AM +0000, Johannes Schindelin wrote:\n>On Mon, 3 Dec 2007, brian m. carlson wrote:\n>\n>> Any program using getopt or getopt_long will stop processing options \n>> once a non-option argument has been encountered, if POSIXLY_CORRECT is \n>> set.\n>\n>So have you tested that msgfmt indeed does not work with the present \n>command line?\n\nYes.  I run with POSIXLY_CORRECT set to 1, and it does indeed break.  I \nwouldn't have fixed it if it had worked.\n\nThere are parts of the git testsuite that hang in this case, too, but I \nhave yet to examine them.  Rest assured that there are indeed patches \ncoming, assuming the problems are fixable.\n\n>Besides, you probably want to send this as a git-gui patch: based on \n>git-gui.git, not git.git, and Cc'ed to Shawn Pearce.\n\nThanks.  Will do.\n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 713 440 7475 | http://crustytoothpaste.ath.cx/~bmc | My opinion only\na typesetting engine: http://crustytoothpaste.ath.cx/~bmc/code/thwack\nOpenPGP: RSA v4 4096b 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"61795","messageId":"Pine.LNX.4.64.0712031805310.27959@racer.site","threadId":"11105","inReplyTo":"20071203170402.GA13712@crustytoothpaste.ath.cx","subject":"Re: [PATCH] Reorder msgfmt command-line arguments.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-12-03T18:05:50Z","receivedAt":"2007-12-03T18:05:50Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 3 Dec 2007, brian m. carlson wrote:\n\n> On Mon, Dec 03, 2007 at 10:35:33AM +0000, Johannes Schindelin wrote:\n> > On Mon, 3 Dec 2007, brian m. carlson wrote:\n> > \n> > > Any program using getopt or getopt_long will stop processing options \n> > > once a non-option argument has been encountered, if POSIXLY_CORRECT \n> > > is set.\n> > \n> > So have you tested that msgfmt indeed does not work with the present \n> > command line?\n> \n> Yes.  I run with POSIXLY_CORRECT set to 1, and it does indeed break.  I \n> wouldn't have fixed it if it had worked.\n\nAh, so it is a not-so-common breakage.\n\nThanks for clarifying,\nDscho\n"},{"id":"61854","messageId":"20071204020748.GZ14735@spearce.org","threadId":"11105","inReplyTo":"20071203170402.GA13712@crustytoothpaste.ath.cx","subject":"Re: [PATCH] Reorder msgfmt command-line arguments.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-12-04T02:07:48Z","receivedAt":"2007-12-04T02:07:48Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"brian m. carlson\" <sandals@crustytoothpaste.ath.cx> wrote:\n> On Mon, Dec 03, 2007 at 10:35:33AM +0000, Johannes Schindelin wrote:\n> >On Mon, 3 Dec 2007, brian m. carlson wrote:\n> >\n> >>Any program using getopt or getopt_long will stop processing options \n> >>once a non-option argument has been encountered, if POSIXLY_CORRECT is \n> >>set.\n...\n> >Besides, you probably want to send this as a git-gui patch: based on \n> >git-gui.git, not git.git, and Cc'ed to Shawn Pearce.\n> \n> Thanks.  Will do.\n\nDon't bother.  I already did the necesary work to apply this patch\nto the git-gui.git tree.  It was small, obviously correct, and easy\nto fix up to make it apply to git-gui.git.  Its already pushed out\nin my master branch and will be in gitgui-0.9.1.\n\n-- \nShawn.\n"}]}