{"thread":{"id":"1110","subject":"[PATCH] Fixlet for argument parsing in rev-list.","startedAt":"2005-07-05T07:54:05Z","lastAt":"2005-07-05T09:14:32Z","messageCount":2,"participants":["Junio C Hamano","Jon Seymour"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"5660","messageId":"7vpstxg02q.fsf@assigned-by-dhcp.cox.net","threadId":"1110","inReplyTo":null,"subject":"[PATCH] Fixlet for argument parsing in rev-list.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-07-05T07:54:05Z","receivedAt":"2005-07-05T07:54:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The --merge-order flag does not take parameter so there is no\npoint doing strncmp with the length.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n\n rev-list.c |    2 +-\n 1 file changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/rev-list.c b/rev-list.c\n--- a/rev-list.c\n+++ b/rev-list.c\n@@ -462,7 +462,7 @@ int main(int argc, char **argv)\n \t\t\tlimited = 1;\n \t\t\tcontinue;\n \t\t}\n-\t\tif (!strncmp(arg, \"--merge-order\", 13)) {\n+\t\tif (!strcmp(arg, \"--merge-order\")) {\n \t\t        merge_order = 1;\n \t\t\tcontinue;\n \t\t}\n------------------------------------------------\n"},{"id":"5661","messageId":"2cfc40320507050214154c0fff@mail.gmail.com","threadId":"1110","inReplyTo":"7vpstxg02q.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fixlet for argument parsing in rev-list.","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2005-07-05T09:14:32Z","receivedAt":"2005-07-05T09:14:32Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"I ack the patch, though --show-breaks could use the same treatment.\n\njon.\n\nOn 7/5/05, Junio C Hamano <junkio@cox.net> wrote:\n> The --merge-order flag does not take parameter so there is no\n> point doing strncmp with the length.\n> \n> Signed-off-by: Junio C Hamano <junkio@cox.net>\n> ---\n> \n>  rev-list.c |    2 +-\n>  1 file changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/rev-list.c b/rev-list.c\n> --- a/rev-list.c\n> +++ b/rev-list.c\n> @@ -462,7 +462,7 @@ int main(int argc, char **argv)\n>                         limited = 1;\n>                         continue;\n>                 }\n> -               if (!strncmp(arg, \"--merge-order\", 13)) {\n> +               if (!strcmp(arg, \"--merge-order\")) {\n>                         merge_order = 1;\n>                         continue;\n>                 }\n> ------------------------------------------------\n> \n> \n\n\n-- \nhomepage: http://www.zeta.org.au/~jon/\nblog: http://orwelliantremors.blogspot.com/\n"}]}