{"thread":{"id":"11087","subject":"[PATCH 3/3] Use {web,instaweb,help}.browser config options.","startedAt":"2007-12-02T05:08:00Z","lastAt":"2007-12-02T05:08:00Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"61619","messageId":"20071202060800.9eff150f.chriscool@tuxfamily.org","threadId":"11087","inReplyTo":null,"subject":"[PATCH 3/3] Use {web,instaweb,help}.browser config options.","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2007-12-02T05:08:00Z","receivedAt":"2007-12-02T05:08:00Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Now \"git-instaweb\" will try to use the browser configured as\n\"web.browser\", if \"instaweb.browser\" is not set.\n\n\"git-browse-help\" will check first \"help.browser\" and then\n\"web.browser\".\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n git-browse-help.sh |    8 ++++++--\n git-instaweb.sh    |    1 +\n 2 files changed, 7 insertions(+), 2 deletions(-)\n\ndiff --git a/git-browse-help.sh b/git-browse-help.sh\nindex 11f8bfa..de52365 100755\n--- a/git-browse-help.sh\n+++ b/git-browse-help.sh\n@@ -80,9 +80,13 @@ do\n done\n \n if test -z \"$browser\"; then\n-    browser=`git config web.browser`\n+    for opt in \"help.browser\" \"web.browser\"\n+    do\n+\tbrowser=\"`git config $opt`\"\n+\ttest -z \"$browser\" || break\n+    done\n     if test -n \"$browser\" && ! valid_tool \"$browser\"; then\n-\t    echo >&2 \"git config option web.browser set to unknown browser: $browser\"\n+\t    echo >&2 \"git config option $opt set to unknown browser: $browser\"\n \t    echo >&2 \"Resetting to default...\"\n \t    unset browser\n     fi\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 8503ae4..42d8d7f 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -24,6 +24,7 @@ fqgitdir=\"$GIT_DIR\"\n local=\"`git config --bool --get instaweb.local`\"\n httpd=\"`git config --get instaweb.httpd`\"\n browser=\"`git config --get instaweb.browser`\"\n+test -z \"$browser\" && browser=\"`git config --get web.browser`\"\n port=`git config --get instaweb.port`\n module_path=\"`git config --get instaweb.modulepath`\"\n \n-- \n1.5.3.6.1993.g154f-dirty\n"}]}