{"thread":{"id":"11080","subject":"[PATCH] install-sh from automake does not like -m without delimiting space","startedAt":"2007-12-01T17:05:40Z","lastAt":"2007-12-04T01:48:55Z","messageCount":3,"participants":["Robert Schiele","Junio C Hamano","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"61588","messageId":"20071201170540.GS11347@schiele.dyndns.org","threadId":"11080","inReplyTo":null,"subject":"[PATCH] install-sh from automake does not like -m without delimiting space","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2007-12-01T17:05:40Z","receivedAt":"2007-12-01T17:05:40Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"The install-sh script as shipped with automake requires a space between\nthe -m switch and its argument.  Since this is also the regular way of\ndoing it with other install implementations this change inserts the\nmissing space in all makefiles.\n\nSigned-off-by: Robert Schiele <rschiele@gmail.com>\n---\n Documentation/Makefile |   16 ++++++++--------\n Makefile               |    4 ++--\n git-gui/Makefile       |   12 ++++++------\n templates/Makefile     |    2 +-\n 4 files changed, 17 insertions(+), 17 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex d886641..2de4b8b 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -79,16 +79,16 @@ man7: $(DOC_MAN7)\n info: git.info\n \n install: man\n-\t$(INSTALL) -d -m755 $(DESTDIR)$(man1dir)\n-\t$(INSTALL) -d -m755 $(DESTDIR)$(man5dir)\n-\t$(INSTALL) -d -m755 $(DESTDIR)$(man7dir)\n-\t$(INSTALL) -m644 $(DOC_MAN1) $(DESTDIR)$(man1dir)\n-\t$(INSTALL) -m644 $(DOC_MAN5) $(DESTDIR)$(man5dir)\n-\t$(INSTALL) -m644 $(DOC_MAN7) $(DESTDIR)$(man7dir)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)\n+\t$(INSTALL) -m 644 $(DOC_MAN1) $(DESTDIR)$(man1dir)\n+\t$(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir)\n+\t$(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)\n \n install-info: info\n-\t$(INSTALL) -d -m755 $(DESTDIR)$(infodir)\n-\t$(INSTALL) -m644 git.info $(DESTDIR)$(infodir)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(infodir)\n+\t$(INSTALL) -m 644 git.info $(DESTDIR)$(infodir)\n \tif test -r $(DESTDIR)$(infodir)/dir; then \\\n \t  $(INSTALL_INFO) --info-dir=$(DESTDIR)$(infodir) git.info ;\\\n \telse \\\ndiff --git a/Makefile b/Makefile\nindex e869b85..7d23aec 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1024,8 +1024,8 @@ remove-dashes:\n ### Installation rules\n \n install: all\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(bindir_SQ)'\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'\n+\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n \t$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n \t$(INSTALL) git$X '$(DESTDIR_SQ)$(bindir_SQ)'\n \t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex e860319..4f8b7c8 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -43,11 +43,11 @@ endif\n RM_RF     ?= rm -rf\n RMDIR     ?= rmdir\n \n-INSTALL_D0 = $(INSTALL) -d -m755 # space is required here\n+INSTALL_D0 = $(INSTALL) -d -m 755 # space is required here\n INSTALL_D1 =\n-INSTALL_R0 = $(INSTALL) -m644 # space is required here\n+INSTALL_R0 = $(INSTALL) -m 644 # space is required here\n INSTALL_R1 =\n-INSTALL_X0 = $(INSTALL) -m755 # space is required here\n+INSTALL_X0 = $(INSTALL) -m 755 # space is required here\n INSTALL_X1 =\n INSTALL_A0 = find # space is required here\n INSTALL_A1 = | cpio -pud\n@@ -71,11 +71,11 @@ ifndef V\n \tQUIET_2DEVNULL = 2>/dev/null\n \n \tINSTALL_D0 = dir=\n-\tINSTALL_D1 = && echo ' ' DEST $$dir && $(INSTALL) -d -m755 \"$$dir\"\n+\tINSTALL_D1 = && echo ' ' DEST $$dir && $(INSTALL) -d -m 755 \"$$dir\"\n \tINSTALL_R0 = src=\n-\tINSTALL_R1 = && echo '   ' INSTALL 644 `basename $$src` && $(INSTALL) -m644 $$src\n+\tINSTALL_R1 = && echo '   ' INSTALL 644 `basename $$src` && $(INSTALL) -m 644 $$src\n \tINSTALL_X0 = src=\n-\tINSTALL_X1 = && echo '   ' INSTALL 755 `basename $$src` && $(INSTALL) -m755 $$src\n+\tINSTALL_X1 = && echo '   ' INSTALL 755 `basename $$src` && $(INSTALL) -m 755 $$src\n \tINSTALL_A0 = src=\n \tINSTALL_A1 = && echo '   ' INSTALL '   ' `basename \"$$src\"` && find \"$$src\" | cpio -pud\n \ndiff --git a/templates/Makefile b/templates/Makefile\nindex 6f4dbd3..ebd3a62 100644\n--- a/templates/Makefile\n+++ b/templates/Makefile\n@@ -46,6 +46,6 @@ clean:\n \t$(RM) -r blt boilerplates.made\n \n install: all\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(template_dir_SQ)'\n+\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_dir_SQ)'\n \t(cd blt && $(TAR) cf - .) | \\\n \t(cd '$(DESTDIR_SQ)$(template_dir_SQ)' && $(TAR) xf -)\n-- \n1.5.2.4\n"},{"id":"61846","messageId":"7v1wa3e0h9.fsf@gitster.siamese.dyndns.org","threadId":"11080","inReplyTo":"20071201170540.GS11347@schiele.dyndns.org","subject":"Re: [PATCH] install-sh from automake does not like -m without delimiting space","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-04T01:02:10Z","receivedAt":"2007-12-04T01:02:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert Schiele <rschiele@gmail.com> writes:\n\n> The install-sh script as shipped with automake requires a space between\n> the -m switch and its argument.  Since this is also the regular way of\n> doing it with other install implementations this change inserts the\n> missing space in all makefiles.\n\nI do not think this is risky, so I'll take it but please yell if it\nbreaks some existing setups.\n\nI'll ask Shawn to do that part separately.\n\nThanks.\n"},{"id":"61850","messageId":"20071204014855.GU14735@spearce.org","threadId":"11080","inReplyTo":"7v1wa3e0h9.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] install-sh from automake does not like -m without delimiting space","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-12-04T01:48:55Z","receivedAt":"2007-12-04T01:48:55Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> Robert Schiele <rschiele@gmail.com> writes:\n> > The install-sh script as shipped with automake requires a space between\n> > the -m switch and its argument.  Since this is also the regular way of\n> > doing it with other install implementations this change inserts the\n> > missing space in all makefiles.\n...\n> I'll ask Shawn to do that part separately.\n\nThe git-gui portion is already in my master branch.  See the\n\"What's in git-gui.git\" I sent out last evening.\n\n-- \nShawn.\n"}]}