{"thread":{"id":"1105","subject":"[PATCH] Better error message from git-ssh-push","startedAt":"2005-07-04T20:12:05Z","lastAt":"2005-07-04T20:12:05Z","messageCount":1,"participants":["Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"5640","messageId":"Pine.LNX.4.21.0507041609550.30848-100000@iabervon.org","threadId":"1105","inReplyTo":null,"subject":"[PATCH] Better error message from git-ssh-push","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2005-07-04T20:12:05Z","receivedAt":"2005-07-04T20:12:05Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"If git-ssh-push can't interpret the commit-id, there are various possible\nissues. Just giving the usage message makes it hard to identify what could\nbe wrong.\n\nSigned-off-by: Daniel Barkalow <barkalow@iabervon.org>\n\n---\ncommit 7a274ce1f93e6092dcf226d546a58d2d6df9d13c\ntree 1f045fa8aa017cabbac613cf8c1ea2bd63ccc46c\nparent 8934c88118c900fe38abbf60f893ee9ef4e83b3c\nauthor Daniel Barkalow <barkalow@iabervon.org> 1120507167 -0400\ncommitter Daniel Barkalow <barkalow@silva-tulga.(none)> 1120507167 -0400\n\nIndex: ssh-push.c\n===================================================================\n--- 62a74516551505e5fd2b5c2fd14486f3ac8a400e/ssh-push.c  (mode:100644 sha1:10390948efacfa06f4f6fc6b2f3631cec6fcb876)\n+++ 1f045fa8aa017cabbac613cf8c1ea2bd63ccc46c/ssh-push.c  (mode:100644 sha1:6b1406b527ba6ede8602a04ab031003edb7da2b0)\n@@ -257,8 +257,12 @@\n \t\tusage(ssh_push_usage);\n \tcommit_id = argv[arg];\n \turl = argv[arg + 1];\n-\tif (get_sha1(commit_id, sha1))\n-\t\tusage(ssh_push_usage);\n+\tif (get_sha1(commit_id, sha1)) {\n+\t\tfprintf(stderr, \n+\t\t\t\"Unable to interpret %s as something to push.\\n\",\n+\t\t\tcommit_id);\n+\t\treturn 1;\n+\t}\n \tmemcpy(hex, sha1_to_hex(sha1), sizeof(hex));\n \targv[arg] = hex;\n \n"}]}