{"thread":{"id":"11011","subject":"[BUGLET] Makefile uses $(SCRIPT_PERL) but Documentation/Makefile uses \"perl\"","startedAt":"2007-11-25T20:39:49Z","lastAt":"2007-12-01T02:36:34Z","messageCount":2,"participants":["Randal L. Schwartz","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"60853","messageId":"863auuoy96.fsf@blue.stonehenge.com","threadId":"11011","inReplyTo":null,"subject":"[BUGLET] Makefile uses $(SCRIPT_PERL) but Documentation/Makefile uses \"perl\"","fromName":"Randal L. Schwartz","fromEmail":"merlyn@stonehenge.com","sentAt":"2007-11-25T20:39:49Z","receivedAt":"2007-11-25T20:39:49Z","isPatch":false,"sender":{"key":"merlyn@stonehenge.com","avatar":"https://gravatar.com/avatar/dc528d210743ff0333e6213f9ee7b33b23f1b7bc1f3c5a8c2d819074ecd7ab19?d=mp&s=160"},"body":"\nOn my system, that means the two Makefiles actually use two different\nPerl installations.  It'd be best if someone who is smarter at Makefiles\nthan I am would make them work the same.  Thanks.\n\n-- \nRandal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\nPerl/Unix/security consulting, Technical writing, Comedy, etc. etc.\nSee PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!\n"},{"id":"61543","messageId":"7vfxyn9m4t.fsf@gitster.siamese.dyndns.org","threadId":"11011","inReplyTo":"863auuoy96.fsf@blue.stonehenge.com","subject":"[PATCH] Run the specified perl in Documentation/","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-01T02:36:34Z","receivedAt":"2007-12-01T02:36:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Makefile uses $(PERL_PATH) but Documentation/Makefile uses \"perl\"; that\nmeans the two Makefiles can use two different Perl installations.\n\nTeach Documentation/Makefile to use PERL_PATH that is exported from the\ntoplevel Makefile, and give a sane fallback for people who run \"make\"\nfrom Documentation directory.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * Haven't tested this at all; please Ack or report breakage.\n\n Documentation/Makefile |    9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex d886641..8b19130 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -45,6 +45,9 @@ infodir?=$(prefix)/share/info\n MAKEINFO=makeinfo\n INSTALL_INFO=install-info\n DOCBOOK2X_TEXI=docbook2x-texi\n+ifndef PERL_PATH\n+\tPERL_PATH = /usr/bin/perl\n+endif\n \n -include ../config.mak.autogen\n -include ../config.mak\n@@ -105,7 +108,7 @@ install-info: info\n #\n doc.dep : $(wildcard *.txt) build-docdep.perl\n \t$(RM) $@+ $@\n-\tperl ./build-docdep.perl >$@+\n+\t$(PERL_PATH) ./build-docdep.perl >$@+\n \tmv $@+ $@\n \n -include doc.dep\n@@ -124,7 +127,7 @@ $(cmds_txt): cmd-list.made\n \n cmd-list.made: cmd-list.perl $(MAN1_TXT)\n \t$(RM) $@\n-\tperl ./cmd-list.perl\n+\t$(PERL_PATH) ./cmd-list.perl\n \tdate >$@\n \n git.7 git.html: git.txt\n@@ -161,7 +164,7 @@ user-manual.html: user-manual.xml\n git.info: user-manual.xml\n \t$(RM) $@ $*.texi $*.texi+\n \t$(DOCBOOK2X_TEXI) user-manual.xml --to-stdout >$*.texi+\n-\tperl fix-texi.perl <$*.texi+ >$*.texi\n+\t$(PERL_PATH) fix-texi.perl <$*.texi+ >$*.texi\n \t$(MAKEINFO) --no-split $*.texi\n \t$(RM) $*.texi $*.texi+\n \n"}]}