{"thread":{"id":"1100","subject":"[PATCH] Warning in apply.c","startedAt":"2005-07-04T02:50:00Z","lastAt":"2005-07-04T02:50:00Z","messageCount":1,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"5620","messageId":"1120445400.1265.23.camel@dv","threadId":"1100","inReplyTo":null,"subject":"[PATCH] Warning in apply.c","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-07-04T02:50:00Z","receivedAt":"2005-07-04T02:50:00Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello!\n\ngcc 4.0.0 reports one warning while compiling git on x86_64:\n\ngcc -g -O2 -Wall '-DSHA1_HEADER=<openssl/sha.h>' -o git-apply apply.c libgit.a -lz -lcrypto\napply.c: In function 'show_rename_copy':\napply.c:1147: warning: field precision should have type 'int', but argument 3 has type 'long int'\n\nThe fix is to cast pointer difference to int.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/apply.c b/apply.c\n--- a/apply.c\n+++ b/apply.c\n@@ -1143,7 +1143,7 @@ static void show_rename_copy(struct patc\n \t */\n \tif (old != p->old_name)\n \t\tprintf(\" %s %.*s{%s => %s} (%d%%)\\n\", renamecopy,\n-\t\t       old - p->old_name, p->old_name,\n+\t\t       (int)(old - p->old_name), p->old_name,\n \t\t       old, new, p->score);\n \telse\n \t\tprintf(\" %s %s => %s (%d%%)\\n\", renamecopy,\n\n\n-- \nRegards,\nPavel Roskin\n"}]}