{"thread":{"id":"10979","subject":"[PATCH] Tweak git-quiltimport to allow more flexible series format","startedAt":"2007-11-22T13:48:49Z","lastAt":"2007-11-27T16:52:20Z","messageCount":3,"participants":["Alexey Dobriyan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60687","messageId":"20071122134849.GB6240@localhost.sw.ru","threadId":"10979","inReplyTo":null,"subject":"[PATCH] Tweak git-quiltimport to allow more flexible series format","fromName":"Alexey Dobriyan","fromEmail":"adobriyan@sw.ru","sentAt":"2007-11-22T13:48:49Z","receivedAt":"2007-11-22T13:48:49Z","isPatch":true,"sender":{"key":"adobriyan@sw.ru","avatar":null},"body":"Make quiltimport also understand comments following patch name.\n\nSigned-off-by: Alexey Dobriyan <adobriyan@sw.ru>\n---\n\n git-quiltimport.sh |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--- a/git-quiltimport.sh\n+++ b/git-quiltimport.sh\n@@ -63,7 +63,7 @@ tmp_info=\"$tmp_dir/info\"\n commit=$(git rev-parse HEAD)\n \n mkdir $tmp_dir || exit 2\n-for patch_name in $(grep -v '^#' < \"$QUILT_PATCHES/series\" ); do\n+for patch_name in $(sed -e 's/#.*//' < \"$QUILT_PATCHES/series\" ); do\n \tif ! [ -f \"$QUILT_PATCHES/$patch_name\" ] ; then\n \t\techo \"$patch_name doesn't exist. Skipping.\"\n \t\tcontinue\n"},{"id":"60720","messageId":"7vsl2x26di.fsf@gitster.siamese.dyndns.org","threadId":"10979","inReplyTo":"20071122134849.GB6240@localhost.sw.ru","subject":"Re: [PATCH] Tweak git-quiltimport to allow more flexible series format","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-22T23:43:53Z","receivedAt":"2007-11-22T23:43:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexey Dobriyan <adobriyan@sw.ru> writes:\n\n> Make quiltimport also understand comments following patch name.\n>\n> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>\n> ---\n>\n>  git-quiltimport.sh |    2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> --- a/git-quiltimport.sh\n> +++ b/git-quiltimport.sh\n> @@ -63,7 +63,7 @@ tmp_info=\"$tmp_dir/info\"\n>  commit=$(git rev-parse HEAD)\n>  \n>  mkdir $tmp_dir || exit 2\n> -for patch_name in $(grep -v '^#' < \"$QUILT_PATCHES/series\" ); do\n> +for patch_name in $(sed -e 's/#.*//' < \"$QUILT_PATCHES/series\" ); do\n>  \tif ! [ -f \"$QUILT_PATCHES/$patch_name\" ] ; then\n>  \t\techo \"$patch_name doesn't exist. Skipping.\"\n>  \t\tcontinue\n\nIs this consistent with the way quilt groks the series file?\n\nIOW, does quilt forbid patchfile whose name contains a hash, and\nanything after a hash on the line is taken as comment?\n\nCan a line in a quilt series file name more than one patchfile?\nIf so, are they whitespace separated?\n"},{"id":"61102","messageId":"20071127165220.GA6220@localhost.sw.ru","threadId":"10979","inReplyTo":"7vsl2x26di.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Tweak git-quiltimport to allow more flexible series format","fromName":"Alexey Dobriyan","fromEmail":"adobriyan@sw.ru","sentAt":"2007-11-27T16:52:20Z","receivedAt":"2007-11-27T16:52:20Z","isPatch":true,"sender":{"key":"adobriyan@sw.ru","avatar":null},"body":"On Thu, Nov 22, 2007 at 03:43:53PM -0800, Junio C Hamano wrote:\n> Alexey Dobriyan <adobriyan@sw.ru> writes:\n> \n> > Make quiltimport also understand comments following patch name.\n> >\n> > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>\n> > ---\n> >\n> >  git-quiltimport.sh |    2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > --- a/git-quiltimport.sh\n> > +++ b/git-quiltimport.sh\n> > @@ -63,7 +63,7 @@ tmp_info=\"$tmp_dir/info\"\n> >  commit=$(git rev-parse HEAD)\n> >  \n> >  mkdir $tmp_dir || exit 2\n> > -for patch_name in $(grep -v '^#' < \"$QUILT_PATCHES/series\" ); do\n> > +for patch_name in $(sed -e 's/#.*//' < \"$QUILT_PATCHES/series\" ); do\n> >  \tif ! [ -f \"$QUILT_PATCHES/$patch_name\" ] ; then\n> >  \t\techo \"$patch_name doesn't exist. Skipping.\"\n> >  \t\tcontinue\n> \n> Is this consistent with the way quilt groks the series file?\n> \n> IOW, does quilt forbid patchfile whose name contains a hash, and\n> anything after a hash on the line is taken as comment?\n\nIt looks like hash inside a patch name is legal.\n \n> Can a line in a quilt series file name more than one patchfile?\n\nNo. Which means we can probably do sed -e 's/^#//' -e 's/[ \\t]#.*//'\n... let me experiment bit more.\n\n> If so, are they whitespace separated?\n"}]}