{"thread":{"id":"10974","subject":"[PATCH] Fix \"quote\" misconversion for rewrite diff output.","startedAt":"2007-11-22T08:36:38Z","lastAt":"2007-11-22T08:36:38Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60618","messageId":"7v4pfe8ynd.fsf@gitster.siamese.dyndns.org","threadId":"10974","inReplyTo":null,"subject":"[PATCH] Fix \"quote\" misconversion for rewrite diff output.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-22T08:36:38Z","receivedAt":"2007-11-22T08:36:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"663af3422a648e87945e4d8c0cc3e13671f2bbde (Full rework of\nquote_c_style and write_name_quoted.) mistakenly used puts()\nwhen writing out a fixed string when it did not want to add a\nterminating LF.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n diff.c                  |    2 +-\n t/t4022-diff-rewrite.sh |   26 ++++++++++++++++++++++++++\n 2 files changed, 27 insertions(+), 1 deletions(-)\n create mode 100755 t/t4022-diff-rewrite.sh\n\ndiff --git a/diff.c b/diff.c\nindex b08d28a..6b54959 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -2716,7 +2716,7 @@ static void diff_summary(struct diff_filepair *p)\n \t\tbreak;\n \tdefault:\n \t\tif (p->score) {\n-\t\t\tputs(\" rewrite \");\n+\t\t\tfputs(\" rewrite \", stdout);\n \t\t\twrite_name_quoted(p->two->path, stdout, ' ');\n \t\t\tprintf(\"(%d%%)\\n\", similarity_index(p));\n \t\t}\ndiff --git a/t/t4022-diff-rewrite.sh b/t/t4022-diff-rewrite.sh\nnew file mode 100755\nindex 0000000..6de4acb\n--- /dev/null\n+++ b/t/t4022-diff-rewrite.sh\n@@ -0,0 +1,26 @@\n+#!/bin/sh\n+\n+test_description='rewrite diff'\n+\n+. ./test-lib.sh\n+\n+test_expect_success setup '\n+\n+\tcat ../../COPYING >test &&\n+\tgit add test &&\n+\ttr 'a-zA-Z' 'n-za-mN-ZA-M' <../../COPYING >test\n+\n+'\n+\n+test_expect_success 'detect rewrite' '\n+\n+\tactual=$(git diff-files -B --summary test) &&\n+\texpr \"$actual\" : \" rewrite test ([0-9]*%)$\" || {\n+\t\techo \"Eh? <<$actual>>\"\n+\t\tfalse\n+\t}\n+\n+'\n+\n+test_done\n+\n-- \n1.5.3.6.1929.g388a\n"}]}