{"thread":{"id":"10971","subject":"[PATCH] Print the real filename whose opening failed.","startedAt":"2007-11-22T01:00:22Z","lastAt":"2007-11-26T03:15:36Z","messageCount":3,"participants":["André Goddard Rosa","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60590","messageId":"b8bf37780711211700g48a738b1xa147d1e7000ee76@mail.gmail.com","threadId":"10971","inReplyTo":null,"subject":"[PATCH] Print the real filename whose opening failed.","fromName":"André Goddard Rosa","fromEmail":"andre.goddard@gmail.com","sentAt":"2007-11-22T01:00:22Z","receivedAt":"2007-11-22T01:00:22Z","isPatch":true,"sender":{"key":"andre.goddard@gmail.com","avatar":null},"body":"Hi, all!\n\n    Please cc: me as I'm not subscribed. I'm sending the patch inline\nonly for review, probably it is mangled.\n    Please use the attached patch if you agree with it. Sorry about\nsending it attached.\n\nFrom 88b7bd873b97bd81e854827c9cd8f3c306d3c3af Mon Sep 17 00:00:00 2001\nFrom: =?utf-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>\nDate: Wed, 21 Nov 2007 18:59:14 -0200\nSubject: [PATCH] Print the real filename whose opening failed.\nMIME-Version: 1.0\nContent-Type: text/plain; charset=utf-8\nContent-Transfer-Encoding: 8bit\n\nSigned-off-by: André Goddard Rosa <andre.goddard@gmail.com>\n---\n http-push.c   |    4 ++--\n http-walker.c |    4 ++--\n server-info.c |    2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 9314621..e675ca6 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -433,7 +433,7 @@ static void start_fetch_packed(struct\ntransfer_request *request)\n \tpackfile = fopen(request->tmpfile, \"a\");\n \tif (!packfile) {\n \t\tfprintf(stderr, \"Unable to open local file %s for pack\",\n-\t\t\tfilename);\n+\t\t\trequest->tmpfile);\n \t\tremote->can_update_info_refs = 0;\n \t\tfree(url);\n \t\treturn;\n@@ -941,7 +941,7 @@ static int fetch_index(unsigned char *sha1)\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n\n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/http-walker.c b/http-walker.c\nindex 444aebf..a3fb596 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -405,7 +405,7 @@ static int fetch_index(struct walker *walker,\nstruct alt_base *repo, unsigned ch\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n\n \tslot = get_active_slot();\n \tslot->results = &results;\n@@ -770,7 +770,7 @@ static int fetch_pack(struct walker *walker,\nstruct alt_base *repo, unsigned cha\n \tpackfile = fopen(tmpfile, \"a\");\n \tif (!packfile)\n \t\treturn error(\"Unable to open local file %s for pack\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n\n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/server-info.c b/server-info.c\nindex 0d1312c..a051e49 100644\n--- a/server-info.c\n+++ b/server-info.c\n@@ -35,7 +35,7 @@ static int update_info_refs(int force)\n \tsafe_create_leading_directories(path0);\n \tinfo_ref_fp = fopen(path1, \"w\");\n \tif (!info_ref_fp)\n-\t\treturn error(\"unable to update %s\", path0);\n+\t\treturn error(\"unable to update %s\", path1);\n \tfor_each_ref(add_info_ref, NULL);\n \tfclose(info_ref_fp);\n \tadjust_shared_perm(path1);\n-- \n1.5.3.6.861.gd794-dirty\n\n\nFrom 88b7bd873b97bd81e854827c9cd8f3c306d3c3af Mon Sep 17 00:00:00 2001\nFrom: =?utf-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>\nDate: Wed, 21 Nov 2007 18:59:14 -0200\nSubject: [PATCH] Print the real filename whose opening failed.\nMIME-Version: 1.0\nContent-Type: text/plain; charset=utf-8\nContent-Transfer-Encoding: 8bit\n\nSigned-off-by: André Goddard Rosa <andre.goddard@gmail.com>\n---\n http-push.c   |    4 ++--\n http-walker.c |    4 ++--\n server-info.c |    2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 9314621..e675ca6 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -433,7 +433,7 @@ static void start_fetch_packed(struct transfer_request *request)\n \tpackfile = fopen(request->tmpfile, \"a\");\n \tif (!packfile) {\n \t\tfprintf(stderr, \"Unable to open local file %s for pack\",\n-\t\t\tfilename);\n+\t\t\trequest->tmpfile);\n \t\tremote->can_update_info_refs = 0;\n \t\tfree(url);\n \t\treturn;\n@@ -941,7 +941,7 @@ static int fetch_index(unsigned char *sha1)\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/http-walker.c b/http-walker.c\nindex 444aebf..a3fb596 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -405,7 +405,7 @@ static int fetch_index(struct walker *walker, struct alt_base *repo, unsigned ch\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\n@@ -770,7 +770,7 @@ static int fetch_pack(struct walker *walker, struct alt_base *repo, unsigned cha\n \tpackfile = fopen(tmpfile, \"a\");\n \tif (!packfile)\n \t\treturn error(\"Unable to open local file %s for pack\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/server-info.c b/server-info.c\nindex 0d1312c..a051e49 100644\n--- a/server-info.c\n+++ b/server-info.c\n@@ -35,7 +35,7 @@ static int update_info_refs(int force)\n \tsafe_create_leading_directories(path0);\n \tinfo_ref_fp = fopen(path1, \"w\");\n \tif (!info_ref_fp)\n-\t\treturn error(\"unable to update %s\", path0);\n+\t\treturn error(\"unable to update %s\", path1);\n \tfor_each_ref(add_info_ref, NULL);\n \tfclose(info_ref_fp);\n \tadjust_shared_perm(path1);\n-- \n1.5.3.6.861.gd794-dirty\n\n"},{"id":"60871","messageId":"b8bf37780711251338p500797e7h3633dd3189311101@mail.gmail.com","threadId":"10971","inReplyTo":"b8bf37780711211700g48a738b1xa147d1e7000ee76@mail.gmail.com","subject":"[Resend Trivial PATCH] Print the real filename whose opening failed.","fromName":"André Goddard Rosa","fromEmail":"andre.goddard@gmail.com","sentAt":"2007-11-25T21:38:09Z","receivedAt":"2007-11-25T21:38:09Z","isPatch":true,"sender":{"key":"andre.goddard@gmail.com","avatar":null},"body":"Hi, all!\n\n    Print the filename whose opening failed.\n\nFrom 88b7bd873b97bd81e854827c9cd8f3c306d3c3af Mon Sep 17 00:00:00 2001\nFrom: =?utf-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>\nDate: Wed, 21 Nov 2007 18:59:14 -0200\nSubject: [PATCH] Print the real filename whose opening failed.\nMIME-Version: 1.0\nContent-Type: text/plain; charset=utf-8\nContent-Transfer-Encoding: 8bit\n\nSigned-off-by: André Goddard Rosa <andre.goddard@gmail.com>\n---\n http-push.c   |    4 ++--\n http-walker.c |    4 ++--\n server-info.c |    2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 9314621..e675ca6 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -433,7 +433,7 @@ static void start_fetch_packed(struct\ntransfer_request *request)\n        packfile = fopen(request->tmpfile, \"a\");\n        if (!packfile) {\n                fprintf(stderr, \"Unable to open local file %s for pack\",\n-                       filename);\n+                       request->tmpfile);\n                remote->can_update_info_refs = 0;\n                free(url);\n                return;\n@@ -941,7 +941,7 @@ static int fetch_index(unsigned char *sha1)\n        indexfile = fopen(tmpfile, \"a\");\n        if (!indexfile)\n                return error(\"Unable to open local file %s for pack index\",\n-                            filename);\n+                            tmpfile);\n\n        slot = get_active_slot();\n        slot->results = &results;\ndiff --git a/http-walker.c b/http-walker.c\nindex 444aebf..a3fb596 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -405,7 +405,7 @@ static int fetch_index(struct walker *walker,\nstruct alt_base *repo, unsigned ch\n        indexfile = fopen(tmpfile, \"a\");\n        if (!indexfile)\n                return error(\"Unable to open local file %s for pack index\",\n-                            filename);\n+                            tmpfile);\n\n        slot = get_active_slot();\n        slot->results = &results;\n@@ -770,7 +770,7 @@ static int fetch_pack(struct walker *walker,\nstruct alt_base *repo, unsigned cha\n        packfile = fopen(tmpfile, \"a\");\n        if (!packfile)\n                return error(\"Unable to open local file %s for pack\",\n-                            filename);\n+                            tmpfile);\n\n        slot = get_active_slot();\n        slot->results = &results;\ndiff --git a/server-info.c b/server-info.c\nindex 0d1312c..a051e49 100644\n--- a/server-info.c\n+++ b/server-info.c\n@@ -35,7 +35,7 @@ static int update_info_refs(int force)\n        safe_create_leading_directories(path0);\n        info_ref_fp = fopen(path1, \"w\");\n        if (!info_ref_fp)\n-               return error(\"unable to update %s\", path0);\n+               return error(\"unable to update %s\", path1);\n        for_each_ref(add_info_ref, NULL);\n        fclose(info_ref_fp);\n        adjust_shared_perm(path1);\n--\n1.5.3.6.861.gd794-dirty\n\n\n\n-- \n[]s,\nAndré Goddard\n\n\nFrom 88b7bd873b97bd81e854827c9cd8f3c306d3c3af Mon Sep 17 00:00:00 2001\nFrom: =?utf-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>\nDate: Wed, 21 Nov 2007 18:59:14 -0200\nSubject: [PATCH] Print the real filename whose opening failed.\nMIME-Version: 1.0\nContent-Type: text/plain; charset=utf-8\nContent-Transfer-Encoding: 8bit\n\nSigned-off-by: André Goddard Rosa <andre.goddard@gmail.com>\n---\n http-push.c   |    4 ++--\n http-walker.c |    4 ++--\n server-info.c |    2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 9314621..e675ca6 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -433,7 +433,7 @@ static void start_fetch_packed(struct transfer_request *request)\n \tpackfile = fopen(request->tmpfile, \"a\");\n \tif (!packfile) {\n \t\tfprintf(stderr, \"Unable to open local file %s for pack\",\n-\t\t\tfilename);\n+\t\t\trequest->tmpfile);\n \t\tremote->can_update_info_refs = 0;\n \t\tfree(url);\n \t\treturn;\n@@ -941,7 +941,7 @@ static int fetch_index(unsigned char *sha1)\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/http-walker.c b/http-walker.c\nindex 444aebf..a3fb596 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -405,7 +405,7 @@ static int fetch_index(struct walker *walker, struct alt_base *repo, unsigned ch\n \tindexfile = fopen(tmpfile, \"a\");\n \tif (!indexfile)\n \t\treturn error(\"Unable to open local file %s for pack index\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\n@@ -770,7 +770,7 @@ static int fetch_pack(struct walker *walker, struct alt_base *repo, unsigned cha\n \tpackfile = fopen(tmpfile, \"a\");\n \tif (!packfile)\n \t\treturn error(\"Unable to open local file %s for pack\",\n-\t\t\t     filename);\n+\t\t\t     tmpfile);\n \n \tslot = get_active_slot();\n \tslot->results = &results;\ndiff --git a/server-info.c b/server-info.c\nindex 0d1312c..a051e49 100644\n--- a/server-info.c\n+++ b/server-info.c\n@@ -35,7 +35,7 @@ static int update_info_refs(int force)\n \tsafe_create_leading_directories(path0);\n \tinfo_ref_fp = fopen(path1, \"w\");\n \tif (!info_ref_fp)\n-\t\treturn error(\"unable to update %s\", path0);\n+\t\treturn error(\"unable to update %s\", path1);\n \tfor_each_ref(add_info_ref, NULL);\n \tfclose(info_ref_fp);\n \tadjust_shared_perm(path1);\n-- \n1.5.3.6.861.gd794-dirty\n\n"},{"id":"60899","messageId":"7v3autitnr.fsf@gitster.siamese.dyndns.org","threadId":"10971","inReplyTo":"b8bf37780711251338p500797e7h3633dd3189311101@mail.gmail.com","subject":"Re: [Resend Trivial PATCH] Print the real filename whose opening failed.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-26T03:15:36Z","receivedAt":"2007-11-26T03:15:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, will apply.\n"}]}