{"thread":{"id":"1094","subject":"[PATCH] git: fix gcc4 warnings","startedAt":"2005-07-03T20:32:33Z","lastAt":"2005-07-03T20:32:33Z","messageCount":1,"participants":["Mika Kukkonen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"5607","messageId":"20050703203233.GA19220@miku.homelinux.net","threadId":"1094","inReplyTo":null,"subject":"[PATCH] git: fix gcc4 warnings","fromName":"Mika Kukkonen","fromEmail":"mikukkon@miku.homelinux.net","sentAt":"2005-07-03T20:32:33Z","receivedAt":"2005-07-03T20:32:33Z","isPatch":true,"sender":{"key":"mikukkon@miku.homelinux.net","avatar":null},"body":"Here is a few trivial fixes to git about things that gcc4 complains about.\n\nSigned-off-by: Mika Kukkonen <mikukkon@iki.fi>\n\ndiffstat:\n git/send-pack.c |    2 +-\n git/sha1_file.c |    4 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)\n\nIndex: git/send-pack.c\n===================================================================\n--- git.orig/send-pack.c\n+++ git/send-pack.c\n@@ -93,7 +93,7 @@ static void rev_list(int fd, struct ref \n \texec_rev_list(refs);\n }\n \n-static int pack_objects(int fd, struct ref *refs)\n+static void pack_objects(int fd, struct ref *refs)\n {\n \tpid_t rev_list_pid;\n \nIndex: git/sha1_file.c\n===================================================================\n--- git.orig/sha1_file.c\n+++ git/sha1_file.c\n@@ -384,8 +384,8 @@ struct packed_git *add_packed_git(char *\n {\n \tstruct stat st;\n \tstruct packed_git *p;\n-\tunsigned long idx_size;\n-\tvoid *idx_map;\n+\tunsigned long idx_size = 0;\n+\tvoid *idx_map = NULL;\n\n \tif (check_packed_git_idx(path, &idx_size, &idx_map))\n \t\treturn NULL;\n@@ -857,7 +857,7 @@ static void *unpack_non_delta_entry(unsi\n {\n \tint st;\n \tz_stream stream;\n-\tchar *buffer;\n+\tunsigned char *buffer;\n \n \tbuffer = xmalloc(size + 1);\n \tbuffer[size] = 0;\n@@ -949,7 +949,7 @@ int nth_packed_object_sha1(const struct \n int find_pack_entry_one(const unsigned char *sha1,\n \t\t\tstruct pack_entry *e, struct packed_git *p)\n {\n-\tint *level1_ofs = p->index_base;\n+\tunsigned int *level1_ofs = p->index_base;\n \tint hi = ntohl(level1_ofs[*sha1]);\n \tint lo = ((*sha1 == 0x0) ? 0 : ntohl(level1_ofs[*sha1 - 1]));\n \tvoid *index = p->index_base + 256;\n"}]}