{"thread":{"id":"10932","subject":"[PATCH] config: correct and clarify core.*compression documentation","startedAt":"2007-11-19T15:28:54Z","lastAt":"2007-11-19T17:30:26Z","messageCount":8,"participants":["Brian Downing","Nicolas Pitre"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60317","messageId":"20071119152853.GH6212@lavos.net","threadId":"10932","inReplyTo":null,"subject":"[PATCH] config: correct and clarify core.*compression documentation","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-11-19T15:28:54Z","receivedAt":"2007-11-19T15:28:54Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"* core.loosecompression stated that the default was \"0 (best speed)\",\n when in fact 0 is \"no compression\", and the default is Z_BEST_SPEED,\n which is 1.\n\n* Explain that the default of core.compression is -1, zlib default, and\n add a quote from zlib.h explaining what that actually means.\n---\n applies to 'maint'; unfortunately I just noticed 1.5.3.6 went out.\n\n Documentation/config.txt | 5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 7ee97df..d62a72b 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -226,13 +226,16 @@ core.compression::\n \tAn integer -1..9, indicating a default compression level.\n \t-1 is the zlib default. 0 means no compression,\n \tand 1..9 are various speed/size tradeoffs, 9 being slowest.\n+\tIf not set, defaults to -1 (zlib default), which is \"a default\n+\tcompromise between speed and compression (currently equivalent\n+\tto level 6).\"\n \n core.loosecompression::\n \tAn integer -1..9, indicating the compression level for objects that\n \tare not in a pack file. -1 is the zlib default. 0 means no\n \tcompression, and 1..9 are various speed/size tradeoffs, 9 being\n \tslowest. If not set, defaults to core.compression. If that is\n-\tnot set, defaults to 0 (best speed).\n+\tnot set, defaults to 1 (best speed).\n \n core.packedGitWindowSize::\n \tNumber of bytes of a pack file to map into memory in a\n-- \n1.5.3.5.1824.g5f389\n"},{"id":"60320","messageId":"alpine.LFD.0.99999.0711191049440.19105@xanadu.home","threadId":"10932","inReplyTo":"20071119152853.GH6212@lavos.net","subject":"Re: [PATCH] config: correct and clarify core.*compression documentation","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-11-19T15:51:31Z","receivedAt":"2007-11-19T15:51:31Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Mon, 19 Nov 2007, Brian Downing wrote:\n\n> * core.loosecompression stated that the default was \"0 (best speed)\",\n> when in fact 0 is \"no compression\", and the default is Z_BEST_SPEED,\n> which is 1.\n\nRight.\n\n> * Explain that the default of core.compression is -1, zlib default, and\n> add a quote from zlib.h explaining what that actually means.\n\nNo, this is wrong. core.compression has no default. It is meaningful \nonly when an explicit value is configured.\n\n\nNicolas\n"},{"id":"60323","messageId":"20071119162307.GI6212@lavos.net","threadId":"10932","inReplyTo":"alpine.LFD.0.99999.0711191049440.19105@xanadu.home","subject":"Re: [PATCH] config: correct and clarify core.*compression documentation","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-11-19T16:23:08Z","receivedAt":"2007-11-19T16:23:08Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:\n> > * Explain that the default of core.compression is -1, zlib default, and\n> > add a quote from zlib.h explaining what that actually means.\n> \n> No, this is wrong. core.compression has no default. It is meaningful \n> only when an explicit value is configured.\n\nWould you prefer this?\n\n If not set, packs will be compressed to the zlib default level,\n which is \"a default compromise between speed and compression\n (currently equivalent to level 6).\"\n\nI'm trying to make it reassuring as to the fact that, \"yes, packs are\ncompressed plenty, you really don't need to mess with this unless you\nwant to.\" As it stands I could see the potential confusion that no\n(or poor) compression will occur in packs unless this is set.\n\n-bcd\n"},{"id":"60325","messageId":"alpine.LFD.0.99999.0711191139240.19105@xanadu.home","threadId":"10932","inReplyTo":"20071119162307.GI6212@lavos.net","subject":"Re: [PATCH] config: correct and clarify core.*compression documentation","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-11-19T16:43:56Z","receivedAt":"2007-11-19T16:43:56Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Mon, 19 Nov 2007, Brian Downing wrote:\n\n> On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:\n> > > * Explain that the default of core.compression is -1, zlib default, and\n> > > add a quote from zlib.h explaining what that actually means.\n> > \n> > No, this is wrong. core.compression has no default. It is meaningful \n> > only when an explicit value is configured.\n> \n> Would you prefer this?\n> \n> If not set, packs will be compressed to the zlib default level,\n> which is \"a default compromise between speed and compression\n> (currently equivalent to level 6).\"\n\nThis is still rather incorrect. If you want to be thorough, you should \nsay that this setting provides a global default for pack.compression and \ncore.loosecompression when those settings are not set. Otherwise \npack.compression and core.loosecompression have a default of their own \nwhen neither is set.\n\n\nNicolas\n"},{"id":"60327","messageId":"20071119164619.GJ6212@lavos.net","threadId":"10932","inReplyTo":"alpine.LFD.0.99999.0711191139240.19105@xanadu.home","subject":"Re: [PATCH] config: correct and clarify core.*compression documentation","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-11-19T16:46:19Z","receivedAt":"2007-11-19T16:46:19Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"On Mon, Nov 19, 2007 at 11:43:56AM -0500, Nicolas Pitre wrote:\n> On Mon, 19 Nov 2007, Brian Downing wrote:\n> > On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:\n> > > > * Explain that the default of core.compression is -1, zlib default, and\n> > > > add a quote from zlib.h explaining what that actually means.\n> > > \n> > > No, this is wrong. core.compression has no default. It is meaningful \n> > > only when an explicit value is configured.\n> > \n> > Would you prefer this?\n> > \n> > If not set, packs will be compressed to the zlib default level,\n> > which is \"a default compromise between speed and compression\n> > (currently equivalent to level 6).\"\n> \n> This is still rather incorrect. If you want to be thorough, you should \n> say that this setting provides a global default for pack.compression and \n> core.loosecompression when those settings are not set. Otherwise \n> pack.compression and core.loosecompression have a default of their own \n> when neither is set.\n\nOkay, thanks. (See, I didn't know this either! :) I'll try to work\nwith that...\n\n-bcd\n"},{"id":"60334","messageId":"1195491531-2701-1-git-send-email-bdowning@lavos.net","threadId":"10932","inReplyTo":"alpine.LFD.0.99999.0711191139240.19105@xanadu.home","subject":"[PATCH 1/2] config: correct core.loosecompression documentation","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-11-19T16:58:50Z","receivedAt":"2007-11-19T16:58:50Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"* core.loosecompression stated that the default was \"0 (best speed)\",\n when in fact 0 is \"no compression\", and the default is Z_BEST_SPEED,\n which is 1.\n\nSigned-off-by: Brian Downing \n---\n Documentation/config.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 7ee97df..9565652 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -232,7 +232,7 @@ core.loosecompression::\n \tare not in a pack file. -1 is the zlib default. 0 means no\n \tcompression, and 1..9 are various speed/size tradeoffs, 9 being\n \tslowest. If not set, defaults to core.compression. If that is\n-\tnot set, defaults to 0 (best speed).\n+\tnot set, defaults to 1 (best speed).\n \n core.packedGitWindowSize::\n \tNumber of bytes of a pack file to map into memory in a\n-- \n1.5.3.5.1824.g5f389\n"},{"id":"60335","messageId":"1195491531-2701-2-git-send-email-bdowning@lavos.net","threadId":"10932","inReplyTo":"1195491531-2701-1-git-send-email-bdowning@lavos.net","subject":"[PATCH 2/2] config: clarify compression defaults","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-11-19T16:58:51Z","receivedAt":"2007-11-19T16:58:51Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"* Clarify that core.compression provides a system-wide default to\n other compression parameters.\n\n* Explain that the default for pack.compression, -1, is \"a default\n compromise between speed and compression (currently equivalent\n to level 6)\" according to zlib.h.\n\nSigned-off-by: Brian Downing \n---\n Documentation/config.txt | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 9565652..5d1eb5d 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -226,6 +226,8 @@ core.compression::\n \tAn integer -1..9, indicating a default compression level.\n \t-1 is the zlib default. 0 means no compression,\n \tand 1..9 are various speed/size tradeoffs, 9 being slowest.\n+\tIf set, this provides a default to other compression variables, \n+\tsuch as 'core.loosecompression' and 'pack.compression'.\n \n core.loosecompression::\n \tAn integer -1..9, indicating the compression level for objects that\n@@ -622,7 +624,9 @@ pack.compression::\n \tin a pack file. -1 is the zlib default. 0 means no\n \tcompression, and 1..9 are various speed/size tradeoffs, 9 being\n \tslowest. If not set, defaults to core.compression. If that is\n-\tnot set, defaults to -1.\n+\tnot set, defaults to -1, the zlib default, which is \"a default\n+\tcompromise between speed and compression (currently equivalent \n+\tto level 6).\"\n \n pack.deltaCacheSize::\n \tThe maximum memory in bytes used for caching deltas in\n-- \n1.5.3.5.1824.g5f389\n"},{"id":"60337","messageId":"alpine.LFD.0.99999.0711191230030.19105@xanadu.home","threadId":"10932","inReplyTo":"1195491531-2701-2-git-send-email-bdowning@lavos.net","subject":"Re: [PATCH 2/2] config: clarify compression defaults","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-11-19T17:30:26Z","receivedAt":"2007-11-19T17:30:26Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Mon, 19 Nov 2007, Brian Downing wrote:\n\n> * Clarify that core.compression provides a system-wide default to\n> other compression parameters.\n> \n> * Explain that the default for pack.compression, -1, is \"a default\n> compromise between speed and compression (currently equivalent\n> to level 6)\" according to zlib.h.\n> \n> Signed-off-by: Brian Downing \n\nLooks fine to me.\n\n\nNicolas\n"}]}