{"thread":{"id":"10890","subject":"[PATCH] rehabilitate some t5302 tests on 32-bit off_t machines","startedAt":"2007-11-15T17:24:17Z","lastAt":"2007-11-15T19:39:23Z","messageCount":5,"participants":["Nicolas Pitre","Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60003","messageId":"alpine.LFD.0.9999.0711151211330.21255@xanadu.home","threadId":"10890","inReplyTo":null,"subject":"[PATCH] rehabilitate some t5302 tests on 32-bit off_t machines","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-11-15T17:24:17Z","receivedAt":"2007-11-15T17:24:17Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"Commit 8ed2fca458d085f12c3c6808ef4ddab6aa40ef14 was a bit draconian in \nskipping certain tests which should be perfectly valid even on platform \nwith a 32-bit off_t.\n\nSigned-off-by: Nicolas Pitre \n---\ndiff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh\nindex d93abc4..2a2878b 100755\n--- a/t/t5302-pack-index.sh\n+++ b/t/t5302-pack-index.sh\n@@ -129,17 +129,15 @@ test_expect_failure \\\n '[index v1] 6) newly created pack is BAD !' \\\n 'git verify-pack -v \"test-4-${pack1}.pack\"'\n \n-test \"$have_64bits\" &&\n test_expect_success \\\n '[index v2] 1) stream pack to repository' \\\n 'rm -f .git/objects/pack/* &&\n- git-index-pack --index-version=2,0x40000 --stdin < \"test-1-${pack1}.pack\" &&\n+ git-index-pack --index-version=2 --stdin < \"test-1-${pack1}.pack\" &&\n git prune-packed &&\n git count-objects | ( read nr rest && test \"$nr\" -eq 1 ) &&\n cmp \"test-1-${pack1}.pack\" \".git/objects/pack/pack-${pack1}.pack\" &&\n- cmp \"test-3-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n+ cmp \"test-2-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n \n-test \"$have_64bits\" &&\n test_expect_success \\\n '[index v2] 2) create a stealth corruption in a delta base reference' \\\n '# this test assumes a delta smaller than 16 bytes at the end of the pack\n@@ -152,17 +150,14 @@ test_expect_success \\\n \t bs=1 count=20 conv=notrunc &&\n git cat-file blob \"$delta_sha1\" > blob_4 )'\n \n-test \"$have_64bits\" &&\n test_expect_failure \\\n '[index v2] 3) corrupted delta happily returned wrong data' \\\n 'cmp blob_3 blob_4'\n \n-test \"$have_64bits\" &&\n test_expect_failure \\\n '[index v2] 4) confirm that the pack is actually corrupted' \\\n 'git fsck --full $commit'\n \n-test \"$have_64bits\" &&\n test_expect_failure \\\n '[index v2] 5) pack-objects refuses to reuse corrupted data' \\\n 'git pack-objects test-5 Commit 8ed2fca458d085f12c3c6808ef4ddab6aa40ef14 was a bit draconian in\n> skipping certain tests which should be perfectly valid even on platform\n> with a 32-bit off_t.\n>\n> Signed-off-by: Nicolas Pitre \n> ---\n> diff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh\n> index d93abc4..2a2878b 100755\n> --- a/t/t5302-pack-index.sh\n> +++ b/t/t5302-pack-index.sh\n> @@ -129,17 +129,15 @@ test_expect_failure \\\n> '[index v1] 6) newly created pack is BAD !' \\\n> 'git verify-pack -v \"test-4-${pack1}.pack\"'\n>\n> -test \"$have_64bits\" &&\n> test_expect_success \\\n> '[index v2] 1) stream pack to repository' \\\n> 'rm -f .git/objects/pack/* &&\n> - git-index-pack --index-version=2,0x40000 --stdin \n< \"test-1-${pack1}.pack\" &&\n> + git-index-pack --index-version=2 --stdin < \"test-1-${pack1}.pack\" && \ngit prune-packed &&\n> git count-objects | ( read nr rest && test \"$nr\" -eq 1 ) &&\n> cmp \"test-1-${pack1}.pack\" \".git/objects/pack/pack-${pack1}.pack\" &&\n> - cmp \"test-3-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n> + cmp \"test-2-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n\nSince you changed this test, I assume that the remaining tests that you put \nback failed only because this one did something wrong. If so, please mention \nthat in the commit message.\n\n-- Hannes\n"},{"id":"60012","messageId":"alpine.LFD.0.9999.0711151349480.21255@xanadu.home","threadId":"10890","inReplyTo":"200711151938.29617.johannes.sixt@telecom.at","subject":"Re: [PATCH] rehabilitate some t5302 tests on 32-bit off_t machines","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-11-15T18:51:47Z","receivedAt":"2007-11-15T18:51:47Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Thu, 15 Nov 2007, Johannes Sixt wrote:\n\n> On Thursday 15 November 2007 18:24, Nicolas Pitre wrote:\n> > Commit 8ed2fca458d085f12c3c6808ef4ddab6aa40ef14 was a bit draconian in\n> > skipping certain tests which should be perfectly valid even on platform\n> > with a 32-bit off_t.\n> >\n> > Signed-off-by: Nicolas Pitre \n> > ---\n> > diff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh\n> > index d93abc4..2a2878b 100755\n> > --- a/t/t5302-pack-index.sh\n> > +++ b/t/t5302-pack-index.sh\n> > @@ -129,17 +129,15 @@ test_expect_failure \\\n> > '[index v1] 6) newly created pack is BAD !' \\\n> > 'git verify-pack -v \"test-4-${pack1}.pack\"'\n> >\n> > -test \"$have_64bits\" &&\n> > test_expect_success \\\n> > '[index v2] 1) stream pack to repository' \\\n> > 'rm -f .git/objects/pack/* &&\n> > - git-index-pack --index-version=2,0x40000 --stdin \n> < \"test-1-${pack1}.pack\" &&\n> > + git-index-pack --index-version=2 --stdin < \"test-1-${pack1}.pack\" && \n> git prune-packed &&\n> > git count-objects | ( read nr rest && test \"$nr\" -eq 1 ) &&\n> > cmp \"test-1-${pack1}.pack\" \".git/objects/pack/pack-${pack1}.pack\" &&\n> > - cmp \"test-3-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n> > + cmp \"test-2-${pack1}.idx\" \".git/objects/pack/pack-${pack1}.idx\"'\n> \n> Since you changed this test, I assume that the remaining tests that you put \n> back failed only because this one did something wrong. If so, please mention \n> that in the commit message.\n\nIt did nothing wrong. It was simply relying on the product of a \nprevious test that might still be disabled.\n\n\nNicolas\n"},{"id":"60014","messageId":"7vsl3749hp.fsf@gitster.siamese.dyndns.org","threadId":"10890","inReplyTo":"alpine.LFD.0.9999.0711151349480.21255@xanadu.home","subject":"Re: [PATCH] rehabilitate some t5302 tests on 32-bit off_t machines","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-15T19:03:14Z","receivedAt":"2007-11-15T19:03:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nicolas Pitre writes:\n\n> On Thu, 15 Nov 2007, Johannes Sixt wrote:\n>\n>> Since you changed this test, I assume that the remaining\n>> tests that you put back failed only because this one did\n>> something wrong. If so, please mention that in the commit\n>> message.\n>\n> It did nothing wrong. It was simply relying on the product of\n> a previous test that might still be disabled.\n\nThanks for a fix-up and clarification. Hannes, otherwise this\npassed in your environment?\n"},{"id":"60016","messageId":"200711152039.23978.johannes.sixt@telecom.at","threadId":"10890","inReplyTo":"7vsl3749hp.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] rehabilitate some t5302 tests on 32-bit off_t machines","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2007-11-15T19:39:23Z","receivedAt":"2007-11-15T19:39:23Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Thursday 15 November 2007 20:03, Junio C Hamano wrote:\n> Nicolas Pitre writes:\n> > On Thu, 15 Nov 2007, Johannes Sixt wrote:\n> >> Since you changed this test, I assume that the remaining\n> >> tests that you put back failed only because this one did\n> >> something wrong. If so, please mention that in the commit\n> >> message.\n> >\n> > It did nothing wrong. It was simply relying on the product of\n> > a previous test that might still be disabled.\n>\n> Thanks for a fix-up and clarification. Hannes, otherwise this\n> passed in your environment?\n\nYes, it passes. Ack.\n\n-- Hannes\n"}]}