{"thread":{"id":"10875","subject":"Problem in our test setup","startedAt":"2007-11-15T06:24:48Z","lastAt":"2007-11-15T17:30:26Z","messageCount":4,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"59929","messageId":"Pine.LNX.4.64.0711150618300.4362@racer.site","threadId":"10875","inReplyTo":null,"subject":"Problem in our test setup","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-15T06:24:48Z","receivedAt":"2007-11-15T06:24:48Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nI just realised that our test setup has a serious problem.  In my \nsemi-private builtin-commit branch, there is no runstatus anymore.  Now, \nI got a new toy yesterday, and installed git on it (my fork, including \nbuiltin-commit), and all of a sudden tests were failing.\n\nThe failing tests were t3001 and t4001, because they call runstatus, and \nrunstatus is no longer there in the builtin-commit branch.\n\nSo why did I not catch this earlier?\n\nBecause my prefix is the default prefix, which is $HOME/bin, and which is \nnot turned off in the tests.  So git finds \"runstatus\", because it is \nstill installed.\n\nNow, things get worse if you install to /usr/bin/, which I do sometimes, \ntoo, because you _cannot_ remove that from the PATH.\n\nOkay, so removing a command is not all that common, but that means that we \nhave to be extra careful when we do so.\n\nCiao,\nDscho\n"},{"id":"59936","messageId":"7vzlxg6kzt.fsf@gitster.siamese.dyndns.org","threadId":"10875","inReplyTo":"Pine.LNX.4.64.0711150618300.4362@racer.site","subject":"Re: Problem in our test setup","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-15T07:11:50Z","receivedAt":"2007-11-15T07:11:50Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Because my prefix is the default prefix, which is $HOME/bin, and which is \n> not turned off in the tests.  So git finds \"runstatus\", because it is \n> still installed.\n\nYes, we have a problem.\n\nWe could solve this for commands issued in \"git foo\" form by not\nlooking for \"git-foo\" anywhere other than in git_exec_path.  The\nscripts and tests only prepend GIT_EXEC_PATH to their PATH and\nrun \"git foo\" or \"git-foo\", but if we replace all of them to the\nnon-dash form, wouldn't that solve the issue as well?\n"},{"id":"59973","messageId":"Pine.LNX.4.64.0711151237400.16728@wbgn129.biozentrum.uni-wuerzburg.de","threadId":"10875","inReplyTo":"7vzlxg6kzt.fsf@gitster.siamese.dyndns.org","subject":"Re: Problem in our test setup","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-15T11:40:30Z","receivedAt":"2007-11-15T11:40:30Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 14 Nov 2007, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> > Because my prefix is the default prefix, which is $HOME/bin, and which \n> > is not turned off in the tests.  So git finds \"runstatus\", because it \n> > is still installed.\n> \n> Yes, we have a problem.\n> \n> We could solve this for commands issued in \"git foo\" form by not looking \n> for \"git-foo\" anywhere other than in git_exec_path.  The scripts and \n> tests only prepend GIT_EXEC_PATH to their PATH and run \"git foo\" or \n> \"git-foo\", but if we replace all of them to the non-dash form, wouldn't \n> that solve the issue as well?\n\nFunnily enough, it _is_ the non-dash form that I replaced.  What happens \nis this: the git wrapper looks for a builtin named 'runstatus', does not \nfind it, then calls out for something like 'git-runstatus', which is found \nin my $HOME/bin.\n\nSorry,\nDscho\n"},{"id":"60005","messageId":"7v3av75sct.fsf@gitster.siamese.dyndns.org","threadId":"10875","inReplyTo":"Pine.LNX.4.64.0711151237400.16728@wbgn129.biozentrum.uni-wuerzburg.de","subject":"Re: Problem in our test setup","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-15T17:30:26Z","receivedAt":"2007-11-15T17:30:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Funnily enough, it _is_ the non-dash form that I replaced.  What happens \n> is this: the git wrapper looks for a builtin named 'runstatus', does not \n> find it, then calls out for something like 'git-runstatus', which is found \n> in my $HOME/bin.\n\nYes, but at that point we know we are looking for \"git\"\nsubcommand not general command on PATH, so we can only look for\n\"git-runstatus\" in the git_exec_path (initialized by $GIT_EXEC_PATH \nor compiled-in) and correctly fail during the test.\n"}]}