{"thread":{"id":"10857","subject":"[PATCH] Fix dependencies of parse-options test program","startedAt":"2007-11-13T23:16:36Z","lastAt":"2007-11-14T08:48:19Z","messageCount":6,"participants":["Alex Riesen","Johannes Schindelin","Junio C Hamano","Pierre Habouzit"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"59770","messageId":"20071113231636.GJ3268@steel.home","threadId":"10857","inReplyTo":null,"subject":"[PATCH] Fix dependencies of parse-options test program","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-11-13T23:16:36Z","receivedAt":"2007-11-13T23:16:36Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen \n---\n\nAn old test-parse-options was breaking t0040.\n\n Makefile | 2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex cd6d469..af827f6 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -999,6 +999,8 @@ test-date$X: date.o ctype.o\n \n test-delta$X: diff-delta.o patch-delta.o\n \n+test-parse-options$X: parse-options.o\n+\n .PRECIOUS: $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))\n \n test-%$X: test-%.o $(GITLIBS)\n-- \n1.5.3.5.668.g22088\n"},{"id":"59773","messageId":"Pine.LNX.4.64.0711132345310.4362@racer.site","threadId":"10857","inReplyTo":"20071113231636.GJ3268@steel.home","subject":"Re: [PATCH] Fix dependencies of parse-options test program","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-13T23:46:20Z","receivedAt":"2007-11-13T23:46:20Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\napparently I forgot to send this patch, which I thought was only relevant \nin the builtin-commit branch of mine:\n\n-- snipsnap --\n[PATCH] Makefile: add correct dependencies for test-parse-options\n\nSigned-off-by: Johannes Schindelin \n---\n Makefile | 4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex bda8762..2abb8da 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -996,6 +996,10 @@ test-date$X: date.o ctype.o\n \n test-delta$X: diff-delta.o patch-delta.o\n \n+test-parse-options$X: parse-options.o\n+\n+test-parse-options.o: parse-options.h\n+\n .PRECIOUS: $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))\n \n test-%$X: test-%.o $(GITLIBS)\n-- \n1.5.3.5.1769.gc3bdd\n"},{"id":"59785","messageId":"7vir45r8uo.fsf@gitster.siamese.dyndns.org","threadId":"10857","inReplyTo":"20071113231636.GJ3268@steel.home","subject":"Re: [PATCH] Fix dependencies of parse-options test program","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-14T00:03:59Z","receivedAt":"2007-11-14T00:03:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ah, I saw the breakage once but was too late at night to see\nwhat was wrong myself. Thanks.\n"},{"id":"59787","messageId":"20071114000833.GC22836@artemis.corp","threadId":"10857","inReplyTo":"Pine.LNX.4.64.0711132345310.4362@racer.site","subject":"Re: [PATCH] Fix dependencies of parse-options test program","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2007-11-14T00:08:33Z","receivedAt":"2007-11-14T00:08:33Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"On Tue, Nov 13, 2007 at 11:46:20PM +0000, Johannes Schindelin wrote:\n> Hi,\n> \n> apparently I forgot to send this patch, which I thought was only relevant \n> in the builtin-commit branch of mine:\n\n Btw is there a reason why git doesn't use the gcc -M* options to have\nproper dependency informations ? I understand not everyone has a gcc\ncompiler at hand, but still, most of the compilers know how to do that.\nWe could even borough depcomp from automake for that task.\n\n I've been bitten by dependencies issues in git many times, and it's\nonly now that I understand that it was dependency issues, I always\nassumed git Makefiles dealt with that already, and I believe that'd be\nnice to have a real solution for that.\n\n-- \n·O· Pierre Habouzit\n··O madcoder@debian.org\nOOO http://www.madism.org\n"},{"id":"59790","messageId":"Pine.LNX.4.64.0711140012210.4362@racer.site","threadId":"10857","inReplyTo":"20071114000833.GC22836@artemis.corp","subject":"Re: [PATCH] Fix dependencies of parse-options test program","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-14T00:12:49Z","receivedAt":"2007-11-14T00:12:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 14 Nov 2007, Pierre Habouzit wrote:\n\n> On Tue, Nov 13, 2007 at 11:46:20PM +0000, Johannes Schindelin wrote:\n> \n> > apparently I forgot to send this patch, which I thought was only \n> > relevant in the builtin-commit branch of mine:\n> \n> Btw is there a reason why git doesn't use the gcc -M* options to have\n> proper dependency informations ?\n\nI suspect the reason is that we do not want to depend on gcc...\n\nCiao,\nDscho\n"},{"id":"59826","messageId":"20071114084819.GA18926@artemis.corp","threadId":"10857","inReplyTo":"Pine.LNX.4.64.0711140012210.4362@racer.site","subject":"Re: [PATCH] Fix dependencies of parse-options test program","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2007-11-14T08:48:19Z","receivedAt":"2007-11-14T08:48:19Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"On Wed, Nov 14, 2007 at 12:12:49AM +0000, Johannes Schindelin wrote:\n> Hi,\n> \n> On Wed, 14 Nov 2007, Pierre Habouzit wrote:\n> \n> > On Tue, Nov 13, 2007 at 11:46:20PM +0000, Johannes Schindelin wrote:\n> > \n> > > apparently I forgot to send this patch, which I thought was only \n> > > relevant in the builtin-commit branch of mine:\n> > \n> > Btw is there a reason why git doesn't use the gcc -M* options to have\n> > proper dependency informations ?\n> \n> I suspect the reason is that we do not want to depend on gcc...\n\n right, but like said, other compilers can generate them, only with a\ndifferent CLI switch, and non withstanding this problem, there are tools\nto generate such kind of information easily.\n\n Though for those who care about this issue, this is hackable easily\nusing config.mak, here is how:\n\n CFLAGS += -MMD -MF $(@D)/.$(@F:.o=.dep)\n -include $(wildcard .*.dep */.*.dep) GIT-VERSION-FILE\n\nIt's a quick hack, but allow gcc + gnu make (I believe $(@D) is GNU)\nusers not to be bitten hard by those dependency issues.\n\nThe reason why I include GIT-VERSION-FILE again is that many make\ncomplain if -include gets an empty like as an argument, and passing\n/dev/null on certains occasions triggers warnings about /dev/null having\na date in the future on some machines for a reason I never found.\n-- \n·O· Pierre Habouzit\n··O madcoder@debian.org\nOOO http://www.madism.org\n"}]}