{"thread":{"id":"10779","subject":"gitweb, updating 'last changed' column on the project page","startedAt":"2007-11-10T01:09:08Z","lastAt":"2007-11-10T16:25:25Z","messageCount":10,"participants":["Jon Smirl","Jakub Narebski","Lars Hjemli","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"59159","messageId":"9e4733910711091709k173bf23flf2824673f82de9bb@mail.gmail.com","threadId":"10779","inReplyTo":null,"subject":"gitweb, updating 'last changed' column on the project page","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-11-10T01:09:08Z","receivedAt":"2007-11-10T01:09:08Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n\nmpc5200b.git\n\tDigiSpeaker for Freescale MPC5200B.\n\tJon Smirl\n\t5 weeks ago\n\tsummary | shortlog | log | tree\n\nIt still says 5 weeks ago, but if I click on the project last change is today.\n\nWhat controls this? I tried running update-server-info\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"59161","messageId":"fh337a$ggp$1@ger.gmane.org","threadId":"10779","inReplyTo":"9e4733910711091709k173bf23flf2824673f82de9bb@mail.gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-11-10T01:58:06Z","receivedAt":"2007-11-10T01:58:06Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jon Smirl wrote:\n\n> At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n> \n> mpc5200b.git\n> DigiSpeaker for Freescale MPC5200B.\n> Jon Smirl\n> 5 weeks ago\n> summary | shortlog | log | tree\n> \n> It still says 5 weeks ago, but if I click on the project last change is today.\n> \n> What controls this? I tried running update-server-info\n\nWhat does\n\n git for-each-ref --format=\"%(refname):%09%(committer)\" --sort=-committerdate\n refs/heads\n\nreturn? Does adding --count select proper branch, with proper update\ndate?\n\nWhich gitweb version is this?\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"59170","messageId":"9e4733910711092201n5aaeeb7cvfd0e76e43170d481@mail.gmail.com","threadId":"10779","inReplyTo":"fh337a$ggp$1@ger.gmane.org","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-11-10T06:01:11Z","receivedAt":"2007-11-10T06:01:11Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 11/9/07, Jakub Narebski wrote:\n> Jon Smirl wrote:\n>\n> > At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n> >\n> > mpc5200b.git\n> > DigiSpeaker for Freescale MPC5200B.\n> > Jon Smirl\n> > 5 weeks ago\n> > summary | shortlog | log | tree\n> >\n> > It still says 5 weeks ago, but if I click on the project last change is today.\n> >\n> > What controls this? I tried running update-server-info\n>\n> What does\n>\n> git for-each-ref --format=\"%(refname):%09%(committer)\" --sort=-committerdate\n> refs/heads\n\n[daedalus]$ git for-each-ref --format=\"%(refname):%09%(committer)\"\n--sort=-committerdate refs/heads\nrefs/heads/m24: Jon Smirl 1191362799 -0400\nrefs/heads/m25: Jon Smirl 1191472422 -0400\nrefs/heads/m26: Jon Smirl 1194382038 -0500\nrefs/heads/m28: Jon Smirl 1194385071 -0500\nrefs/heads/m29: Jon Smirl 1194585780 -0500\n\n>\n> return? Does adding --count select proper branch, with proper update\n> date?\n\nIs it looking for master, and just picking the first branch instead?\n\n>\n> Which gitweb version is this?\n\n\n\n\n>\n> --\n> Jakub Narebski\n> Warsaw, Poland\n> ShadeHawk on #git\n>\n>\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"59173","messageId":"9e4733910711092210o65759276sd6970af5d29f2f32@mail.gmail.com","threadId":"10779","inReplyTo":"9e4733910711092201n5aaeeb7cvfd0e76e43170d481@mail.gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-11-10T06:10:57Z","receivedAt":"2007-11-10T06:10:57Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 11/10/07, Jon Smirl wrote:\n> On 11/9/07, Jakub Narebski wrote:\n> > Jon Smirl wrote:\n> >\n> > > At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n> > >\n> > > mpc5200b.git\n> > > DigiSpeaker for Freescale MPC5200B.\n> > > Jon Smirl\n> > > 5 weeks ago\n> > > summary | shortlog | log | tree\n> > >\n> > > It still says 5 weeks ago, but if I click on the project last change is today.\n> > >\n> > > What controls this? I tried running update-server-info\n> >\n> > What does\n> >\n> > git for-each-ref --format=\"%(refname):%09%(committer)\" --sort=-committerdate\n> > refs/heads\n>\n> [daedalus]$ git for-each-ref --format=\"%(refname):%09%(committer)\"\n> --sort=-committerdate refs/heads\n> refs/heads/m24: Jon Smirl 1191362799 -0400\n> refs/heads/m25: Jon Smirl 1191472422 -0400\n> refs/heads/m26: Jon Smirl 1194382038 -0500\n> refs/heads/m28: Jon Smirl 1194385071 -0500\n> refs/heads/m29: Jon Smirl 1194585780 -0500\n\n\nIt appears to be using the first head instead of the most recent date.\n\n\n>\n> >\n> > return? Does adding --count select proper branch, with proper update\n> > date?\n>\n> Is it looking for master, and just picking the first branch instead?\n>\n> >\n> > Which gitweb version is this?\n>\n> \n> \n>\n> >\n> > --\n> > Jakub Narebski\n> > Warsaw, Poland\n> > ShadeHawk on #git\n> >\n> >\n> > -\n> > To unsubscribe from this list: send the line \"unsubscribe git\" in\n> > the body of a message to majordomo@vger.kernel.org\n> > More majordomo info at http://vger.kernel.org/majordomo-info.html\n> >\n>\n>\n> --\n> Jon Smirl\n> jonsmirl@gmail.com\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"59184","messageId":"200711101034.47861.jnareb@gmail.com","threadId":"10779","inReplyTo":"9e4733910711092210o65759276sd6970af5d29f2f32@mail.gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-11-10T09:34:46Z","receivedAt":"2007-11-10T09:34:46Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Saturday, 10 November 2007, Jon Smirl wrote:\n> On 11/10/07, Jon Smirl wrote:\n>> On 11/9/07, Jakub Narebski wrote:\n>>> Jon Smirl wrote:\n>>>\n>>>> At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n>>>>\n>>>> mpc5200b.git\n>>>> DigiSpeaker for Freescale MPC5200B.\n>>>> Jon Smirl\n>>>> 5 weeks ago\n>>>> summary | shortlog | log | tree\n>>>>\n>>>> It still says 5 weeks ago, but if I click on the project last change is today.\n>>>>\n>>>> What controls this? I tried running update-server-info\n>>>\n>>> What does\n>>>\n>>> git for-each-ref --format=\"%(refname):%09%(committer)\" --sort=-committerdate\n>>> refs/heads\n>>\n>> [daedalus]$ git for-each-ref --format=\"%(refname):%09%(committer)\" \\\n>> --sort=-committerdate refs/heads\n>> refs/heads/m24: Jon Smirl 1191362799 -0400\n>> refs/heads/m25: Jon Smirl 1191472422 -0400\n>> refs/heads/m26: Jon Smirl 1194382038 -0500\n>> refs/heads/m28: Jon Smirl 1194385071 -0500\n>> refs/heads/m29: Jon Smirl 1194585780 -0500\n> \n> It appears to be using the first head instead of the most recent date.\n\nIt appears to not _sort_ the output by committerdate, as it should with\n'--sort=-committerdate'.\n\n1442:[gitweb/web!git]$ git for-each-ref --format=\"%(refname):%09%(committer)\" \\\n --sort=-committerdate refs/heads\nrefs/heads/gitweb/web: Jakub Narebski 1194616779 +0100\nrefs/heads/man: Junio C Hamano 1194602628 +0000\nrefs/heads/html: Junio C Hamano 1194602626 +0000\nrefs/heads/origin: Junio C Hamano 1194602274 -0800\n[...]\nrefs/heads/gitweb-snapshot+navbar: Sven Verdoolaege 1134765981 +0100\n\n1443:[gitweb/web!git]$ git --version\ngit version 1.5.3.5\n\n\nNote that git-for-each-ref with those options returns most recent head\nfirst, sorting output by date of commit (date of adding to repository)\n\n>>>\n>>> return? Does adding --count select proper branch, with proper update\n>>> date?\n>>\n>> Is it looking for master, and just picking the first branch instead?\n\nGitweb should not (and I think does not) have 'master' hardcoded\nanywhere. It might use HEAD in some cases you don't want it to...\n\n>>>\n>>> Which gitweb version is this?\n>>\n>> \n>> \n\nOlder version of gitweb used HEAD branch for'last changed' info on\nthe projects list page. That is why I asked about gitweb version.\n\nBut this is not the case of your problem:\n1. Your gitweb is new enough to use git-for-each-ref. It use\n git for-each-ref --format=\"%(committer)\" --sort=-committerdate \n --count=1 refs/heads\n2. Looking at 'heads' view (or 'heads' part of summary view) one can see\n that m29 is current branch (HEAD), and it is most recent.\n\nStrange...\n-- \nJakub Narebski\nPoland\n"},{"id":"59207","messageId":"9e4733910711100505n78459612xdaa12eaa880773d8@mail.gmail.com","threadId":"10779","inReplyTo":"200711101034.47861.jnareb@gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-11-10T13:05:39Z","receivedAt":"2007-11-10T13:05:39Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 11/10/07, Jakub Narebski wrote:\n> On Saturday, 10 November 2007, Jon Smirl wrote:\n> > On 11/10/07, Jon Smirl wrote:\n> >> On 11/9/07, Jakub Narebski wrote:\n> >>> Jon Smirl wrote:\n> >>>\n> >>>> At http://git.digispeaker.com/ the 'last change' column is not getting updated.\n> >>>>\n> >>>> mpc5200b.git\n> >>>> DigiSpeaker for Freescale MPC5200B.\n> >>>> Jon Smirl\n> >>>> 5 weeks ago\n> >>>> summary | shortlog | log | tree\n> >>>>\n> >>>> It still says 5 weeks ago, but if I click on the project last change is today.\n> >>>>\n> >>>> What controls this? I tried running update-server-info\n> >>>\n> >>> What does\n> >>>\n> >>> git for-each-ref --format=\"%(refname):%09%(committer)\" --sort=-committerdate\n> >>> refs/heads\n> >>\n> >> [daedalus]$ git for-each-ref --format=\"%(refname):%09%(committer)\" \\\n> >> --sort=-committerdate refs/heads\n> >> refs/heads/m24: Jon Smirl 1191362799 -0400\n> >> refs/heads/m25: Jon Smirl 1191472422 -0400\n> >> refs/heads/m26: Jon Smirl 1194382038 -0500\n> >> refs/heads/m28: Jon Smirl 1194385071 -0500\n> >> refs/heads/m29: Jon Smirl 1194585780 -0500\n> >\n> > It appears to be using the first head instead of the most recent date.\n> It appears to not _sort_ the output by committerdate, as it should with\n> '--sort=-committerdate'.\n\nIt is sorted by committerdate, the sort is ascending. Did you expect\nit to be descending, pick off the last entry instead of the first?\n\n>\n> 1442:[gitweb/web!git]$ git for-each-ref --format=\"%(refname):%09%(committer)\" \\\n> --sort=-committerdate refs/heads\n> refs/heads/gitweb/web: Jakub Narebski 1194616779 +0100\n> refs/heads/man: Junio C Hamano 1194602628 +0000\n> refs/heads/html: Junio C Hamano 1194602626 +0000\n> refs/heads/origin: Junio C Hamano 1194602274 -0800\n> [...]\n> refs/heads/gitweb-snapshot+navbar: Sven Verdoolaege 1134765981 +0100\n>\n> 1443:[gitweb/web!git]$ git --version\n> git version 1.5.3.5\n>\n>\n> Note that git-for-each-ref with those options returns most recent head\n> first, sorting output by date of commit (date of adding to repository)\n>\n> >>>\n> >>> return? Does adding --count select proper branch, with proper update\n> >>> date?\n> >>\n> >> Is it looking for master, and just picking the first branch instead?\n>\n> Gitweb should not (and I think does not) have 'master' hardcoded\n> anywhere. It might use HEAD in some cases you don't want it to...\n>\n> >>>\n> >>> Which gitweb version is this?\n> >>\n> >> \n> >> \n>\n> Older version of gitweb used HEAD branch for'last changed' info on\n> the projects list page. That is why I asked about gitweb version.\n>\n> But this is not the case of your problem:\n> 1. Your gitweb is new enough to use git-for-each-ref. It use\n> git for-each-ref --format=\"%(committer)\" --sort=-committerdate\n> --count=1 refs/heads\n> 2. Looking at 'heads' view (or 'heads' part of summary view) one can see\n> that m29 is current branch (HEAD), and it is most recent.\n>\n> Strange...\n> --\n> Jakub Narebski\n> Poland\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"59210","messageId":"200711101427.18215.jnareb@gmail.com","threadId":"10779","inReplyTo":"9e4733910711100505n78459612xdaa12eaa880773d8@mail.gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-11-10T13:27:15Z","receivedAt":"2007-11-10T13:27:15Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jon Smirl wrote:\n> On 11/10/07, Jakub Narebski wrote:\n>> On Saturday, 10 November 2007, Jon Smirl wrote:\n>>> On 11/10/07, Jon Smirl wrote:\n>>>\n>>>> [daedalus]$ git for-each-ref --format=\"%(refname):%09%(committer)\" \\\n>>>> --sort=-committerdate refs/heads\n>>>> refs/heads/m24: Jon Smirl 1191362799 -0400\n>>>> refs/heads/m25: Jon Smirl 1191472422 -0400\n>>>> refs/heads/m26: Jon Smirl 1194382038 -0500\n>>>> refs/heads/m28: Jon Smirl 1194385071 -0500\n>>>> refs/heads/m29: Jon Smirl 1194585780 -0500\n>>>\n>>> It appears to be using the first head instead of the most recent date.\n>>\n>> It appears to not _sort_ the output by committerdate, as it should with\n>> '--sort=-committerdate'.\n> \n> It is sorted by committerdate, the sort is ascending. Did you expect\n> it to be descending, pick off the last entry instead of the first?\n\nExcerpts from git-for-each-ref(1):\n\n git-for-each-ref [--count=]* (...) [--sort=]* (...)\n\n \n By default the command shows all refs that match . This\n option makes it stop after showing that many refs.\n\n A field name to sort on. Prefix - to sort in descending order of the\n value. When unspecified, refname is used. More than one sort keys\n can be given.\n\nSo I expect --sort=-committerdate to sort by date of committing, \ndescending, and --count=1 pick first one, which means most recent.\n\nIt looks like \"your\" gitweb sorts ascending instead... strange...\n\n\nHow does git_get_last_activity subroutine in your gitweb.cgi looks like?\nDoes it have '--sort=-commiterdate'? If it has, then I think it is some\nstrange bug in git, if it doesn't it is strange modification of gitweb.\n\nHTH\n-- \nJakub Narebski\nPoland\n"},{"id":"59214","messageId":"9e4733910711100610y478c62cend1d9af84e0ecc08b@mail.gmail.com","threadId":"10779","inReplyTo":"200711101427.18215.jnareb@gmail.com","subject":"Re: gitweb, updating 'last changed' column on the project page","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-11-10T14:10:05Z","receivedAt":"2007-11-10T14:10:05Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 11/10/07, Jakub Narebski wrote:\n> > It is sorted by committerdate, the sort is ascending. Did you expect\n> > it to be descending, pick off the last entry instead of the first?\n>\n> Excerpts from git-for-each-ref(1):\n>\n> git-for-each-ref [--count=]* (...) [--sort=]* (...)\n>\n> \n> By default the command shows all refs that match . This\n> option makes it stop after showing that many refs.\n>\n> A field name to sort on. Prefix - to sort in descending order of the\n> value. When unspecified, refname is used. More than one sort keys\n> can be given.\n>\n> So I expect --sort=-committerdate to sort by date of committing,\n> descending, and --count=1 pick first one, which means most recent.\n\ngit has a bug, it is not implementing the - prefix. I am using git head.\n\njonsmirl@terra:~$ cd mpc5200b\njonsmirl@terra:~/mpc5200b$ git for-each-ref\n--format=\"%(refname):%09%(committer)\" --sort=-committerdate refs/heads\nrefs/heads/m24: Jon Smirl 1191362799 -0400\nrefs/heads/m25: Jon Smirl 1191472422 -0400\nrefs/heads/m26: Jon Smirl 1194382038 -0500\nrefs/heads/m28: Jon Smirl 1194385071 -0500\nrefs/heads/m29: Jon Smirl 1194674673 -0500\njonsmirl@terra:~/mpc5200b$ git for-each-ref\n--format=\"%(refname):%09%(committer)\" --sort=committerdate refs/heads\nrefs/heads/m24: Jon Smirl 1191362799 -0400\nrefs/heads/m25: Jon Smirl 1191472422 -0400\nrefs/heads/m26: Jon Smirl 1194382038 -0500\nrefs/heads/m28: Jon Smirl 1194385071 -0500\nrefs/heads/m29: Jon Smirl 1194674673 -0500\njonsmirl@terra:~/mpc5200b$ git --version\ngit version 1.5.3.5.1651.g30bf\njonsmirl@terra:~/mpc5200b$\n\n\n>\n> It looks like \"your\" gitweb sorts ascending instead... strange...\n>\n>\n> How does git_get_last_activity subroutine in your gitweb.cgi looks like?\n> Does it have '--sort=-commiterdate'? If it has, then I think it is some\n> strange bug in git, if it doesn't it is strange modification of gitweb.\n>\n> HTH\n> --\n> Jakub Narebski\n> Poland\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"59219","messageId":"1194710863-22868-1-git-send-email-hjemli@gmail.com","threadId":"10779","inReplyTo":"9e4733910711100610y478c62cend1d9af84e0ecc08b@mail.gmail.com","subject":"[PATCH] for-each-ref: fix setup of option-parsing for --sort","fromName":"Lars Hjemli","fromEmail":"hjemli@gmail.com","sentAt":"2007-11-10T16:07:43Z","receivedAt":"2007-11-10T16:07:43Z","isPatch":true,"sender":{"key":"hjemli@gmail.com","avatar":null},"body":"The option value for --sort is already a pointer to a pointer to struct\nref_sort, so just use it.\n\nSigned-off-by: Lars Hjemli \n---\n builtin-for-each-ref.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c\nindex da8c794..e909e66 100644\n--- a/builtin-for-each-ref.c\n+++ b/builtin-for-each-ref.c\n@@ -847,7 +847,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)\n \t\tOPT_GROUP(\"\"),\n \t\tOPT_INTEGER( 0 , \"count\", &maxcount, \"show only matched refs\"),\n \t\tOPT_STRING( 0 , \"format\", &format, \"format\", \"format to use for the output\"),\n-\t\tOPT_CALLBACK(0 , \"sort\", &sort_tail, \"key\",\n+\t\tOPT_CALLBACK(0 , \"sort\", sort_tail, \"key\",\n \t\t \"field name to sort on\", &opt_parse_sort),\n \t\tOPT_END(),\n \t};\n-- \n1.5.3.5.623.g0a1d\n"},{"id":"59222","messageId":"Pine.LNX.4.64.0711101625050.4362@racer.site","threadId":"10779","inReplyTo":"1194710863-22868-1-git-send-email-hjemli@gmail.com","subject":"Re: [PATCH] for-each-ref: fix setup of option-parsing for --sort","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-10T16:25:25Z","receivedAt":"2007-11-10T16:25:25Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 10 Nov 2007, Lars Hjemli wrote:\n\n> The option value for --sort is already a pointer to a pointer to struct\n> ref_sort, so just use it.\n\nCould you add a test for that too, please?\n\nThanks,\nDscho\n"}]}