{"thread":{"id":"10691","subject":"git-rev-list diff options broken","startedAt":"2007-11-06T22:14:14Z","lastAt":"2007-11-06T23:55:28Z","messageCount":5,"participants":["Han-Wen Nienhuys","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"58600","messageId":"f329bf540711061414k1627521bvaf4a7a06460cc3fd@mail.gmail.com","threadId":"10691","inReplyTo":null,"subject":"git-rev-list diff options broken","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2007-11-06T22:14:14Z","receivedAt":"2007-11-06T22:14:14Z","isPatch":false,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"Hi,\n\nthe git-rev-list manpage says\n\n\n**\nDiff Formatting\n~~~~~~~~~~~~~~~\n\nBelow are listed options that control the formatting of diff output.\nSome of them are specific to gitlink:git-rev-list[1], however other diff\noptions may be given. See gitlink:git-diff-files[1] for more options.\n**\n\nhowever, the source code says\n\n\n\tif ((!list &&\n\t (!(revs.tag_objects||revs.tree_objects||revs.blob_objects) &&\n\t !revs.pending.nr)) ||\n\t revs.diff)\n\t\tusage(rev_list_usage);\n\nso any attempt at showing diffs with git-rev-list will fail. What's\nthe deal with this?\n\n\n-- \nHan-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"58601","messageId":"f329bf540711061415w30fd069fi19adeccf45735ccf@mail.gmail.com","threadId":"10691","inReplyTo":"f329bf540711061414k1627521bvaf4a7a06460cc3fd@mail.gmail.com","subject":"Re: git-rev-list diff options broken","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2007-11-06T22:15:38Z","receivedAt":"2007-11-06T22:15:38Z","isPatch":false,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"2007/11/6, Han-Wen Nienhuys :\n> so any attempt at showing diffs with git-rev-list will fail. What's\n> the deal with this?\n\nthis is with\n\n git version 1.5.3.5.576.gfe6193\n\n-- \nHan-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"58613","messageId":"Pine.LNX.4.64.0711062330220.4362@racer.site","threadId":"10691","inReplyTo":"f329bf540711061414k1627521bvaf4a7a06460cc3fd@mail.gmail.com","subject":"Re: git-rev-list diff options broken","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-06T23:33:10Z","receivedAt":"2007-11-06T23:33:10Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 6 Nov 2007, Han-Wen Nienhuys wrote:\n\n> the git-rev-list manpage says\n> \n> \n> **\n> Diff Formatting\n> ~~~~~~~~~~~~~~~\n> \n> Below are listed options that control the formatting of diff output.\n> Some of them are specific to gitlink:git-rev-list[1], however other diff\n> options may be given. See gitlink:git-diff-files[1] for more options.\n> **\n> \n> however, the source code says\n> \n> \n> \tif ((!list &&\n> \t (!(revs.tag_objects||revs.tree_objects||revs.blob_objects) &&\n> \t !revs.pending.nr)) ||\n> \t revs.diff)\n> \t\tusage(rev_list_usage);\n> \n> so any attempt at showing diffs with git-rev-list will fail. What's\n> the deal with this?\n\nProbably you want to use \"git log\".\n\n\"git blame -L 585,589 builtin-rev-list.c\" indicates that 8c1f0b44(Fix up \nrev-list option parsing) was responsible, which in turn indicates that it \nwas intentional.\n\nHth,\nDscho\n"},{"id":"58615","messageId":"f329bf540711061538l4cdef27co2cb42a9938b2e325@mail.gmail.com","threadId":"10691","inReplyTo":"Pine.LNX.4.64.0711062330220.4362@racer.site","subject":"Re: git-rev-list diff options broken","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2007-11-06T23:38:39Z","receivedAt":"2007-11-06T23:38:39Z","isPatch":false,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"2007/11/6, Johannes Schindelin :\n\n>\n> Probably you want to use \"git log\".\n>\n> \"git blame -L 585,589 builtin-rev-list.c\" indicates that 8c1f0b44(Fix up\n> rev-list option parsing) was responsible, which in turn indicates that it\n> was intentional.\n\nOK. So the man page needs fixing, right?\n\n-- \nHan-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"58619","messageId":"Pine.LNX.4.64.0711062354070.4362@racer.site","threadId":"10691","inReplyTo":"f329bf540711061538l4cdef27co2cb42a9938b2e325@mail.gmail.com","subject":"Re: git-rev-list diff options broken","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-06T23:55:28Z","receivedAt":"2007-11-06T23:55:28Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 6 Nov 2007, Han-Wen Nienhuys wrote:\n\n> 2007/11/6, Johannes Schindelin :\n> \n> > Probably you want to use \"git log\".\n> >\n> > \"git blame -L 585,589 builtin-rev-list.c\" indicates that 8c1f0b44(Fix \n> > up rev-list option parsing) was responsible, which in turn indicates \n> > that it was intentional.\n> \n> OK. So the man page needs fixing, right?\n\nI guess. Although it seems a bit involved, since the diff-formats.txt are \nnot included by git-rev-list.txt itself, but by pretty-formats.txt.\n\nCiao,\nDscho\n"}]}