{"thread":{"id":"10686","subject":"[PATCH] Fix minor nits in configure.ac","startedAt":"2007-11-06T20:12:45Z","lastAt":"2007-11-06T20:12:45Z","messageCount":1,"participants":["Ralf Wildenhues"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"58576","messageId":"20071106201245.GB3198@ins.uni-bonn.de","threadId":"10686","inReplyTo":null,"subject":"[PATCH] Fix minor nits in configure.ac","fromName":"Ralf Wildenhues","fromEmail":"ralf.wildenhues@gmx.de","sentAt":"2007-11-06T20:12:45Z","receivedAt":"2007-11-06T20:12:45Z","isPatch":true,"sender":{"key":"ralf.wildenhues@gmx.de","avatar":null},"body":"Avoid \"test -o\" as it is only XSI not POSIX, and not portable.\nAvoid exit(3) in test programs in favor of return, to accommodate\nfor newer Autoconf not providing a declaration for exit.\n---\n\nThe missing declaration can cause needlessly wrong configure results\nwith some CFLAGS.\n\nCheers,\nRalf\n\n configure.ac |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex ed7cc89..bd80517 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -73,7 +73,7 @@ fi \\\n AC_ARG_WITH([lib],\n  [AS_HELP_STRING([--with-lib=ARG],\n                  [ARG specifies alternative name for lib directory])],\n- [if test \"$withval\" = \"no\" -o \"$withval\" = \"yes\"; then \\\n+ [if test \"$withval\" = \"no\" || test \"$withval\" = \"yes\"; then \\\n \tAC_MSG_WARN([You should provide name for --with-lib=ARG]); \\\n else \\\n \tGIT_CONF_APPEND_LINE(lib=$withval); \\\n@@ -245,9 +245,9 @@ AC_RUN_IFELSE(\n \t[AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],\n \t\t[[char buf[64];\n \t\tif (sprintf(buf, \"%lld%hhd%jd%zd%td\", (long long int)1, (char)2, (intmax_t)3, (size_t)4, (ptrdiff_t)5) != 5)\n-\t\t  exit(1);\n+\t\t  return 1;\n \t\telse if (strcmp(buf, \"12345\"))\n-\t\t  exit(2);]])],\n+\t\t  return 2;]])],\n \t[ac_cv_c_c99_format=yes],\n \t[ac_cv_c_c99_format=no])\n ])\n-- \n1.5.3.5.561.g140d\n"}]}