{"thread":{"id":"10666","subject":"[PATCH] git-daemon: fix remote port number in log entry","startedAt":"2007-11-05T09:16:22Z","lastAt":"2007-11-05T09:16:22Z","messageCount":1,"participants":["Gerrit Pape"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"58355","messageId":"20071105091622.20256.qmail@ae827ecd1d1952.315fe32.mid.smarden.org","threadId":"10666","inReplyTo":null,"subject":"[PATCH] git-daemon: fix remote port number in log entry","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2007-11-05T09:16:22Z","receivedAt":"2007-11-05T09:16:22Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"The port number in struct sockaddr_in needs to be converted from network\nbyte order to host byte order (on some architectures).\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n daemon.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/daemon.c b/daemon.c\nindex 660e155..b8df980 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -540,7 +540,7 @@ static int execute(struct sockaddr *addr)\n \t\tif (addr->sa_family == AF_INET) {\n \t\t\tstruct sockaddr_in *sin_addr = (void *) addr;\n \t\t\tinet_ntop(addr->sa_family, &sin_addr->sin_addr, addrbuf, sizeof(addrbuf));\n-\t\t\tport = sin_addr->sin_port;\n+\t\t\tport = ntohs(sin_addr->sin_port);\n #ifndef NO_IPV6\n \t\t} else if (addr && addr->sa_family == AF_INET6) {\n \t\t\tstruct sockaddr_in6 *sin6_addr = (void *) addr;\n@@ -550,7 +550,7 @@ static int execute(struct sockaddr *addr)\n \t\t\tinet_ntop(AF_INET6, &sin6_addr->sin6_addr, buf, sizeof(addrbuf) - 1);\n \t\t\tstrcat(buf, \"]\");\n \n-\t\t\tport = sin6_addr->sin6_port;\n+\t\t\tport = ntohs(sin6_addr->sin6_port);\n #endif\n \t\t}\n \t\tloginfo(\"Connection from %s:%d\", addrbuf, port);\n-- \n1.5.3.5\n"}]}