{"thread":{"id":"10656","subject":"[PATCH] Rearrange git-format-patch synopsis to improve clarity.","startedAt":"2007-11-04T22:27:05Z","lastAt":"2007-11-06T21:08:52Z","messageCount":7,"participants":["David Symonds","Junio C Hamano","Andreas Ericsson","Jon Loeliger"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"58315","messageId":"119421522591-git-send-email-dsymonds@gmail.com","threadId":"10656","inReplyTo":null,"subject":"[PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-11-04T22:27:05Z","receivedAt":"2007-11-04T22:27:05Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"Signed-off-by: David Symonds <dsymonds@gmail.com>\n---\n Documentation/git-format-patch.txt |    5 +++--\n 1 files changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex 92c0ab6..d8a89a1 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -9,10 +9,11 @@ git-format-patch - Prepare patches for e-mail submission\n SYNOPSIS\n --------\n [verse]\n-'git-format-patch' [-n | -N | -k] [-o <dir> | --stdout] [--thread]\n+'git-format-patch' [-k] [-o <dir> | --stdout] [--thread]\n                    [--attach[=<boundary>] | --inline[=<boundary>]]\n                    [-s | --signoff] [<common diff options>]\n-                   [--start-number <n>] [--numbered-files]\n+                   [-n | --numbered-files | -N | --no-numbered]\n+                   [--start-number <n>]\n                    [--in-reply-to=Message-Id] [--suffix=.<sfx>]\n                    [--ignore-if-in-upstream]\n                    [--subject-prefix=Subject-Prefix]\n-- \n1.5.3.1\n"},{"id":"58419","messageId":"7vtzo0o09u.fsf@gitster.siamese.dyndns.org","threadId":"10656","inReplyTo":"119421522591-git-send-email-dsymonds@gmail.com","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-05T21:22:37Z","receivedAt":"2007-11-05T21:22:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks\n"},{"id":"58439","messageId":"ee77f5c20711051432w284cf22dx71192c145d25dced@mail.gmail.com","threadId":"10656","inReplyTo":"119421522591-git-send-email-dsymonds@gmail.com","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-11-05T22:32:25Z","receivedAt":"2007-11-05T22:32:25Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 11/5/07, David Symonds <dsymonds@gmail.com> wrote:\n>                     [-s | --signoff] [<common diff options>]\n> -                   [--start-number <n>] [--numbered-files]\n> +                   [-n | --numbered-files | -N | --no-numbered]\n> +                   [--start-number <n>]\n\nNow that I look at it again, it seems the long options look quite\ninconsistent. I think it should be either\n--numbered-files/--no-numbered-files or --numbered/--no-numbered. My\npreference is with the latter (for brevity), but that breaks\nbackward-compatibility.\n\nWould you accept a patch that changed --numbered-files to --numbered,\nand kept the former as a synonym?\n\n\nDave.\n"},{"id":"58441","messageId":"472F9DC6.8020607@op5.se","threadId":"10656","inReplyTo":"ee77f5c20711051432w284cf22dx71192c145d25dced@mail.gmail.com","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2007-11-05T22:48:38Z","receivedAt":"2007-11-05T22:48:38Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"David Symonds wrote:\n> On 11/5/07, David Symonds <dsymonds@gmail.com> wrote:\n>>                     [-s | --signoff] [<common diff options>]\n>> -                   [--start-number <n>] [--numbered-files]\n>> +                   [-n | --numbered-files | -N | --no-numbered]\n>> +                   [--start-number <n>]\n> \n> Now that I look at it again, it seems the long options look quite\n> inconsistent. I think it should be either\n> --numbered-files/--no-numbered-files or --numbered/--no-numbered. My\n> preference is with the latter (for brevity), but that breaks\n> backward-compatibility.\n> \n> Would you accept a patch that changed --numbered-files to --numbered,\n> and kept the former as a synonym?\n> \n\nI thought files were always numbered, but the [PATCH m/n] wasn't. Have I\nmissed something?\n\nIf your --numbered-files is supposed to affect only file-numbering, I'd\nsuggest *not* using --numbered, as it's ambiguous with \"number-subject\".\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"},{"id":"58445","messageId":"ee77f5c20711051456i1bbd0d58j43490c55e0be9664@mail.gmail.com","threadId":"10656","inReplyTo":"472F9DC6.8020607@op5.se","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-11-05T22:56:36Z","receivedAt":"2007-11-05T22:56:36Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 11/6/07, Andreas Ericsson <ae@op5.se> wrote:\n> David Symonds wrote:\n> > On 11/5/07, David Symonds <dsymonds@gmail.com> wrote:\n> >>                     [-s | --signoff] [<common diff options>]\n> >> -                   [--start-number <n>] [--numbered-files]\n> >> +                   [-n | --numbered-files | -N | --no-numbered]\n> >> +                   [--start-number <n>]\n> >\n> > Now that I look at it again, it seems the long options look quite\n> > inconsistent. I think it should be either\n> > --numbered-files/--no-numbered-files or --numbered/--no-numbered. My\n> > preference is with the latter (for brevity), but that breaks\n> > backward-compatibility.\n> >\n> > Would you accept a patch that changed --numbered-files to --numbered,\n> > and kept the former as a synonym?\n> >\n>\n> I thought files were always numbered, but the [PATCH m/n] wasn't. Have I\n> missed something?\n>\n> If your --numbered-files is supposed to affect only file-numbering, I'd\n> suggest *not* using --numbered, as it's ambiguous with \"number-subject\".\n\nYou're right. There's both --numbered ([PATCH n/m] stuff) and\n--numbered-files (0001.patch instead of 0001-subject-line.patch). I'll\nrevise my patch to clarify this.\n\n\nDave.\n"},{"id":"58545","messageId":"473081C2.7060106@freescale.com","threadId":"10656","inReplyTo":"ee77f5c20711051432w284cf22dx71192c145d25dced@mail.gmail.com","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"Jon Loeliger","fromEmail":"jdl@freescale.com","sentAt":"2007-11-06T15:01:22Z","receivedAt":"2007-11-06T15:01:22Z","isPatch":true,"sender":{"key":"jdl@jdl.com","avatar":"https://gravatar.com/avatar/75ce9a10b151acd2c28ec4ab2136dba7b2ff1634530bd04b155981a749d08a64?d=mp&s=160"},"body":"David Symonds wrote:\n> On 11/5/07, David Symonds <dsymonds@gmail.com> wrote:\n>>                     [-s | --signoff] [<common diff options>]\n>> -                   [--start-number <n>] [--numbered-files]\n>> +                   [-n | --numbered-files | -N | --no-numbered]\n>> +                   [--start-number <n>]\n> \n> Now that I look at it again, it seems the long options look quite\n> inconsistent. I think it should be either\n> --numbered-files/--no-numbered-files or --numbered/--no-numbered. My\n> preference is with the latter (for brevity), but that breaks\n> backward-compatibility.\n> \n> Would you accept a patch that changed --numbered-files to --numbered,\n> and kept the former as a synonym?\n\nThere are two forms of numbered file output names:\nthe traditional \"0001-Foo-the-bar\" and just \"1\" styles.\nPlease don't break that.  Both are needed.\n\nThanks,\njdl\n"},{"id":"58591","messageId":"ee77f5c20711061308p11c091f7h730b93c9b49542df@mail.gmail.com","threadId":"10656","inReplyTo":"473081C2.7060106@freescale.com","subject":"Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-11-06T21:08:52Z","receivedAt":"2007-11-06T21:08:52Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 11/7/07, Jon Loeliger <jdl@freescale.com> wrote:\n> David Symonds wrote:\n> > Now that I look at it again, it seems the long options look quite\n> > inconsistent. I think it should be either\n> > --numbered-files/--no-numbered-files or --numbered/--no-numbered. My\n> > preference is with the latter (for brevity), but that breaks\n> > backward-compatibility.\n> >\n> > Would you accept a patch that changed --numbered-files to --numbered,\n> > and kept the former as a synonym?\n>\n> There are two forms of numbered file output names:\n> the traditional \"0001-Foo-the-bar\" and just \"1\" styles.\n> Please don't break that.  Both are needed.\n\nOh, I certainly wasn't proposing removing any functionality; merely\nrenaming the option to select it so as to be consistent.\n\n\nDave.\n"}]}