{"thread":{"id":"10569","subject":"[PATCH] Make git-clone obey \"--\" (end argument parsing)","startedAt":"2007-11-01T19:54:18Z","lastAt":"2007-11-01T20:39:58Z","messageCount":2,"participants":["Heikki Orsila","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"57850","messageId":"20071101195418.607DA4F95F@jolt.modeemi.cs.tut.fi","threadId":"10569","inReplyTo":null,"subject":"[PATCH] Make git-clone obey \"--\" (end argument parsing)","fromName":"Heikki Orsila","fromEmail":"shd@jolt.modeemi.cs.tut.fi","sentAt":"2007-11-01T19:54:18Z","receivedAt":"2007-11-01T19:54:18Z","isPatch":true,"sender":{"key":"shd@jolt.modeemi.cs.tut.fi","avatar":null},"body":"Oops. Reposting the patch.\n\nThis patch handles \"--\" argument for git-clone.\n\nSigned-off-by: Heikki Orsila <heikki.orsila@iki.fi>\n\n>From bd2d661c565062eacc80dda90f3978303308f9bb Mon Sep 17 00:00:00 2001\nFrom: Heikki Orsila <heikki.orsila@iki.fi>\nDate: Thu, 1 Nov 2007 16:21:39 +0200\nSubject: [PATCH] Make git-clone obey \"--\" (end argument parsing)\n\n---\n Documentation/git-clone.txt |    2 +-\n git-clone.sh                |    5 ++++-\n 2 files changed, 5 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt\nindex 253f4f0..7fdcd42 100644\n--- a/Documentation/git-clone.txt\n+++ b/Documentation/git-clone.txt\n@@ -12,7 +12,7 @@ SYNOPSIS\n 'git-clone' [--template=<template_directory>]\n \t  [-l] [-s] [--no-hardlinks] [-q] [-n] [--bare]\n \t  [-o <name>] [-u <upload-pack>] [--reference <repository>]\n-\t  [--depth <depth>] <repository> [<directory>]\n+\t  [--depth <depth>] [--] <repository> [<directory>]\n \n DESCRIPTION\n -----------\ndiff --git a/git-clone.sh b/git-clone.sh\nindex 0ea3c24..3f00693 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -14,7 +14,7 @@ die() {\n }\n \n usage() {\n-\tdie \"Usage: $0 [--template=<template_directory>] [--reference <reference-repo>] [--bare] [-l [-s]] [-q] [-u <upload-pack>] [--origin <name>] [--depth <n>] [-n] <repo> [<dir>]\"\n+\tdie \"Usage: $0 [--template=<template_directory>] [--reference <reference-repo>] [--bare] [-l [-s]] [-q] [-u <upload-pack>] [--origin <name>] [--depth <n>] [-n] [--] <repo> [<dir>]\"\n }\n \n get_repo_base() {\n@@ -160,6 +160,9 @@ while\n \t*,--depth)\n \t\tshift\n \t\tdepth=\"--depth=$1\";;\n+\t*,--)\n+\t\tshift\n+\t\tbreak ;;\n \t*,-*) usage ;;\n \t*) break ;;\n \tesac\n-- \n1.5.3.4.498.g9c514-dirty\n"},{"id":"57856","messageId":"7vve8laee9.fsf@gitster.siamese.dyndns.org","threadId":"10569","inReplyTo":"20071101195418.607DA4F95F@jolt.modeemi.cs.tut.fi","subject":"Re: [PATCH] Make git-clone obey \"--\" (end argument parsing)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-01T20:39:58Z","receivedAt":"2007-11-01T20:39:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"shd@jolt.modeemi.cs.tut.fi (Heikki Orsila) writes:\n\n> Oops. Reposting the patch.\n>\n> This patch handles \"--\" argument for git-clone.\n>\n> Signed-off-by: Heikki Orsila <heikki.orsila@iki.fi>\n>\n>>From bd2d661c565062eacc80dda90f3978303308f9bb Mon Sep 17 00:00:00 2001\n> From: Heikki Orsila <heikki.orsila@iki.fi>\n> Date: Thu, 1 Nov 2007 16:21:39 +0200\n> Subject: [PATCH] Make git-clone obey \"--\" (end argument parsing)\n>\n> ---\n>  Documentation/git-clone.txt |    2 +-\n>  git-clone.sh                |    5 ++++-\n>  2 files changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt\n> index 253f4f0..7fdcd42 100644\n> --- a/Documentation/git-clone.txt\n> +++ b/Documentation/git-clone.txt\n> @@ -12,7 +12,7 @@ SYNOPSIS\n>  'git-clone' [--template=<template_directory>]\n>  \t  [-l] [-s] [--no-hardlinks] [-q] [-n] [--bare]\n>  \t  [-o <name>] [-u <upload-pack>] [--reference <repository>]\n> -\t  [--depth <depth>] <repository> [<directory>]\n> +\t  [--depth <depth>] [--] <repository> [<directory>]\n\nI do not think this breaks anything, but does it _help_\nanything in practice?\n\nWhat kind of breakage does this patch fix?\n"}]}