{"thread":{"id":"10562","subject":"Where man git-format-patch sends me?","startedAt":"2007-11-01T13:58:43Z","lastAt":"2007-11-02T11:25:52Z","messageCount":5,"participants":["Sergei Organov","Johannes Schindelin","Wincent Colaiuta"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"57824","messageId":"87lk9i2hkc.fsf@osv.gnss.ru","threadId":"10562","inReplyTo":null,"subject":"Where man git-format-patch sends me?","fromName":"Sergei Organov","fromEmail":"osv@javad.com","sentAt":"2007-11-01T13:58:43Z","receivedAt":"2007-11-01T13:58:43Z","isPatch":false,"sender":{"key":"osv@javad.com","avatar":null},"body":"$ man git-format-patch\n[...]\nOPTIONS\n -p Generate patch (see section on generating patches)\n\n -u Synonym for \"-p\".\n[...]\n$\n\n1. Saying \"-p generates patch\" suggests that without -p git-format-patch\n will generate something else. It's rather confusing.\n\n2. Where is this \"section on generating patches\"? I thought it could be\n in man git-diff, but it is not.\n\n-- \nSergei.\n"},{"id":"57832","messageId":"Pine.LNX.4.64.0711011437440.4362@racer.site","threadId":"10562","inReplyTo":"87lk9i2hkc.fsf@osv.gnss.ru","subject":"Re: Where man git-format-patch sends me?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-01T14:38:41Z","receivedAt":"2007-11-01T14:38:41Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 1 Nov 2007, Sergei Organov wrote:\n\n> $ man git-format-patch\n> [...]\n> OPTIONS\n> -p Generate patch (see section on generating patches)\n> \n> -u Synonym for \"-p\".\n\nAs you can easily see from Documentation/git-format-patch.txt, this part \nis generated from the file Documentation/diff-options.txt.\n\nHth,\nDscho\n"},{"id":"57840","messageId":"877il22cip.fsf@osv.gnss.ru","threadId":"10562","inReplyTo":"Pine.LNX.4.64.0711011437440.4362@racer.site","subject":"Re: Where man git-format-patch sends me?","fromName":"Sergei Organov","fromEmail":"osv@javad.com","sentAt":"2007-11-01T15:47:42Z","receivedAt":"2007-11-01T15:47:42Z","isPatch":false,"sender":{"key":"osv@javad.com","avatar":null},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On Thu, 1 Nov 2007, Sergei Organov wrote:\n>\n>> $ man git-format-patch\n>> [...]\n>> OPTIONS\n>> -p Generate patch (see section on generating patches)\n>> \n>> -u Synonym for \"-p\".\n>\n> As you can easily see from Documentation/git-format-patch.txt, this part \n> is generated from the file Documentation/diff-options.txt.\n\nSorry, I did saw that, but it doesn't change anything.\n\n1. As a user reading man git-format-patch, where do I find this \"section\n on generating patches\"? In another man-page? In the html\n documentation? On the moon?\n\n2. I can't find \"section on generating patches\" in the man git-diff\n either, and I did say this in the part of my original message you've\n snipped.\n\nSo the main question remains: could you please point me to the exact\nplace in 'Documentation/' directory where this \"section on generating\npatches\" resides?\n\n-- \nSergei.\n"},{"id":"57955","messageId":"2A9EA819-C27A-4538-A9ED-B5281D137B94@wincent.com","threadId":"10562","inReplyTo":"877il22cip.fsf@osv.gnss.ru","subject":"Re: Where man git-format-patch sends me?","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2007-11-02T10:03:46Z","receivedAt":"2007-11-02T10:03:46Z","isPatch":false,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"El 1/11/2007, a las 16:47, Sergei Organov escribió:\n\n> Johannes Schindelin writes:\n>\n>> Hi,\n>>\n>> On Thu, 1 Nov 2007, Sergei Organov wrote:\n>>\n>>> $ man git-format-patch\n>>> [...]\n>>> OPTIONS\n>>> -p Generate patch (see section on generating patches)\n>>>\n>>> -u Synonym for \"-p\".\n>>\n>> As you can easily see from Documentation/git-format-patch.txt, this \n>> part\n>> is generated from the file Documentation/diff-options.txt.\n>\n> Sorry, I did saw that, but it doesn't change anything.\n>\n> 1. As a user reading man git-format-patch, where do I find this \n> \"section\n> on generating patches\"? In another man-page? In the html\n> documentation? On the moon?\n>\n> 2. I can't find \"section on generating patches\" in the man git-diff\n> either, and I did say this in the part of my original message you've\n> snipped.\n>\n> So the main question remains: could you please point me to the exact\n> place in 'Documentation/' directory where this \"section on generating\n> patches\" resides?\n\nI believe the section in question is in Documentation/diff-format.txt\n\nBut you've basically found a documentation bug. Someone invoking \"man \ngit-format-patch\" shouldn't be expected to have to grep the source \ntree in order to find out where the referenced documentation is. \nEspecially given that he/she may not even have the source.\n\nCheers,\nWincent\n"},{"id":"57969","messageId":"87odec28jj.fsf@osv.gnss.ru","threadId":"10562","inReplyTo":"2A9EA819-C27A-4538-A9ED-B5281D137B94@wincent.com","subject":"Re: Where man git-format-patch sends me?","fromName":"Sergei Organov","fromEmail":"osv@javad.com","sentAt":"2007-11-02T11:25:52Z","receivedAt":"2007-11-02T11:25:52Z","isPatch":false,"sender":{"key":"osv@javad.com","avatar":null},"body":"Wincent Colaiuta writes:\n\n> El 1/11/2007, a las 16:47, Sergei Organov escribió:\n>\n>> Johannes Schindelin writes:\n>>\n>>> Hi,\n>>>\n>>> On Thu, 1 Nov 2007, Sergei Organov wrote:\n>>>\n>>>> $ man git-format-patch\n>>>> [...]\n>>>> OPTIONS\n>>>> -p Generate patch (see section on generating patches)\n>>>>\n>>>> -u Synonym for \"-p\".\n>>>\n>>> As you can easily see from Documentation/git-format-patch.txt, this \n>>> part\n>>> is generated from the file Documentation/diff-options.txt.\n>>\n>> Sorry, I did saw that, but it doesn't change anything.\n>>\n>> 1. As a user reading man git-format-patch, where do I find this \n>> \"section\n>> on generating patches\"? In another man-page? In the html\n>> documentation? On the moon?\n>>\n>> 2. I can't find \"section on generating patches\" in the man git-diff\n>> either, and I did say this in the part of my original message you've\n>> snipped.\n>>\n>> So the main question remains: could you please point me to the exact\n>> place in 'Documentation/' directory where this \"section on generating\n>> patches\" resides?\n>\n> I believe the section in question is in Documentation/diff-format.txt\n\nAh, thank you! Now, diff-format.txt is included by\ngit-diff-index/git-diff-files/git-diff-tree, but not by git-diff and\ngit-format-patch. Do you think it is the right thing for the latter two\nto include diff-format as well?\n\n-- \nSergei.\n"}]}