{"thread":{"id":"1052","subject":"[PATCH 1/3] Demonstrate broken t6001 test case function","startedAt":"2005-06-30T02:41:55Z","lastAt":"2005-06-30T02:41:55Z","messageCount":1,"participants":["Jon Seymour"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"5434","messageId":"20050630024155.32511.qmail@blackcubes.dyndns.org","threadId":"1052","inReplyTo":null,"subject":"[PATCH 1/3] Demonstrate broken t6001 test case function","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2005-06-30T02:41:55Z","receivedAt":"2005-06-30T02:41:55Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"\nJunio discovered a problem where an actual test case break was hidden because pipelines\nare not handled properly by the test infrastructure in t6001.\n\nThis patch fixes the broken infrastructure (and demonstrates the break explicitly).\n\nA subsequent patch in this series will fix the test case so that it doesn't fail.\n\nSigned-off-by: Jon Seymour <jon.seymour@gmail.com>\n---\n\nThis patch set:\n   * demonstrates and fixes some broken test infrastructure\n   * fixes a broken test case that was previously hidden by the broken infrastructure\n   * simplifies the test case to remove an unnecessary sort.\n\nAlthough all patches in the set touch the same file, I have broken it into\nthree smaller patches to highlight the 3 different changes.\n\nThis patch set patches assumes that this series has been applied:\n\n[PATCH 1/2] Test case that demonstrates problem with --merge-order ^ processing\n[PATCH 2/2] Fix for git-rev-list --merge-order B ^A (A,B share common base) [rev 2]\n\n t/t6001-rev-list-merge-order.sh |    5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\n0b0041e1fdb1b25757b0c861a0832c54b922440b\ndiff --git a/t/t6001-rev-list-merge-order.sh b/t/t6001-rev-list-merge-order.sh\n--- a/t/t6001-rev-list-merge-order.sh\n+++ b/t/t6001-rev-list-merge-order.sh\n@@ -85,13 +85,12 @@ check_output()\n {\n \t_name=$1\n \tshift 1\n-\tif \"$@\" | entag > $_name.actual\n+\tif eval \"$*\" | entag > $_name.actual\n \tthen\n \t\tdiff $_name.expected $_name.actual\n \telse\n \t\treturn 1;\n \tfi\n-\t\n }\n \n # Turn a reasonable test description into a reasonable test name.\n@@ -114,7 +113,7 @@ test_output_expect_success()\n         [ $# -eq 2 ] || error \"usage: test_output_expect_success description test <<EOF ... EOF\"\n         _name=$(echo $_description | name_from_description)\n \tcat > $_name.expected\n-\ttest_expect_success \"$_description\" \"check_output $_name $_test\" \n+\ttest_expect_success \"$_description\" \"check_output $_name \\\"$_test\\\"\" \n }\n \n # --- end of stuff to move ---\n------------\n"}]}