{"thread":{"id":"10465","subject":"[PATCH] Fix generation of perl/perl.mak","startedAt":"2007-10-25T20:17:24Z","lastAt":"2007-10-25T21:21:29Z","messageCount":3,"participants":["Alex Riesen","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"57229","messageId":"20071025201724.GA11308@steel.home","threadId":"10465","inReplyTo":null,"subject":"[PATCH] Fix generation of perl/perl.mak","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-10-25T20:17:24Z","receivedAt":"2007-10-25T20:17:24Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"The code generating perl/Makefile from Makefile.PL was causing trouble\nbecause it didn't considered NO_PERL_MAKEMAKER and ran makemaker\nunconditionally, rewriting perl.mak. Makemaker is FUBAR in ActiveState Perl,\nand perl/Makefile has a replacement for it.\n\nBesides, a changed Git.pm is *NOT* a reason to rebuild all the perl scripts,\nso remove the dependency too.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n Makefile |    6 +-----\n 1 files changed, 1 insertions(+), 5 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex b728920..72f5ef4 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -812,7 +812,7 @@ $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh\n \n $(patsubst %.perl,%,$(SCRIPT_PERL)): perl/perl.mak\n \n-perl/perl.mak: GIT-CFLAGS\n+perl/perl.mak: GIT-CFLAGS perl/Makefile perl/Makefile.PL\n \t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' $(@F)\n \n $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl\n@@ -931,10 +931,6 @@ $(XDIFF_LIB): $(XDIFF_OBJS)\n \t$(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(XDIFF_OBJS)\n \n \n-perl/Makefile: perl/Git.pm perl/Makefile.PL GIT-CFLAGS\n-\t(cd perl && $(PERL_PATH) Makefile.PL \\\n-\t\tPREFIX='$(prefix_SQ)')\n-\n doc:\n \t$(MAKE) -C Documentation all\n \n-- \n1.5.3.4.403.g401f6\n"},{"id":"57238","messageId":"Pine.LNX.4.64.0710252140500.4362@racer.site","threadId":"10465","inReplyTo":"20071025201724.GA11308@steel.home","subject":"Re: [PATCH] Fix generation of perl/perl.mak","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-25T20:42:07Z","receivedAt":"2007-10-25T20:42:07Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 25 Oct 2007, Alex Riesen wrote:\n\n> Besides, a changed Git.pm is *NOT* a reason to rebuild all the perl \n> scripts, so remove the dependency too.\n>\n> [...]\n> \n> @@ -931,10 +931,6 @@ $(XDIFF_LIB): $(XDIFF_OBJS)\n>  \t$(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(XDIFF_OBJS)\n>  \n>  \n> -perl/Makefile: perl/Git.pm perl/Makefile.PL GIT-CFLAGS\n> -\t(cd perl && $(PERL_PATH) Makefile.PL \\\n> -\t\tPREFIX='$(prefix_SQ)')\n> -\n\nThis is not really the dependency triggering a rebuild of all perl \nscripts, right?\n\nCiao,\nDscho\n"},{"id":"57239","messageId":"20071025212129.GB11308@steel.home","threadId":"10465","inReplyTo":"Pine.LNX.4.64.0710252140500.4362@racer.site","subject":"Re: [PATCH] Fix generation of perl/perl.mak","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-10-25T21:21:29Z","receivedAt":"2007-10-25T21:21:29Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Johannes Schindelin, Thu, Oct 25, 2007 22:42:07 +0200:\n> On Thu, 25 Oct 2007, Alex Riesen wrote:\n> \n> > Besides, a changed Git.pm is *NOT* a reason to rebuild all the perl \n> > scripts, so remove the dependency too.\n> >\n> > [...]\n> > \n> > -perl/Makefile: perl/Git.pm perl/Makefile.PL GIT-CFLAGS\n> > -\t(cd perl && $(PERL_PATH) Makefile.PL \\\n> > -\t\tPREFIX='$(prefix_SQ)')\n> > -\n> \n> This is not really the dependency triggering a rebuild of all perl \n> scripts, right?\n\nIn a way. This rebuilds perl/perl.mak which, in turn, can cause the\nrebuild of all perl scripts. The rule you replaced with \"[...]\" does\nthe same, but uses perl/Makefile, which generates the perl.mak\n depending on the NO_PERL_MAKEMAKER setting.\n"}]}