{"thread":{"id":"10444","subject":"git-{diff,ls}-files from a subdirectory fails ...","startedAt":"2007-10-24T01:20:38Z","lastAt":"2007-10-24T11:26:26Z","messageCount":4,"participants":["Karl Hasselström","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"57049","messageId":"20071024012038.GA31326@diana.vm.bytemark.co.uk","threadId":"10444","inReplyTo":null,"subject":"git-{diff,ls}-files from a subdirectory fails ...","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-24T01:20:38Z","receivedAt":"2007-10-24T01:20:38Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"... when GIT_DIR is specified.\n\nI have a repository at ~/stgit-lib. With cwd at the top of the tree,\nthings work as expected when I set all those fancy envoronment\nvariables:\n\n  kha@yoghurt:~/stgit-lib> git-diff-files --name-only\n  stgit/utillib.py\n\n  kha@yoghurt:~/stgit-lib> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only\n  stgit/utillib.py\n\nHowever, it doen't seem to work from a subdirectory:\n\n  kha@yoghurt:~/stgit-lib/stgit> git-diff-files --name-only\n  stgit/utillib.py\n\n  kha@yoghurt:~/stgit-lib/stgit> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only | wc\n      170     170    3560\n\nInstead of just the one changed file, I get a list of what looks like\nall the files in the project, suggesting that maybe git assumes I'm at\nthe root of the worktree when I'm not.\n\ngit-ls-files seems to behave the same way. Bug or user error?\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"57068","messageId":"Pine.LNX.4.64.0710241104560.25221@racer.site","threadId":"10444","inReplyTo":"20071024012038.GA31326@diana.vm.bytemark.co.uk","subject":"Re: git-{diff,ls}-files from a subdirectory fails ...","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-24T10:06:43Z","receivedAt":"2007-10-24T10:06:43Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 24 Oct 2007, Karl Hasselstr?m wrote:\n\n> ... when GIT_DIR is specified.\n> \n> I have a repository at ~/stgit-lib. With cwd at the top of the tree,\n> things work as expected when I set all those fancy envoronment\n> variables:\n> \n>   kha@yoghurt:~/stgit-lib> git-diff-files --name-only\n>   stgit/utillib.py\n> \n>   kha@yoghurt:~/stgit-lib> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only\n>   stgit/utillib.py\n> \n> However, it doen't seem to work from a subdirectory:\n> \n>   kha@yoghurt:~/stgit-lib/stgit> git-diff-files --name-only\n>   stgit/utillib.py\n> \n>   kha@yoghurt:~/stgit-lib/stgit> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only | wc\n>       170     170    3560\n\n>From looking at it (very) briefly, it seems that you encountered the same \nbug that was fixed in\n\ndd5c8af176bb935a0b01a7dc2d5e022565c3aac3(Fix setup_git_directory_gently() \nwith relative GIT_DIR & GIT_WORK_TREE).\n\nIOW if you run git version v1.5.3.4-14-gdd5c8af or newer, you should not \nexperience this.\n\nHth,\nDscho\n"},{"id":"57071","messageId":"20071024104055.GB3908@diana.vm.bytemark.co.uk","threadId":"10444","inReplyTo":"Pine.LNX.4.64.0710241104560.25221@racer.site","subject":"Re: git-{diff,ls}-files from a subdirectory fails ...","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-24T10:40:55Z","receivedAt":"2007-10-24T10:40:55Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-10-24 11:06:43 +0100, Johannes Schindelin wrote:\n\n> On Wed, 24 Oct 2007, Karl Hasselström wrote:\n>\n> > However, it doen't seem to work from a subdirectory:\n> >\n> >   kha@yoghurt:~/stgit-lib/stgit> git-diff-files --name-only\n> >   stgit/utillib.py\n> >\n> >   kha@yoghurt:~/stgit-lib/stgit> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only | wc\n> >       170     170    3560\n>\n> From looking at it (very) briefly, it seems that you encountered the\n> same bug that was fixed in\n>\n> dd5c8af176bb935a0b01a7dc2d5e022565c3aac3(Fix setup_git_directory_gently()\n> with relative GIT_DIR & GIT_WORK_TREE).\n>\n> IOW if you run git version v1.5.3.4-14-gdd5c8af or newer, you should\n> not experience this.\n\nThanks for the pointer; that looks like it might indeed fix this bug.\nWill hopefully have time to verify later today.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"57074","messageId":"20071024112626.GA6459@diana.vm.bytemark.co.uk","threadId":"10444","inReplyTo":"20071024104055.GB3908@diana.vm.bytemark.co.uk","subject":"Re: git-{diff,ls}-files from a subdirectory fails ...","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-24T11:26:26Z","receivedAt":"2007-10-24T11:26:26Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-10-24 12:40:55 +0200, Karl Hasselström wrote:\n\n> On 2007-10-24 11:06:43 +0100, Johannes Schindelin wrote:\n>\n> > IOW if you run git version v1.5.3.4-14-gdd5c8af or newer, you\n> > should not experience this.\n>\n> Thanks for the pointer; that looks like it might indeed fix this\n> bug. Will hopefully have time to verify later today.\n\nIt works! Very timely bugfix ...\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"}]}