{"thread":{"id":"1044","subject":"[PATCH 1/1] Remove aliasing between COUNTED and UNINTERESTING flags used by rev-list.c","startedAt":"2005-06-29T14:16:29Z","lastAt":"2005-06-29T14:16:29Z","messageCount":1,"participants":["Jon Seymour"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"5413","messageId":"20050629141629.15754.qmail@blackcubes.dyndns.org","threadId":"1044","inReplyTo":null,"subject":"[PATCH 1/1] Remove aliasing between COUNTED and UNINTERESTING flags used by rev-list.c","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2005-06-29T14:16:29Z","receivedAt":"2005-06-29T14:16:29Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"\nThe COUNTED and UNINTERESTING flags were unintentionally aliased.\n\nThis patch makes sure that flags defined in rev-list.c have distinct\nvalues from from those defined by epoch.h.\n\nThe aliasing may have caused unexpected behaviour of the git-rev-list\n--bisect flag.\n\nSigned-off-by: Jon Seymour <jon.seymour@gmail.com>\n---\n\n rev-list.c |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\nfb2676c0c3991666db9a3b0ebe222d8028c12a05\ndiff --git a/rev-list.c b/rev-list.c\n--- a/rev-list.c\n+++ b/rev-list.c\n@@ -4,10 +4,10 @@\n #include \"blob.h\"\n #include \"epoch.h\"\n \n-#define SEEN\t\t(1u << 0)\n-#define INTERESTING\t(1u << 1)\n-#define COUNTED\t\t(1u << 2)\n-#define SHOWN\t\t(LAST_EPOCH_FLAG << 2)\n+#define SEEN        (LAST_EPOCH_FLAG << 1)\n+#define INTERESTING (LAST_EPOCH_FLAG << 2)\n+#define COUNTED     (LAST_EPOCH_FLAG << 3)\n+#define SHOWN       (LAST_EPOCH_FLAG << 4)\n \n static const char rev_list_usage[] =\n \t\"usage: git-rev-list [OPTION] commit-id <commit-id>\\n\"\n------------\n"}]}