{"thread":{"id":"10288","subject":"[PATCH 2/2] Fixing gitk indentation","startedAt":"2007-10-15T09:33:06Z","lastAt":"2007-10-15T09:33:08Z","messageCount":3,"participants":["Jonathan del Strother"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"55840","messageId":"11924407883641-git-send-email-maillist@steelskies.com","threadId":"10288","inReplyTo":"8c5c35580710141727k4bbd2bgc2292cfcc6f97c4a@mail.gmail.com","subject":"[PATCH 0/2] gitk: Added support for OS X mouse wheel","fromName":"Jonathan del Strother","fromEmail":"maillist@steelskies.com","sentAt":"2007-10-15T09:33:06Z","receivedAt":"2007-10-15T09:33:06Z","isPatch":true,"sender":{"key":"jon.delstrother@bestbefore.tv","avatar":"https://gravatar.com/avatar/754e21ab701c00e2d21fc261187254c34b2a1c0b959d9ee5be1a295990be3081?d=mp&s=160"},"body":"\nOn 15 Oct 2007, at 01:27, Lars Hjemli wrote:\n> Your patch has been mangled, probably by your MUA.\n> \n> Also, these -/+ 4 lines seem to only change tab into spaces: please\n> send such cleanups in a separate patch\n\nAlright, let's try again.  First patch fixes the mouse wheel, second patch fixes the weird indentation\n"},{"id":"55841","messageId":"1192440788347-git-send-email-maillist@steelskies.com","threadId":"10288","inReplyTo":"8c5c35580710141727k4bbd2bgc2292cfcc6f97c4a@mail.gmail.com","subject":"[PATCH 1/2] gitk: Added support for OS X mouse wheel","fromName":"Jonathan del Strother","fromEmail":"maillist@steelskies.com","sentAt":"2007-10-15T09:33:07Z","receivedAt":"2007-10-15T09:33:07Z","isPatch":true,"sender":{"key":"jon.delstrother@bestbefore.tv","avatar":"https://gravatar.com/avatar/754e21ab701c00e2d21fc261187254c34b2a1c0b959d9ee5be1a295990be3081?d=mp&s=160"},"body":"From: Jonathan del Strother <jon.delStrother@bestbefore.tv>\n\n(Väinö Järvelä supplied this patch a while ago for 1.5.2.  It no longer\napplied cleanly, so I'm reposting it.)\n\nMacBook doesn't seem to recognize MouseRelease-4 and -5 events, at all.\nSo i added a support for the MouseWheel event, which i limited to Tcl/tk\naqua, as i couldn't test it neither on Linux or Windows. Tcl/tk needs to\nbe updated from the version that is shipped with OS X 10.4 Tiger, for\nthis patch to work.\n\nSigned-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv>\n---\n gitk |    6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 300fdce..ee2a6f5 100755\n--- a/gitk\n+++ b/gitk\n@@ -843,6 +843,12 @@ proc makewindow {} {\n     } else {\n \tbindall <ButtonRelease-4> \"allcanvs yview scroll -5 units\"\n \tbindall <ButtonRelease-5> \"allcanvs yview scroll 5 units\"\n+        if {[tk windowingsystem] eq \"aqua\"} {\n+            bindall <MouseWheel> {\n+                set delta [expr {- (%D)}]\n+                allcanvs yview scroll $delta units\n+            }\n+        }\n     }\n     bindall <2> \"canvscan mark %W %x %y\"\n     bindall <B2-Motion> \"canvscan dragto %W %x %y\"\n-- \n1.5.3.1\n"},{"id":"55839","messageId":"11924407882007-git-send-email-maillist@steelskies.com","threadId":"10288","inReplyTo":"8c5c35580710141727k4bbd2bgc2292cfcc6f97c4a@mail.gmail.com","subject":"[PATCH 2/2] Fixing gitk indentation","fromName":"Jonathan del Strother","fromEmail":"maillist@steelskies.com","sentAt":"2007-10-15T09:33:08Z","receivedAt":"2007-10-15T09:33:08Z","isPatch":true,"sender":{"key":"jon.delstrother@bestbefore.tv","avatar":"https://gravatar.com/avatar/754e21ab701c00e2d21fc261187254c34b2a1c0b959d9ee5be1a295990be3081?d=mp&s=160"},"body":"From: Jonathan del Strother <jon.delStrother@bestbefore.tv>\n\nJust tweaking some minor indentation issues in gitk\n\nSigned-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv>\n---\n gitk |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex ee2a6f5..9b3e627 100755\n--- a/gitk\n+++ b/gitk\n@@ -838,11 +838,11 @@ proc makewindow {} {\n     bindall <1> {selcanvline %W %x %y}\n     #bindall <B1-Motion> {selcanvline %W %x %y}\n     if {[tk windowingsystem] == \"win32\"} {\n-\tbind . <MouseWheel> { windows_mousewheel_redirector %W %X %Y %D }\n-\tbind $ctext <MouseWheel> { windows_mousewheel_redirector %W %X %Y %D ; break }\n+        bind . <MouseWheel> { windows_mousewheel_redirector %W %X %Y %D }\n+        bind $ctext <MouseWheel> { windows_mousewheel_redirector %W %X %Y %D ; break }\n     } else {\n-\tbindall <ButtonRelease-4> \"allcanvs yview scroll -5 units\"\n-\tbindall <ButtonRelease-5> \"allcanvs yview scroll 5 units\"\n+        bindall <ButtonRelease-4> \"allcanvs yview scroll -5 units\"\n+        bindall <ButtonRelease-5> \"allcanvs yview scroll 5 units\"\n         if {[tk windowingsystem] eq \"aqua\"} {\n             bindall <MouseWheel> {\n                 set delta [expr {- (%D)}]\n-- \n1.5.3.1\n"}]}