{"thread":{"id":"10256","subject":"[RFC] git-gui window layout","startedAt":"2007-10-12T08:49:26Z","lastAt":"2007-10-12T10:56:10Z","messageCount":3,"participants":["Adam Piatyszek","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"55534","messageId":"470F3516.7020606@users.sourceforge.net","threadId":"10256","inReplyTo":null,"subject":"[RFC] git-gui window layout","fromName":"Adam Piatyszek","fromEmail":"ediap@users.sourceforge.net","sentAt":"2007-10-12T08:49:26Z","receivedAt":"2007-10-12T08:49:26Z","isPatch":false,"sender":{"key":"ediap@users.sourceforge.net","avatar":null},"body":"Dear Giters,\n\nI would like you to comment on my idea to change, or at least add a\npossibility to change, the current layout of git-gui window.\n\nNowadays there is a tendency to produce wide screens for laptops and\neven standalone LCD monitors. One can safely assume that the minimum\nreasonable horizontal resolution of a screen is at least 1024 pixels (I\ndo not expect anyone using git-gui with 800x600 resolution).\nMoreover, most popular window managers decreases the vertical dimension\nof a desktop by using horizontally-oriented panels (e.g. KDE, Gnome,\nXFCE4, etc.)\n\nThe current layout of git-gui window covering the whole desktop area on\na typical WXGA (1280x800) laptop LCD display is thus:\n\n+----------+-----------------------------------+\n| | |\n| staged | unstaged |\n| | |\n+----------+----------------+------------------+\n|### commit log | EMPTY |\n|### | |\n+---------------------------+------------------+\n| |\n| diff output |\n| |\n+----------------------------------------------+\n\nIn my opinion, the staged, unstaged and diff areas are usually used for\ndisplaying things that are taller than wider (e.g. a list of files,\npatches of well structured code, which is usually < 80 columns). The\ncommit log window is also designed for text narrower than < 80 cols.\n\nTherefore in my opinion it might be more useful to restructure this\nlayout to something like this:\n\n+-------------+----------------------------+---+\n| | |###|\n| | commit log |###|\n| staged +----------------------------+---+\n| | |\n| | |\n+----- 1 -----+ |\n| | diff output |\n| 2 |\n| unstaged | |\n| | |\n| | |\n+-------------+--------------------------------+\n\nButtons (rescan, push, commit, etc.) are denoted here as ###. Besides\nthe walls denoted as 1 and 2 should be movable so one could adjust the\nsize of staged/unstaged and diff areas.\nThe minimum width of diff window would be limited by the commit log\nwindow width (I propose 80 colums) plus the size of the buttons.\n\nUnfortunately, I do not nothing about TCL/TK programming, so I even did\nnot tried to analyse the code of git-gui. Therefore I am not sure if\nsuch a restructure is easy to implement.\n\nAnyway I hope for your comments to this idea.\n\nBR,\n/Adam\n\n\n-- \n.:. Adam Piatyszek - \"ediap\" .:. JID: ediap(at)jabber.org .:.\n.:. ediap(at)users.sourceforge.net .:. PGP key ID: 0x1F115CCB .:.\n"},{"id":"55537","messageId":"470F45D6.6050106@viscovery.net","threadId":"10256","inReplyTo":"470F3516.7020606@users.sourceforge.net","subject":"Re: [RFC] git-gui window layout","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2007-10-12T10:00:54Z","receivedAt":"2007-10-12T10:00:54Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Adam Piatyszek schrieb:\n> Dear Giters,\n> \n> I would like you to comment on my idea to change, or at least add a\n> possibility to change, the current layout of git-gui window.\n> [...]\n> \n> +-------------+----------------------------+---+\n> | | |###|\n> | | commit log |###|\n> | staged +----------------------------+---+\n> | | |\n> | | |\n> +----- 1 -----+ |\n> | | diff output |\n> | 2 |\n> | unstaged | |\n> | | |\n> | | |\n> +-------------+--------------------------------+\n\nMay I point you to\nhttp://repo.or.cz/w/git-gui.git?a=commitdiff;h=a0592d3f5746b41c60fee71dd8d2d27b5c813907\nwhich was committed 5 hours ago.\n\nExcept that it has Unstaged above Staged and Diff above Commit, which IMHO \nis much more natural.\n\n-- Hannes\n"},{"id":"55542","messageId":"470F52CA.3090308@users.sourceforge.net","threadId":"10256","inReplyTo":"470F45D6.6050106@viscovery.net","subject":"Re: [RFC] git-gui window layout","fromName":"Adam Piatyszek","fromEmail":"ediap@users.sourceforge.net","sentAt":"2007-10-12T10:56:10Z","receivedAt":"2007-10-12T10:56:10Z","isPatch":false,"sender":{"key":"ediap@users.sourceforge.net","avatar":null},"body":"* Johannes Sixt [2007-10-12 12:00]:\n> Adam Piatyszek schrieb:\n>> I would like you to comment on my idea to change, or at least add a\n>> possibility to change, the current layout of git-gui window.\n>> [...]\n>>\n>> +-------------+----------------------------+---+\n>> | | |###|\n>> | | commit log |###|\n>> | staged +----------------------------+---+\n>> | | |\n>> | | |\n>> +----- 1 -----+ |\n>> | | diff output |\n>> | 2 |\n>> | unstaged | |\n>> | | |\n>> | | |\n>> +-------------+--------------------------------+\n> \n> May I point you to\n> http://repo.or.cz/w/git-gui.git?a=commitdiff;h=a0592d3f5746b41c60fee71dd8d2d27b5c813907\n> \n> which was committed 5 hours ago.\n> \n> Except that it has Unstaged above Staged and Diff above Commit, which\n> IMHO is much more natural.\n\nThanks for the info! It seems that I was a bit late with my proposal. ;-)\n\n/Adam\n\n\n-- \n.:. Adam Piatyszek - \"ediap\" .:. JID: ediap(at)jabber.org .:.\n.:. ediap(at)users.sourceforge.net .:. PGP key ID: 0x1F115CCB .:.\n"}]}