{"thread":{"id":"10225","subject":"[PATCH] git-gui: add mingw specific startup wrapper","startedAt":"2007-10-10T05:56:47Z","lastAt":"2007-10-10T19:46:06Z","messageCount":11,"participants":["Steffen Prohaska","Shawn O. Pearce","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"55333","messageId":"11919958073204-git-send-email-prohaska@zib.de","threadId":"10225","inReplyTo":"20071010053728.GM2137@spearce.org","subject":"[PATCH] git-gui: add mingw specific startup wrapper","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T05:56:47Z","receivedAt":"2007-10-10T05:56:47Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"The wrapper adds the directory it is installed in to PATH.\nThis is required for the git commands implemented in shell.\ngit-gui fails to launch them if PATH is not modified.\n\nThe wrapper script also accepts an optional command line\nswitch '--working-dir <dir>' and changes to <dir> before\nlaunching the actual git-gui. This is required to implement\nthe \"Git Gui Here\" Explorer shell extension.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\n---\n git-gui/Makefile           |   14 ++++++++++++++\n git-gui/windows/git-gui.sh |   16 ++++++++++++++++\n 2 files changed, 30 insertions(+), 0 deletions(-)\n create mode 100644 git-gui/windows/git-gui.sh\n\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex c805450..8cf04d0 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -128,6 +128,7 @@ ifeq ($(uname_S),Darwin)\n endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_MSGFMT=1\n+\tGITGUI_WINDOWS_WRAPPER := YesPlease\n endif\n \n ifdef GITGUI_MACOSXAPP\n@@ -168,6 +169,13 @@ Git\\ Gui.app: GIT-VERSION-FILE GIT-GUI-VARS \\\n \tmv '$@'+ '$@'\n endif\n \n+ifdef GITGUI_WINDOWS_WRAPPER\n+GITGUI_MAIN := git-gui.tcl\n+\n+git-gui: windows/git-gui.sh\n+\tcp $< $@\n+endif\n+\n $(GITGUI_MAIN): git-gui.sh GIT-VERSION-FILE GIT-GUI-VARS\n \t$(QUIET_GEN)rm -f $@ $@+ && \\\n \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n@@ -233,6 +241,9 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS\n ifdef GITGUI_MACOSXAPP\n all:: git-gui Git\\ Gui.app\n endif\n+ifdef GITGUI_WINDOWS_WRAPPER\n+all:: git-gui\n+endif\n all:: $(GITGUI_MAIN) lib/tclIndex $(ALL_MSGFILES)\n \n install: all\n@@ -246,6 +257,9 @@ ifdef GITGUI_MACOSXAPP\n \t$(QUIET)$(INSTALL_A0)'Git Gui.app' $(INSTALL_A1) '$(DESTDIR_SQ)$(libdir_SQ)'\n \t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$(libdir_SQ)'\n endif\n+ifdef GITGUI_WINDOWS_WRAPPER\n+\t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$(libdir_SQ)'\n+endif\n \t$(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL_R0)$p $(INSTALL_R1) '$(DESTDIR_SQ)$(libdir_SQ)' &&) true\n \t$(QUIET)$(INSTALL_D0)'$(DESTDIR_SQ)$(msgsdir_SQ)' $(INSTALL_D1)\n \t$(QUIET)$(foreach p,$(ALL_MSGFILES), $(INSTALL_R0)$p $(INSTALL_R1) '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\ndiff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\nnew file mode 100644\nindex 0000000..98f32c0\n--- /dev/null\n+++ b/git-gui/windows/git-gui.sh\n@@ -0,0 +1,16 @@\n+#!/bin/sh\n+# Tcl ignores the next line -*- tcl -*- \\\n+exec wish \"$0\" -- \"$@\"\n+\n+if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n+\tcd [lindex $argv 1]\n+\tset argv [lrange $argv 2 end]\n+\tincr argc -2\n+}\n+\n+set gitguidir [file dirname [info script]]\n+regsub -all \";\" $gitguidir \"\\\\;\" gitguidir\n+set env(PATH) \"$gitguidir;$env(PATH)\"\n+unset gitguidir\n+\n+source [file join [file dirname [info script]] git-gui.tcl]\n-- \n1.5.3.mingw.1.105.gf0c04\n"},{"id":"55336","messageId":"20071010062218.GP2137@spearce.org","threadId":"10225","inReplyTo":"11919958073204-git-send-email-prohaska@zib.de","subject":"Re: [PATCH] git-gui: add mingw specific startup wrapper","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-10-10T06:22:18Z","receivedAt":"2007-10-10T06:22:18Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Steffen Prohaska <prohaska@zib.de> wrote:\n> The wrapper adds the directory it is installed in to PATH.\n> This is required for the git commands implemented in shell.\n> git-gui fails to launch them if PATH is not modified.\n> \n> The wrapper script also accepts an optional command line\n> switch '--working-dir <dir>' and changes to <dir> before\n> launching the actual git-gui. This is required to implement\n> the \"Git Gui Here\" Explorer shell extension.\n \nNice.\n\n> diff --git a/git-gui/Makefile b/git-gui/Makefile\n> @@ -128,6 +128,7 @@ ifeq ($(uname_S),Darwin)\n>  endif\n>  ifneq (,$(findstring MINGW,$(uname_S)))\n>  \tNO_MSGFMT=1\n> +\tGITGUI_WINDOWS_WRAPPER := YesPlease\n>  endif\n\nI don't have this context in my Makefile so I can't apply this\nadditional line here.  Can someone package up the patch that\nintroduces the MINGW case above with a proper commit message,\nso I can apply it in front of this patch?\n\n>  install: all\n> @@ -246,6 +257,9 @@ ifdef GITGUI_MACOSXAPP\n>  \t$(QUIET)$(INSTALL_A0)'Git Gui.app' $(INSTALL_A1) '$(DESTDIR_SQ)$(libdir_SQ)'\n>  \t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$(libdir_SQ)'\n>  endif\n> +ifdef GITGUI_WINDOWS_WRAPPER\n> +\t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$(libdir_SQ)'\n> +endif\n>  \t$(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL_R0)$p $(INSTALL_R1) '$(DESTDIR_SQ)$(libdir_SQ)' &&) true\n>  \t$(QUIET)$(INSTALL_D0)'$(DESTDIR_SQ)$(msgsdir_SQ)' $(INSTALL_D1)\n>  \t$(QUIET)$(foreach p,$(ALL_MSGFILES), $(INSTALL_R0)$p $(INSTALL_R1) '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n\nI think you missed the entry in the uninstall and clean targets.\n\n> diff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\n> @@ -0,0 +1,16 @@\n> +#!/bin/sh\n> +# Tcl ignores the next line -*- tcl -*- \\\n> +exec wish \"$0\" -- \"$@\"\n> +\n> +if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n> +\tcd [lindex $argv 1]\n> +\tset argv [lrange $argv 2 end]\n> +\tincr argc -2\n> +}\n\nMaybe we should just support this option directly in git-gui.\nToday we also support doing something like this by setting the\nGIT_DIR environment variable into a non-bare repository; see the\n\"# repository setup\" block of git-gui.sh.\n\n> +set gitguidir [file dirname [info script]]\n> +regsub -all \";\" $gitguidir \"\\\\;\" gitguidir\n> +set env(PATH) \"$gitguidir;$env(PATH)\"\n> +unset gitguidir\n> +\n> +source [file join [file dirname [info script]] git-gui.tcl]\n\nHmmph.  The install target was going into libdir but the above\nsource doesn't seem to read from there, its loading from the same\nlocation as the git-gui wrapper script.  You msys guys probably\ndon't have $(libdir) == $(gitexecdir), do you?\n\n-- \nShawn.\n"},{"id":"55337","messageId":"8F81028C-9924-4AA2-A58D-961AD10F5315@zib.de","threadId":"10225","inReplyTo":"20071010062218.GP2137@spearce.org","subject":"Re: [PATCH] git-gui: add mingw specific startup wrapper","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T06:55:28Z","receivedAt":"2007-10-10T06:55:28Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"\nOn Oct 10, 2007, at 8:22 AM, Shawn O. Pearce wrote:\n\n> Steffen Prohaska <prohaska@zib.de> wrote:\n>\n>> diff --git a/git-gui/Makefile b/git-gui/Makefile\n>> @@ -128,6 +128,7 @@ ifeq ($(uname_S),Darwin)\n>>  endif\n>>  ifneq (,$(findstring MINGW,$(uname_S)))\n>>  \tNO_MSGFMT=1\n>> +\tGITGUI_WINDOWS_WRAPPER := YesPlease\n>>  endif\n>\n> I don't have this context in my Makefile so I can't apply this\n> additional line here.  Can someone package up the patch that\n> introduces the MINGW case above with a proper commit message,\n> so I can apply it in front of this patch?\n>\n\nYou need the patch\n\"git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit\"\nthat I'll send in a follow-up mail. Apologies for forgetting about that.\n\n\n>>  install: all\n>> @@ -246,6 +257,9 @@ ifdef GITGUI_MACOSXAPP\n>>  \t$(QUIET)$(INSTALL_A0)'Git Gui.app' $(INSTALL_A1) '$(DESTDIR_SQ)$ \n>> (libdir_SQ)'\n>>  \t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$ \n>> (libdir_SQ)'\n>>  endif\n>> +ifdef GITGUI_WINDOWS_WRAPPER\n>> +\t$(QUIET)$(INSTALL_X0)git-gui.tcl $(INSTALL_X1) '$(DESTDIR_SQ)$ \n>> (libdir_SQ)'\n>> +endif\n>>  \t$(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL_R0)$p $ \n>> (INSTALL_R1) '$(DESTDIR_SQ)$(libdir_SQ)' &&) true\n>>  \t$(QUIET)$(INSTALL_D0)'$(DESTDIR_SQ)$(msgsdir_SQ)' $(INSTALL_D1)\n>>  \t$(QUIET)$(foreach p,$(ALL_MSGFILES), $(INSTALL_R0)$p $ \n>> (INSTALL_R1) '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n>\n> I think you missed the entry in the uninstall and clean targets.\n\nfixed.\n\n\n>> diff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\n>> @@ -0,0 +1,16 @@\n>> +#!/bin/sh\n>> +# Tcl ignores the next line -*- tcl -*- \\\n>> +exec wish \"$0\" -- \"$@\"\n>> +\n>> +if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n>> +\tcd [lindex $argv 1]\n>> +\tset argv [lrange $argv 2 end]\n>> +\tincr argc -2\n>> +}\n>\n> Maybe we should just support this option directly in git-gui.\n> Today we also support doing something like this by setting the\n> GIT_DIR environment variable into a non-bare repository; see the\n> \"# repository setup\" block of git-gui.sh.\n\nwould definitely be easier. It is an option that can be useful in  \ngeneral.\nI'll not take care of this right away.\n\n>> +set gitguidir [file dirname [info script]]\n>> +regsub -all \";\" $gitguidir \"\\\\;\" gitguidir\n>> +set env(PATH) \"$gitguidir;$env(PATH)\"\n>> +unset gitguidir\n>> +\n>> +source [file join [file dirname [info script]] git-gui.tcl]\n>\n> Hmmph.  The install target was going into libdir but the above\n> source doesn't seem to read from there, its loading from the same\n> location as the git-gui wrapper script.  You msys guys probably\n> don't have $(libdir) == $(gitexecdir), do you?\n\nThanks for spotting that. I decided to put git-gui.tcl into\n$(gitexecdir) with permissions 644.\n\nA series of two patches will follow.\n\n\tSteffen\n"},{"id":"55338","messageId":"11919995392158-git-send-email-prohaska@zib.de","threadId":"10225","inReplyTo":"8F81028C-9924-4AA2-A58D-961AD10F5315@zib.de","subject":"[PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T06:58:58Z","receivedAt":"2007-10-10T06:58:58Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"Shawn's git-gui Makefile supports the pure tcl replacement\nfor msgfmt if setting NO_MSGFMT. This patch sets the NO_MSGFMT\nfor msysgit.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\n---\n git-gui/Makefile |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex 818a0ab..c805450 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -126,6 +126,9 @@ ifeq ($(uname_S),Darwin)\n \t\tGITGUI_MACOSXAPP := YesPlease\n \tendif\n endif\n+ifneq (,$(findstring MINGW,$(uname_S)))\n+\tNO_MSGFMT=1\n+endif\n \n ifdef GITGUI_MACOSXAPP\n GITGUI_MAIN := git-gui.tcl\n-- \n1.5.3.mingw.1.105.gf0c04\n"},{"id":"55339","messageId":"11919995392881-git-send-email-prohaska@zib.de","threadId":"10225","inReplyTo":"11919995392158-git-send-email-prohaska@zib.de","subject":"[PATCH v2] git-gui: add mingw specific startup wrapper","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T06:58:59Z","receivedAt":"2007-10-10T06:58:59Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"The wrapper adds the directory it is installed in to PATH.\nThis is required for the git commands implemented in shell.\ngit-gui fails to launch them if PATH is not modified.\n\nThe wrapper script also accepts an optional command line\nswitch '--working-dir <dir>' and changes to <dir> before\nlaunching the actual git-gui. This is required to implement\nthe \"Git Gui Here\" Explorer shell extension.\n\nAs a last step the original git-gui script is launched,\nwhich is expected to be located in the same directory\nunder the name git-gui.tcl.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\n---\n git-gui/Makefile           |   20 ++++++++++++++++++++\n git-gui/windows/git-gui.sh |   16 ++++++++++++++++\n 2 files changed, 36 insertions(+), 0 deletions(-)\n create mode 100644 git-gui/windows/git-gui.sh\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex c805450..2ad8846 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -128,6 +128,7 @@ ifeq ($(uname_S),Darwin)\n endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_MSGFMT=1\n+\tGITGUI_WINDOWS_WRAPPER := YesPlease\n endif\n \n ifdef GITGUI_MACOSXAPP\n@@ -168,6 +169,13 @@ Git\\ Gui.app: GIT-VERSION-FILE GIT-GUI-VARS \\\n \tmv '$@'+ '$@'\n endif\n \n+ifdef GITGUI_WINDOWS_WRAPPER\n+GITGUI_MAIN := git-gui.tcl\n+\n+git-gui: windows/git-gui.sh\n+\tcp $< $@\n+endif\n+\n $(GITGUI_MAIN): git-gui.sh GIT-VERSION-FILE GIT-GUI-VARS\n \t$(QUIET_GEN)rm -f $@ $@+ && \\\n \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n@@ -233,12 +241,18 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS\n ifdef GITGUI_MACOSXAPP\n all:: git-gui Git\\ Gui.app\n endif\n+ifdef GITGUI_WINDOWS_WRAPPER\n+all:: git-gui\n+endif\n all:: $(GITGUI_MAIN) lib/tclIndex $(ALL_MSGFILES)\n \n install: all\n \t$(QUIET)$(INSTALL_D0)'$(DESTDIR_SQ)$(gitexecdir_SQ)' $(INSTALL_D1)\n \t$(QUIET)$(INSTALL_X0)git-gui $(INSTALL_X1) '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n \t$(QUIET)$(foreach p,$(GITGUI_BUILT_INS), $(INSTALL_L0)'$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' $(INSTALL_L1)'$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' $(INSTALL_L2)'$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' $(INSTALL_L3) &&) true\n+ifdef GITGUI_WINDOWS_WRAPPER\n+\t$(QUIET)$(INSTALL_R0)git-gui.tcl $(INSTALL_R1) '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+endif\n \t$(QUIET)$(INSTALL_D0)'$(DESTDIR_SQ)$(libdir_SQ)' $(INSTALL_D1)\n \t$(QUIET)$(INSTALL_R0)lib/tclIndex $(INSTALL_R1) '$(DESTDIR_SQ)$(libdir_SQ)'\n \t$(QUIET)$(INSTALL_R0)lib/git-gui.ico $(INSTALL_R1) '$(DESTDIR_SQ)$(libdir_SQ)'\n@@ -254,6 +268,9 @@ uninstall:\n \t$(QUIET)$(CLEAN_DST) '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n \t$(QUIET)$(REMOVE_F0)'$(DESTDIR_SQ)$(gitexecdir_SQ)'/git-gui $(REMOVE_F1)\n \t$(QUIET)$(foreach p,$(GITGUI_BUILT_INS), $(REMOVE_F0)'$(DESTDIR_SQ)$(gitexecdir_SQ)'/$p $(REMOVE_F1) &&) true\n+ifdef GITGUI_WINDOWS_WRAPPER\n+\t$(QUIET)$(REMOVE_F0)'$(DESTDIR_SQ)$(gitexecdir_SQ)'/git-gui.tcl $(REMOVE_F1)\n+endif\n \t$(QUIET)$(CLEAN_DST) '$(DESTDIR_SQ)$(libdir_SQ)'\n \t$(QUIET)$(REMOVE_F0)'$(DESTDIR_SQ)$(libdir_SQ)'/tclIndex $(REMOVE_F1)\n \t$(QUIET)$(REMOVE_F0)'$(DESTDIR_SQ)$(libdir_SQ)'/git-gui.ico $(REMOVE_F1)\n@@ -279,6 +296,9 @@ clean::\n ifdef GITGUI_MACOSXAPP\n \t$(RM_RF) 'Git Gui.app'* git-gui\n endif\n+ifdef GITGUI_WINDOWS_WRAPPER\n+\t$(RM_RF) git-gui\n+endif\n \n .PHONY: all install uninstall dist-version clean\n .PHONY: .FORCE-GIT-VERSION-FILE\ndiff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\nnew file mode 100644\nindex 0000000..98f32c0\n--- /dev/null\n+++ b/git-gui/windows/git-gui.sh\n@@ -0,0 +1,16 @@\n+#!/bin/sh\n+# Tcl ignores the next line -*- tcl -*- \\\n+exec wish \"$0\" -- \"$@\"\n+\n+if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n+\tcd [lindex $argv 1]\n+\tset argv [lrange $argv 2 end]\n+\tincr argc -2\n+}\n+\n+set gitguidir [file dirname [info script]]\n+regsub -all \";\" $gitguidir \"\\\\;\" gitguidir\n+set env(PATH) \"$gitguidir;$env(PATH)\"\n+unset gitguidir\n+\n+source [file join [file dirname [info script]] git-gui.tcl]\n-- \n1.5.3.mingw.1.105.gf0c04\n"},{"id":"55346","messageId":"20071010080256.GR2137@spearce.org","threadId":"10225","inReplyTo":"11919995392881-git-send-email-prohaska@zib.de","subject":"Re: [PATCH v2] git-gui: add mingw specific startup wrapper","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-10-10T08:02:56Z","receivedAt":"2007-10-10T08:02:56Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Steffen Prohaska <prohaska@zib.de> wrote:\n> The wrapper adds the directory it is installed in to PATH.\n> This is required for the git commands implemented in shell.\n> git-gui fails to launch them if PATH is not modified.\n\nThanks, I have both of these applied now to master and will push\nit out shortly, along with the mingw version fix you had sent\nme much earlier.\n \n> +if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n> +\tcd [lindex $argv 1]\n> +\tset argv [lrange $argv 2 end]\n> +\tincr argc -2\n> +}\n\nPerhaps someday in the future we'll put this into git-gui.sh so\nall platforms can use it.  Today, its Windows only.  ;-)\n\n-- \nShawn.\n"},{"id":"55382","messageId":"Pine.LNX.4.64.0710101651360.4174@racer.site","threadId":"10225","inReplyTo":"11919995392158-git-send-email-prohaska@zib.de","subject":"Re: [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-10T15:52:01Z","receivedAt":"2007-10-10T15:52:01Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 10 Oct 2007, Steffen Prohaska wrote:\n\n> Shawn's git-gui Makefile supports the pure tcl replacement for msgfmt if \n> setting NO_MSGFMT. This patch sets the NO_MSGFMT for msysgit.\n\nWould it not be cleaner to set this in 4msysgit and export it?\n\nCiao,\nDscho\n"},{"id":"55383","messageId":"Pine.LNX.4.64.0710101653400.4174@racer.site","threadId":"10225","inReplyTo":"11919995392881-git-send-email-prohaska@zib.de","subject":"Re: [PATCH v2] git-gui: add mingw specific startup wrapper","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-10T15:56:20Z","receivedAt":"2007-10-10T15:56:20Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 10 Oct 2007, Steffen Prohaska wrote:\n\n> The wrapper adds the directory it is installed in to PATH.\n> This is required for the git commands implemented in shell.\n> git-gui fails to launch them if PATH is not modified.\n> \n> The wrapper script also accepts an optional command line\n> switch '--working-dir <dir>' and changes to <dir> before\n> launching the actual git-gui. This is required to implement\n> the \"Git Gui Here\" Explorer shell extension.\n\nIt should be mentioned here that the Explorer shell extension you talk \nabout is the very simple extension provided by the Inno Installer.\n\nI have a much larger and versatile shell extension in mind: git-cheetah.  \nAnd fixing it is probably trivial; it can both change directory to the \ncurrent directory (sounds wrong, doesn't it?) and extend the PATH \nappropriately before calling git-gui.\n\nNote: the latter is not even necessary once we (correctly) add git to the \nPATH in the installer.\n\nCiao,\nDscho\n"},{"id":"55384","messageId":"CC4EB4CA-3BA0-4C00-8B23-31B09032CC69@zib.de","threadId":"10225","inReplyTo":"Pine.LNX.4.64.0710101651360.4174@racer.site","subject":"Re: [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T15:58:49Z","receivedAt":"2007-10-10T15:58:49Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"\nOn Oct 10, 2007, at 5:52 PM, Johannes Schindelin wrote:\n\n> On Wed, 10 Oct 2007, Steffen Prohaska wrote:\n>\n>> Shawn's git-gui Makefile supports the pure tcl replacement for  \n>> msgfmt if\n>> setting NO_MSGFMT. This patch sets the NO_MSGFMT for msysgit.\n>\n> Would it not be cleaner to set this in 4msysgit and export it?\n\nWhat does \"set this in 4msysgit\" mean?\n\nWould running 'make' in /git/git-gui/ be supported by your solution?\n\n\tSteffen\n"},{"id":"55386","messageId":"BBE6D747-4CD2-4D10-914B-F3149A8591E4@zib.de","threadId":"10225","inReplyTo":"Pine.LNX.4.64.0710101653400.4174@racer.site","subject":"Re: [PATCH v2] git-gui: add mingw specific startup wrapper","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-10-10T16:10:21Z","receivedAt":"2007-10-10T16:10:21Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"\nOn Oct 10, 2007, at 5:56 PM, Johannes Schindelin wrote:\n\n> On Wed, 10 Oct 2007, Steffen Prohaska wrote:\n>\n>> The wrapper adds the directory it is installed in to PATH.\n>> This is required for the git commands implemented in shell.\n>> git-gui fails to launch them if PATH is not modified.\n>>\n>> The wrapper script also accepts an optional command line\n>> switch '--working-dir <dir>' and changes to <dir> before\n>> launching the actual git-gui. This is required to implement\n>> the \"Git Gui Here\" Explorer shell extension.\n>\n> It should be mentioned here that the Explorer shell extension you talk\n> about is the very simple extension provided by the Inno Installer.\n\nYes, but it's already there. And Shawn even finds --working-dir  \ninteresting\nas a general feature.\n\n\n> I have a much larger and versatile shell extension in mind: git- \n> cheetah.\n> And fixing it is probably trivial; it can both change directory to the\n> current directory (sounds wrong, doesn't it?) and extend the PATH\n> appropriately before calling git-gui.\n\nI know, but it's not yet there.\n\n\n> Note: the latter is not even necessary once we (correctly) add git  \n> to the\n> PATH in the installer.\n\n(wrongly ;) Adding git to the PATH will only become an option. git-gui\nshould also work if it's not added.\n\nI comment on the PATH question in reply to another mail.\n\n\tSteffen\n"},{"id":"55404","messageId":"Pine.LNX.4.64.0710102044220.4174@racer.site","threadId":"10225","inReplyTo":"CC4EB4CA-3BA0-4C00-8B23-31B09032CC69@zib.de","subject":"Re: [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-10T19:46:06Z","receivedAt":"2007-10-10T19:46:06Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 10 Oct 2007, Steffen Prohaska wrote:\n\n> On Oct 10, 2007, at 5:52 PM, Johannes Schindelin wrote:\n> \n> > On Wed, 10 Oct 2007, Steffen Prohaska wrote:\n> > \n> > > Shawn's git-gui Makefile supports the pure tcl replacement for \n> > > msgfmt if setting NO_MSGFMT. This patch sets the NO_MSGFMT for \n> > > msysgit.\n> > \n> > Would it not be cleaner to set this in 4msysgit and export it?\n> \n> What does \"set this in 4msysgit\" mean?\n\nIt means what you probably assumed, that we change the Makefile in /git.\n\n> Would running 'make' in /git/git-gui/ be supported by your solution?\n\nNo, not really.  Just like \"make\" in /git/t/ does not pick up on the \nNO_SYMLINKS option.\n\nCiao,\nDscho\n"}]}