{"thread":{"id":"10162","subject":"[PATCH] git-config: don't silently ignore options after --list","startedAt":"2007-10-05T20:16:44Z","lastAt":"2007-10-05T20:16:44Z","messageCount":1,"participants":["Frank Lichtenheld"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"54995","messageId":"1191615404-32244-1-git-send-email-frank@lichtenheld.de","threadId":"10162","inReplyTo":null,"subject":"[PATCH] git-config: don't silently ignore options after --list","fromName":"Frank Lichtenheld","fromEmail":"frank@lichtenheld.de","sentAt":"2007-10-05T20:16:44Z","receivedAt":"2007-10-05T20:16:44Z","isPatch":true,"sender":{"key":"frank@lichtenheld.de","avatar":"https://gravatar.com/avatar/b9f1d4b120e138f157c9e480d0818197c474628923786adb98f30017cdb99c3c?d=mp&s=160"},"body":"Error out if someone gives options after --list since that is\nnot a valid syntax.\n\nSigned-off-by: Frank Lichtenheld <frank@lichtenheld.de>\n---\n builtin-config.c |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\n Two minutes of my life I don't get back ;)\n\ndiff --git a/builtin-config.c b/builtin-config.c\nindex 0a605e0..cb7e9e9 100644\n--- a/builtin-config.c\n+++ b/builtin-config.c\n@@ -172,8 +172,11 @@ int cmd_config(int argc, const char **argv, const char *prefix)\n \t\t\ttype = T_INT;\n \t\telse if (!strcmp(argv[1], \"--bool\"))\n \t\t\ttype = T_BOOL;\n-\t\telse if (!strcmp(argv[1], \"--list\") || !strcmp(argv[1], \"-l\"))\n+\t\telse if (!strcmp(argv[1], \"--list\") || !strcmp(argv[1], \"-l\")) {\n+\t\t\tif (argc != 2)\n+\t\t\t\tusage(git_config_set_usage);\n \t\t\treturn git_config(show_all_config);\n+\t\t}\n \t\telse if (!strcmp(argv[1], \"--global\")) {\n \t\t\tchar *home = getenv(\"HOME\");\n \t\t\tif (home) {\n-- \n1.5.3.4\n"}]}