{"thread":{"id":"10154","subject":"Correction for post-receive-email","startedAt":"2007-10-05T07:14:14Z","lastAt":"2007-10-05T14:29:43Z","messageCount":5,"participants":["Eric Mertens","Andy Parkins","Andreas Ericsson","Bill Lear"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"54910","messageId":"449c8cfc0710050014j9bbf057ka108ee27dea49a89@mail.gmail.com","threadId":"10154","inReplyTo":null,"subject":"Correction for post-receive-email","fromName":"Eric Mertens","fromEmail":"emertens@gmail.com","sentAt":"2007-10-05T07:14:14Z","receivedAt":"2007-10-05T07:14:14Z","isPatch":false,"sender":{"key":"emertens@gmail.com","avatar":null},"body":"Hello,\n\n(My apologies if my incorrectly addressed subscribe message went to the list)\n\nI noticed that my mutt wasn't correctly detecting the signature block\non the end of the automated emails I was receiving from the script in\ncontrib. I've made this trivial change in my local copy of the script,\nbut I figured that if I was going to be modifying the source code I\nshould share my changes.\n\n-- \nEric Mertens\n\n\nFrom 119f84fa6f6bb33c6fc524ab4277d38bebc10468 Mon Sep 17 00:00:00 2001\nFrom: Eric Mertens \nDate: Fri, 5 Oct 2007 00:06:52 -0700\nSubject: [PATCH] Correct signature block delimiter in post-receive-email by adding a trailing space\n\nThis change allows mail clients like Mutt to easily detect the signature\nand is consistent with the signature block article on Wikipedia.\n---\n contrib/hooks/post-receive-email | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex cbbd02f..828651a 100644\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -198,7 +198,7 @@ generate_email_footer()\n \n \n \thooks/post-receive\n-\t--\n+\t-- \n \t$projectdesc\n \tEOF\n }\n-- \n1.5.3.4\n\n"},{"id":"54914","messageId":"200710050913.58835.andyparkins@gmail.com","threadId":"10154","inReplyTo":"449c8cfc0710050014j9bbf057ka108ee27dea49a89@mail.gmail.com","subject":"Re: Correction for post-receive-email","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-10-05T08:13:57Z","receivedAt":"2007-10-05T08:13:57Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Friday 2007 October 05, Eric Mertens wrote:\n\n> I noticed that my mutt wasn't correctly detecting the signature block\n> on the end of the automated emails I was receiving from the script in\n> contrib. I've made this trivial change in my local copy of the script,\n> but I figured that if I was going to be modifying the source code I\n> should share my changes.\n\nThat change has been in my pending queue for a while. It's technically \ncorrect, but I've never submitted it. The reason I haven't is that it adds \ntrailing whitespace.\n\nPerhaps one of the shell gurus can offer a nicer way of having a trailing \nspace be output in a heredoc that doesn't add a trailing space in the source \nscript?\n\n\nAndy\n\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"},{"id":"54924","messageId":"4705FBAA.50302@op5.se","threadId":"10154","inReplyTo":"200710050913.58835.andyparkins@gmail.com","subject":"Re: Correction for post-receive-email","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2007-10-05T08:54:02Z","receivedAt":"2007-10-05T08:54:02Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Andy Parkins wrote:\n> On Friday 2007 October 05, Eric Mertens wrote:\n> \n>> I noticed that my mutt wasn't correctly detecting the signature block\n>> on the end of the automated emails I was receiving from the script in\n>> contrib. I've made this trivial change in my local copy of the script,\n>> but I figured that if I was going to be modifying the source code I\n>> should share my changes.\n> \n> That change has been in my pending queue for a while. It's technically \n> correct, but I've never submitted it. The reason I haven't is that it adds \n> trailing whitespace.\n> \n> Perhaps one of the shell gurus can offer a nicer way of having a trailing \n> space be output in a heredoc that doesn't add a trailing space in the source \n> script?\n> \n\nspace=' '\n\ncat << EOF\n--$space\nEOF\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"54947","messageId":"18182.12163.311826.242309@lisa.zopyra.com","threadId":"10154","inReplyTo":"200710050913.58835.andyparkins@gmail.com","subject":"Re: Correction for post-receive-email","fromName":"Bill Lear","fromEmail":"rael@zopyra.com","sentAt":"2007-10-05T12:35:15Z","receivedAt":"2007-10-05T12:35:15Z","isPatch":false,"sender":{"key":"rael@zopyra.com","avatar":"https://gravatar.com/avatar/c4f2d2790ca3828d3b4e7dfebabf61d2fe94fd82fa49cdac2a5295dd2d46a874?d=mp&s=160"},"body":"On Friday, October 5, 2007 at 09:13:57 (+0100) Andy Parkins writes:\n>On Friday 2007 October 05, Eric Mertens wrote:\n>\n>> I noticed that my mutt wasn't correctly detecting the signature block\n>> on the end of the automated emails I was receiving from the script in\n>> contrib. I've made this trivial change in my local copy of the script,\n>> but I figured that if I was going to be modifying the source code I\n>> should share my changes.\n>\n>That change has been in my pending queue for a while. It's technically \n>correct, but I've never submitted it. The reason I haven't is that it adds \n>trailing whitespace.\n>\n>Perhaps one of the shell gurus can offer a nicer way of having a trailing \n>space be output in a heredoc that doesn't add a trailing space in the source \n>script?\n\nI have a few changes I would like to see in this script, ones that I think\nwould make it generally more useful. I don't have a clean patch, though,\nso should I just submit suggestions to you directly, Andy?\n\n\nBill\n"},{"id":"54954","messageId":"200710051529.45440.andyparkins@gmail.com","threadId":"10154","inReplyTo":"18182.12163.311826.242309@lisa.zopyra.com","subject":"Re: Correction for post-receive-email","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-10-05T14:29:43Z","receivedAt":"2007-10-05T14:29:43Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Friday 2007 October 05, Bill Lear wrote:\n\n> I have a few changes I would like to see in this script, ones that I think\n> would make it generally more useful. I don't have a clean patch, though,\n> so should I just submit suggestions to you directly, Andy?\n\nMe; or the list. Or both.\n\nI'm happy to try to accommodate any suggestions. I'm happy if it is useful to \nanyone other than just me :-)\n\n\n--- SNIP THIS BIT IF YOU'RE NOT INTERESTED IN ITS BUGS ---\nThe big fault in it as it stands is that it doesn't try to reorder the refs \nbeing updated to the most logical form. For example:\n\n O --- * --- A (ref2)\n \\\n B (ref1)\n\nLet's say that both ref1 and ref2 were originally at O and this push has moved \nthem to these new locations. The email hook gets sent this information like \nthis:\n\n refs/heads/ref1 O B\n refs/heads/ref2 O A\n\nThe hook iterates through this list, for each ref update it shows only the \ncommits introduced by the change that aren't already included in an existing \nref. This is the problem, ref2 introduced \"*\" and \"A\" and ref1 \nintroduced \"B\", ideally then the two emails would show\n\n ref2 updated from O to A\n new revs: *, A\n ref1 updated from O to B\n new revs: B\n\nBut because ref1 is alphabetically before ref1, what you get is:\n\n ref1 updated from O to B\n new revs: *, A, B\n ref2 updated from O to A\n new revs: \n\nI can't say I know what the answer is; nor even what the correct output should \nbe. If anyone has opinions on this, I'll be glad to hear them.\n\n\nAndy\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"}]}