{"thread":{"id":"10134","subject":"stgit: editing description of patch","startedAt":"2007-10-03T23:26:20Z","lastAt":"2007-10-05T09:16:17Z","messageCount":8,"participants":["Jon Smirl","Karl Hasselström","Catalin Marinas"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"54780","messageId":"9e4733910710031626kff59666y77ba9001c0fef907@mail.gmail.com","threadId":"10134","inReplyTo":null,"subject":"stgit: editing description of patch","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-10-03T23:26:20Z","receivedAt":"2007-10-03T23:26:20Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"What is the right procedure for editing the various attributes of a\nstgit patch? patch name, description, etc.... I just emailed a series\nto myself and the titles/comments are all messed up.\n\nOn my box all of the patches have names -- stg series shows them. But\nwhen I emailed them half of the patch didn't have the right subjects.\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"54787","messageId":"9e4733910710031914r766efa88pad9f55f9495d127e@mail.gmail.com","threadId":"10134","inReplyTo":"9e4733910710031626kff59666y77ba9001c0fef907@mail.gmail.com","subject":"Re: stgit: editing description of patch","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-10-04T02:14:20Z","receivedAt":"2007-10-04T02:14:20Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 10/3/07, Jon Smirl wrote:\n> What is the right procedure for editing the various attributes of a\n> stgit patch? patch name, description, etc.... I just emailed a series\n> to myself and the titles/comments are all messed up.\n\nEditing these is done with the stg refresh command.\n\n>\n> On my box all of the patches have names -- stg series shows them. But\n> when I emailed them half of the patch didn't have the right subjects.\n\nthis is controled in the template files\n\n>\n> --\n> Jon Smirl\n> jonsmirl@gmail.com\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"54799","messageId":"20071004082624.GA17778@diana.vm.bytemark.co.uk","threadId":"10134","inReplyTo":"9e4733910710031914r766efa88pad9f55f9495d127e@mail.gmail.com","subject":"Re: stgit: editing description of patch","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-04T08:26:24Z","receivedAt":"2007-10-04T08:26:24Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-10-03 22:14:20 -0400, Jon Smirl wrote:\n\n> On 10/3/07, Jon Smirl wrote:\n>\n> > What is the right procedure for editing the various attributes of\n> > a stgit patch? patch name, description, etc.... I just emailed a\n> > series to myself and the titles/comments are all messed up.\n>\n> Editing these is done with the stg refresh command.\n\nThis is \"stg edit\" in really new StGits.\n\n> > On my box all of the patches have names -- stg series shows them.\n> > But when I emailed them half of the patch didn't have the right\n> > subjects.\n>\n> this is controled in the template files\n\nAnything here you'd characterize as a bug?\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"54821","messageId":"9e4733910710040616l5358099dj1b65b47cf94cf031@mail.gmail.com","threadId":"10134","inReplyTo":"20071004082624.GA17778@diana.vm.bytemark.co.uk","subject":"Re: stgit: editing description of patch","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-10-04T13:16:46Z","receivedAt":"2007-10-04T13:16:46Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 10/4/07, Karl Hasselström wrote:\n> > > On my box all of the patches have names -- stg series shows them.\n> > > But when I emailed them half of the patch didn't have the right\n> > > subjects.\n> >\n> > this is controled in the template files\n>\n> Anything here you'd characterize as a bug?\n\nNo, not after I have learned more about stg. The missing subjects were\nfrom other patches I had imported from emails. They has all of the\nemail headers on them. Once I edited those out the subjects appeared\nok. 'stg edit' should help with this, it was non-obvious to use 'stg\nrefresh' to edit the patch descriptions.\n\nWhy is mailing a patch series so slow?\n\nThere also seems to be a disconnect when mailing patches. Locally the\npatches have a name, when you email them it uses the short description\nfor the name by default instead of the local name. This may cause\nconfusion because the emailed name does not default to the local name.\nA parallel issue happens on import.\n\nNow that I am aware of the naming scheme I can deal with it, but this\nmay be a problem for new users. It might be better to force the short\ndescription and local name to always match.\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"54839","messageId":"20071004154836.GB21717@diana.vm.bytemark.co.uk","threadId":"10134","inReplyTo":"9e4733910710040616l5358099dj1b65b47cf94cf031@mail.gmail.com","subject":"Re: stgit: editing description of patch","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-04T15:48:36Z","receivedAt":"2007-10-04T15:48:36Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-10-04 09:16:46 -0400, Jon Smirl wrote:\n\n> Why is mailing a patch series so slow?\n\nBecause the default per-patch delay is 5 seconds. You can change it by\nsetting stgit.smtpdelay in your config, or passing --sleep on the\ncommand line.\n\n> There also seems to be a disconnect when mailing patches. Locally\n> the patches have a name, when you email them it uses the short\n> description for the name by default instead of the local name. This\n> may cause confusion because the emailed name does not default to the\n> local name. A parallel issue happens on import.\n>\n> Now that I am aware of the naming scheme I can deal with it, but\n> this may be a problem for new users. It might be better to force the\n> short description and local name to always match.\n\nI've never thought of the patch names as anything that would make\nsense to export from a repository (like reflogs), so using the first\nline of the commit message for mail subject (like git does) always\nseemed like a no-brainer. But then I don't have any experience using\nquilt or any related tool.\n\nThe default when creating a new patch is to make up a name from its\ncommit message (the user is free to give a name explicitly, however);\nthe same goes when you import a patch mbox. But when importing a patch\nseries (with \"stg import --series\"), I see the names are taken from\nthe series file you import. Maybe that should change, at least\noptionally.\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"54854","messageId":"9e4733910710040945l2335f3d7le6f45510640d3a6e@mail.gmail.com","threadId":"10134","inReplyTo":"20071004154836.GB21717@diana.vm.bytemark.co.uk","subject":"Re: stgit: editing description of patch","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-10-04T16:45:17Z","receivedAt":"2007-10-04T16:45:17Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 10/4/07, Karl Hasselström wrote:\n> I've never thought of the patch names as anything that would make\n> sense to export from a repository (like reflogs), so using the first\n> line of the commit message for mail subject (like git does) always\n> seemed like a no-brainer. But then I don't have any experience using\n> quilt or any related tool.\n\nWhy are the patch name and the short description independent\nvariables? Wouldn't it make more sense to treat these as a single\nunified item? If I rename the patch it would automatically edit the\nfirst line of the description, etc...\n\nWhen importing a patch from a saved email, stg should strip all the\nemail headers out of the description. I have to manually fix that up.\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"54859","messageId":"20071004173929.GD21717@diana.vm.bytemark.co.uk","threadId":"10134","inReplyTo":"9e4733910710040945l2335f3d7le6f45510640d3a6e@mail.gmail.com","subject":"Re: stgit: editing description of patch","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-10-04T17:39:29Z","receivedAt":"2007-10-04T17:39:29Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-10-04 12:45:17 -0400, Jon Smirl wrote:\n\n> On 10/4/07, Karl Hasselström wrote:\n>\n> > I've never thought of the patch names as anything that would make\n> > sense to export from a repository (like reflogs), so using the\n> > first line of the commit message for mail subject (like git does)\n> > always seemed like a no-brainer. But then I don't have any\n> > experience using quilt or any related tool.\n>\n> Why are the patch name and the short description independent\n> variables? Wouldn't it make more sense to treat these as a single\n> unified item? If I rename the patch it would automatically edit the\n> first line of the description, etc...\n\nI guess Catalin would have to answer that -- it's \"always\" been like\nthat. But one obvious problem are patches with identical messages --\njust today I created a series of seven patches that all had \"debug\"\nfor a message. Another is that you usually want descriptive commit\nmessages, but may want short and easy-to-type patch names.\n\n> When importing a patch from a saved email, stg should strip all the\n> email headers out of the description. I have to manually fix that\n> up.\n\nDo you do \"stg import -M\"? That's for importing one or more patches\ncontained in an mbox. Without the -M, I think the default is to expect\nplain diff input.\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"54929","messageId":"fe4vd1$4s2$1@sea.gmane.org","threadId":"10134","inReplyTo":"20071004173929.GD21717@diana.vm.bytemark.co.uk","subject":"Re: stgit: editing description of patch","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2007-10-05T09:16:17Z","receivedAt":"2007-10-05T09:16:17Z","isPatch":false,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"(for whatever reason, gnus decided that it no longer likes the\nauthenticated SMTP server, so I'm trying to post via gmane).\n\nOn Thu, 04 Oct 2007 19:39:29 +0200, Karl Hasselström wrote:\n\n> On 2007-10-04 12:45:17 -0400, Jon Smirl wrote:\n> \n>> Why are the patch name and the short description independent\n>> variables? Wouldn't it make more sense to treat these as a single\n>> unified item? If I rename the patch it would automatically edit the\n>> first line of the description, etc...\n> \n> I guess Catalin would have to answer that -- it's \"always\" been like\n> that. But one obvious problem are patches with identical messages --\n> just today I created a series of seven patches that all had \"debug\"\n> for a message. Another is that you usually want descriptive commit\n> messages, but may want short and easy-to-type patch names.\n\nThat's pretty much the case. There are also the historical reasons (quilt\ndoes the same) plus the fact the exporting should really generate shorter\nand simpler file names rather than name with capitals and spaces. I've\nalso seen people writing a single paragraph over several lines without a\nshort description. You wouldn't really want a patch name that long.\n\nAnyway, 'stg series -d' would show the patch name together with the short\ndescription.\n\n>> When importing a patch from a saved email, stg should strip all the\n>> email headers out of the description. I have to manually fix that\n>> up.\n> \n> Do you do \"stg import -M\"? That's for importing one or more patches\n> contained in an mbox. Without the -M, I think the default is to expect\n> plain diff input.\n\nThere is also 'stg import -m' for single e-mails rather than mbox. StGIT\nshould be able to cope with attachments as well.\n\nCatalin\n"}]}