{"thread":{"id":"10123","subject":"[PATCH] Restore default verbosity for http fetches.","startedAt":"2007-10-03T02:49:15Z","lastAt":"2007-10-03T02:49:15Z","messageCount":1,"participants":["Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"54641","messageId":"Pine.LNX.4.64.0710022248160.9321@iabervon.org","threadId":"10123","inReplyTo":null,"subject":"[PATCH] Restore default verbosity for http fetches.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2007-10-03T02:49:15Z","receivedAt":"2007-10-03T02:49:15Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"This adds a verbosity level below 0 for suppressing default messages\nwith --quiet, and makes the default for http be verbose instead of\nquiet. This matches the behavior of the shell script version of git-fetch.\n\nSigned-off-by: Daniel Barkalow <barkalow@iabervon.org>\n---\n builtin-fetch.c |    2 +-\n transport.c     |   10 +++++-----\n transport.h     |    2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/builtin-fetch.c b/builtin-fetch.c\nindex ac68ff5..cf7498b 100644\n--- a/builtin-fetch.c\n+++ b/builtin-fetch.c\n@@ -533,7 +533,7 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)\n \tif (verbose >= 2)\n \t\ttransport->verbose = 1;\n \tif (quiet)\n-\t\ttransport->verbose = 0;\n+\t\ttransport->verbose = -1;\n \tif (upload_pack)\n \t\tset_option(TRANS_OPT_UPLOADPACK, upload_pack);\n \tif (keep)\ndiff --git a/transport.c b/transport.c\nindex 7266fd3..6fe6ec8 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -161,7 +161,7 @@ static struct ref *get_refs_via_rsync(const struct transport *transport)\n \trsync.argv = args;\n \trsync.stdout_to_stderr = 1;\n \targs[0] = \"rsync\";\n-\targs[1] = transport->verbose ? \"-rv\" : \"-r\";\n+\targs[1] = (transport->verbose > 0) ? \"-rv\" : \"-r\";\n \targs[2] = buf.buf;\n \targs[3] = temp_dir.buf;\n \targs[4] = NULL;\n@@ -214,7 +214,7 @@ static int fetch_objs_via_rsync(struct transport *transport,\n \trsync.argv = args;\n \trsync.stdout_to_stderr = 1;\n \targs[0] = \"rsync\";\n-\targs[1] = transport->verbose ? \"-rv\" : \"-r\";\n+\targs[1] = (transport->verbose > 0) ? \"-rv\" : \"-r\";\n \targs[2] = \"--ignore-existing\";\n \targs[3] = \"--exclude\";\n \targs[4] = \"info\";\n@@ -290,7 +290,7 @@ static int rsync_transport_push(struct transport *transport,\n \trsync.argv = args;\n \trsync.stdout_to_stderr = 1;\n \targs[0] = \"rsync\";\n-\targs[1] = transport->verbose ? \"-av\" : \"-a\";\n+\targs[1] = (transport->verbose > 0) ? \"-av\" : \"-a\";\n \targs[2] = \"--ignore-existing\";\n \targs[3] = \"--exclude\";\n \targs[4] = \"info\";\n@@ -344,7 +344,7 @@ static int fetch_objs_via_walker(struct transport *transport,\n \twalker->get_all = 1;\n \twalker->get_tree = 1;\n \twalker->get_history = 1;\n-\twalker->get_verbosely = transport->verbose;\n+\twalker->get_verbosely = transport->verbose >= 0;\n \twalker->get_recover = 0;\n \n \tfor (i = 0; i < nr_objs; i++)\n@@ -637,7 +637,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n \targs.keep_pack = data->keep;\n \targs.lock_pack = 1;\n \targs.use_thin_pack = data->thin;\n-\targs.verbose = transport->verbose;\n+\targs.verbose = transport->verbose > 0;\n \targs.depth = data->depth;\n \n \tfor (i = 0; i < nr_heads; i++)\ndiff --git a/transport.h b/transport.h\nindex 6e318e4..4bb51d7 100644\n--- a/transport.h\n+++ b/transport.h\n@@ -24,7 +24,7 @@ struct transport {\n \n \tint (*disconnect)(struct transport *connection);\n \tchar *pack_lockfile;\n-\tunsigned verbose : 1;\n+\tsigned verbose : 2;\n };\n \n #define TRANSPORT_PUSH_ALL 1\n-- \n1.5.3.2.1107.ge9eab8-dirty\n"}]}