{"thread":{"id":"10053","subject":"[PATCH] gitview: revamped to use string.join, stripped a function def","startedAt":"2007-09-27T19:55:17Z","lastAt":"2007-11-21T06:50:37Z","messageCount":4,"participants":["Denis Cheng","rae l","Vineet Kumar","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"54195","messageId":"1190922917-5044-1-git-send-email-crquan@gmail.com","threadId":"10053","inReplyTo":null,"subject":"[PATCH] gitview: revamped to use string.join, stripped a function def","fromName":"Denis Cheng","fromEmail":"crquan@gmail.com","sentAt":"2007-09-27T19:55:17Z","receivedAt":"2007-09-27T19:55:17Z","isPatch":true,"sender":{"key":"crquan@gmail.com","avatar":"https://gravatar.com/avatar/8689a8a26f5d1c7515ca8226258710684dac5c5208b84a9e16a086377f2d3ded?d=mp&s=160"},"body":"Signed-off-by: Denis Cheng \n---\n contrib/gitview/gitview | 13 +------------\n 1 files changed, 1 insertions(+), 12 deletions(-)\n\ndiff --git a/contrib/gitview/gitview b/contrib/gitview/gitview\nindex 5931766..2eb72b1 100755\n--- a/contrib/gitview/gitview\n+++ b/contrib/gitview/gitview\n@@ -36,17 +36,6 @@ except ImportError:\n \n re_ident = re.compile('(author|committer) (?P.*) (?P\\d+) (?P[+-]\\d{4})')\n \n-def list_to_string(args, skip):\n-\tcount = len(args)\n-\ti = skip\n-\tstr_arg=\" \"\n-\twhile (i < count ):\n-\t\tstr_arg = str_arg + args[i]\n-\t\tstr_arg = str_arg + \" \"\n-\t\ti = i+1\n-\n-\treturn str_arg\n-\n def show_date(epoch, tz):\n \tsecs = float(epoch)\n \ttzsecs = float(tz[1:3]) * 3600\n@@ -1115,7 +1104,7 @@ class GitView(object):\n \n \tdef set_branch(self, args):\n \t\t\"\"\"Fill in different windows with info from the reposiroty\"\"\"\n-\t\tfp = os.popen(\"git rev-parse --sq --default HEAD \" + list_to_string(args, 1))\n+\t\tfp = os.popen(\"git rev-parse --sq --default HEAD \" + \" \".join(args[1:]))\n \t\tgit_rev_list_cmd = fp.read()\n \t\tfp.close()\n \t\tfp = os.popen(\"git rev-list --header --topo-order --parents \" + git_rev_list_cmd)\n-- \n1.5.3.2\n"},{"id":"60456","messageId":"91b13c310711202119j4f9e20f0n2515babe5f9217ac@mail.gmail.com","threadId":"10053","inReplyTo":"1190922917-5044-1-git-send-email-crquan@gmail.com","subject":"Re: [PATCH] gitview: revamped to use string.join, stripped a function def","fromName":"rae l","fromEmail":"crquan@gmail.com","sentAt":"2007-11-21T05:19:30Z","receivedAt":"2007-11-21T05:19:30Z","isPatch":true,"sender":{"key":"crquan@gmail.com","avatar":"https://gravatar.com/avatar/8689a8a26f5d1c7515ca8226258710684dac5c5208b84a9e16a086377f2d3ded?d=mp&s=160"},"body":"Please give some comments.\n\nOn Sep 28, 2007 3:55 AM, Denis Cheng wrote:\n> Signed-off-by: Denis Cheng \n> ---\n> contrib/gitview/gitview | 13 +------------\n> 1 files changed, 1 insertions(+), 12 deletions(-)\n>\n> diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview\n> index 5931766..2eb72b1 100755\n> --- a/contrib/gitview/gitview\n> +++ b/contrib/gitview/gitview\n> @@ -36,17 +36,6 @@ except ImportError:\n>\n> re_ident = re.compile('(author|committer) (?P.*) (?P\\d+) (?P[+-]\\d{4})')\n>\n> -def list_to_string(args, skip):\n> - count = len(args)\n> - i = skip\n> - str_arg=\" \"\n> - while (i < count ):\n> - str_arg = str_arg + args[i]\n> - str_arg = str_arg + \" \"\n> - i = i+1\n> -\n> - return str_arg\n> -\n> def show_date(epoch, tz):\n> secs = float(epoch)\n> tzsecs = float(tz[1:3]) * 3600\n> @@ -1115,7 +1104,7 @@ class GitView(object):\n>\n> def set_branch(self, args):\n> \"\"\"Fill in different windows with info from the reposiroty\"\"\"\n> - fp = os.popen(\"git rev-parse --sq --default HEAD \" + list_to_string(args, 1))\n> + fp = os.popen(\"git rev-parse --sq --default HEAD \" + \" \".join(args[1:]))\n> git_rev_list_cmd = fp.read()\n> fp.close()\n> fp = os.popen(\"git rev-list --header --topo-order --parents \" + git_rev_list_cmd)\n> --\n> 1.5.3.2\n\n-- \nCheng\n"},{"id":"60457","messageId":"20071121062303.GA24495@doorstop.net","threadId":"10053","inReplyTo":"91b13c310711202119j4f9e20f0n2515babe5f9217ac@mail.gmail.com","subject":"Re: [PATCH] gitview: revamped to use string.join, stripped a function def","fromName":"Vineet Kumar","fromEmail":"vineet@doorstop.net","sentAt":"2007-11-21T06:23:03Z","receivedAt":"2007-11-21T06:23:03Z","isPatch":true,"sender":{"key":"vineet@doorstop.net","avatar":"https://gravatar.com/avatar/7eaf4d9b5b3c6cadffd6515fb81ede43381557eaad3e58c7140ff1fc5ccb41dd?d=mp&s=160"},"body":"* rae l (crquan@gmail.com) [071120 21:19]:\n> Please give some comments.\n\nWell I'm just an outside observer, but it looks like a good change to\nme.\n\n-- \nhttp://www.doorstop.net/\n"},{"id":"60464","messageId":"7vfxz0hz2a.fsf@gitster.siamese.dyndns.org","threadId":"10053","inReplyTo":"91b13c310711202119j4f9e20f0n2515babe5f9217ac@mail.gmail.com","subject":"Re: [PATCH] gitview: revamped to use string.join, stripped a function def","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-21T06:50:37Z","receivedAt":"2007-11-21T06:50:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"rae l\" writes:\n\n> Please give some comments.\n>\n> On Sep 28, 2007 3:55 AM, Denis Cheng wrote:\n>> Signed-off-by: Denis Cheng \n\nBlast from the past ;-).\n\n>> -def list_to_string(args, skip):\n>> - count = len(args)\n>> - i = skip\n>> - str_arg=\" \"\n>> - while (i < count ):\n>> - str_arg = str_arg + args[i]\n>> - str_arg = str_arg + \" \"\n>> - i = i+1\n>> -\n>> - return str_arg\n>> ... \n>> \"\"\"Fill in different windows with info from the reposiroty\"\"\"\n>> - fp = os.popen(\"git rev-parse --sq --default HEAD \" + list_to_string(args, 1))\n>> + fp = os.popen(\"git rev-parse --sq --default HEAD \" + \" \".join(args[1:]))\n\nObviously correct, loses extra SPs on both ends of the args\nstring, and reads more Pythonic.\n"}]}