{"thread":{"id":"10049","subject":"Re: Relating to some syntax error in the gitk script","startedAt":"2007-09-27T17:00:27Z","lastAt":"2007-09-28T20:57:22Z","messageCount":2,"participants":["Brett Schwarz","Steffen Prohaska"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"54175","messageId":"915048.40970.qm@web38908.mail.mud.yahoo.com","threadId":"10049","inReplyTo":null,"subject":"Re: Relating to some syntax error in the gitk script","fromName":"Brett Schwarz","fromEmail":"brett_schwarz@yahoo.com","sentAt":"2007-09-27T17:00:27Z","receivedAt":"2007-09-27T17:00:27Z","isPatch":false,"sender":{"key":"brett_schwarz@yahoo.com","avatar":null},"body":"> \n> When I am running the gitk command I get the following error message:-\n> \n> ========================================================================\n> ===========================\n> Error in startup script: syntax error in expression \"$i >= [llength\n> $argv] && $revtreeargs ne {}\"\n>     while executing\n> \"if {$i >= [llength $argv] && $revtreeargs ne {}} {\n>     # no -- on command line, but some arguments (other than -d)\n>     if {[catch {\n>         set f [eval exec...\"\n>     (file \"./gitk\" line 7912)\n> ========================================================================\n> ============================\n> \n> Is there a problem with the script or is it a problem with my\n> environment...?\n> \n\nWhat version of Tcl are you running? You should be using >= 8.4\n\n\n\n\n\n       \n____________________________________________________________________________________\nYahoo! oneSearch: Finally, mobile search \nthat gives answers, not web links. \nhttp://mobile.yahoo.com/mobileweb/onesearch?refer=1ONXIC\n"},{"id":"54289","messageId":"11910130423769-git-send-email-prohaska@zib.de","threadId":"10049","inReplyTo":"915048.40970.qm@web38908.mail.mud.yahoo.com","subject":"[PATCH] gitk: add check for required tcl version >= 8.4","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2007-09-28T20:57:22Z","receivedAt":"2007-09-28T20:57:22Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"gitk requires tcl version >= 8.4 to work flawlessly. So let's\ncheck the tcl version and quit if it's too low.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\n---\n gitk |    5 +++++\n 1 files changed, 5 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 300fdce..6ea6489 100755\n--- a/gitk\n+++ b/gitk\n@@ -7,6 +7,11 @@ exec wish \"$0\" -- \"$@\"\n # and distributed under the terms of the GNU General Public Licence,\n # either version 2, or (at your option) any later version.\n \n+if {[info tclversion] < 8.4} {\n+   puts stderr \"Sorry, gitk requires tcl version >= 8.4.\"\n+   exit 1 \n+}\n+\n proc gitdir {} {\n     global env\n     if {[info exists env(GIT_DIR)]} {\n-- \n1.5.3.2.111.g5166\n"}]}